From: Alexander Barton <alex@barton.de>
Date: Tue, 18 Mar 2014 15:27:03 +0000 (+0100)
Subject: Spoofed prefixes: Really kill connection on non-server links
X-Git-Tag: rel-22-rc1~29
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=commitdiff_plain;h=5009ab3e8c5a6fe7db5c5ad1d3fdc8aecfc64b55

Spoofed prefixes: Really kill connection on non-server links

This fixes commit 6cbe1308 which only killed the connection when the
spoofed prefix itself belonged to a non-server client.
---

diff --git a/src/ngircd/parse.c b/src/ngircd/parse.c
index 94230c87..28dee6fc 100644
--- a/src/ngircd/parse.c
+++ b/src/ngircd/parse.c
@@ -342,7 +342,7 @@ Validate_Prefix( CONN_ID Idx, REQUEST *Req, bool *Closed )
 	/* check if the client named in the prefix is expected
 	 * to come from that direction */
 	if (Client_NextHop(c) != client) {
-		if (Client_Type(c) != CLIENT_SERVER) {
+		if (Client_Type(client) != CLIENT_SERVER) {
 			Log(LOG_ERR,
 			    "Spoofed prefix \"%s\" from \"%s\" (connection %d, command \"%s\"), closing connection!",
 			    Req->prefix, Client_ID(client), Idx, Req->command);