From: Alexander Barton <alex@barton.de>
Date: Wed, 11 Mar 2015 23:28:31 +0000 (+0100)
Subject: Fix "WHO #<chan>" showing invisible users and hiding all visible
X-Git-Tag: rel-22.1~6
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=commitdiff_plain;h=2196e945e4ac5f41d6650c4ceb9120cfd8fc8d56;ds=sidebyside

Fix "WHO #<chan>" showing invisible users and hiding all visible

The logic is reversed ...

This bug has been introduced by commit c74115f2, "Simplify mode checking on
channels and users within a channel", ngIRCd releases 21, 21.1, and 22 are
affected :-(

Problem reported by Cahata in #ngircd, Thanks!
---

diff --git a/src/ngircd/irc-info.c b/src/ngircd/irc-info.c
index 763c9302..61c6239c 100644
--- a/src/ngircd/irc-info.c
+++ b/src/ngircd/irc-info.c
@@ -162,7 +162,7 @@ IRC_WHO_Channel(CLIENT *Client, CHANNEL *Chan, bool OnlyOps)
 		if (OnlyOps && !is_ircop)
 			continue;
 
-		is_visible = Client_HasMode(c, 'i');
+		is_visible = !Client_HasMode(c, 'i');
 		if (is_member || is_visible) {
 			memset(flags, 0, sizeof(flags));