From: michi <michi+ngircd@dataswamp.org>
Date: Tue, 21 Apr 2020 11:02:08 +0000 (+0200)
Subject: Allow hostmask cloaking when rDNS is disabled
X-Git-Tag: rel-26-rc1~13
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=commitdiff_plain;h=1f40776bc166ece8dad0d333905481aa28786cb5

Allow hostmask cloaking when rDNS is disabled
---

diff --git a/src/ngircd/client.c b/src/ngircd/client.c
index 118431b1..1c7bd1ea 100644
--- a/src/ngircd/client.c
+++ b/src/ngircd/client.c
@@ -337,9 +337,11 @@ Client_SetHostname( CLIENT *Client, const char *Hostname )
 	assert(Client != NULL);
 	assert(Hostname != NULL);
 
-	/* Only cloak the hostmask if it has not yet been cloaked (the period
-	 * or colon indicates it's still an IP address). */
-	if (Conf_CloakHost[0] && strpbrk(Client->host, ".:")) {
+	/* Only cloak the hostmask if it has not yet been cloaked.
+	 * The period or colon indicates it's still an IP address.
+	 * An empty string means a rDNS lookup did not happen (yet).
+         */
+	if (Conf_CloakHost[0] && (!Client->host[0] || strpbrk(Client->host, ".:"))) {
 		char cloak[GETID_LEN];
 
 		strlcpy(cloak, Hostname, GETID_LEN);