From: Alexander Barton <alex@barton.de>
Date: Mon, 27 Aug 2012 21:20:32 +0000 (+0200)
Subject: Only allow IRC services to modify user mode "R"
X-Git-Tag: rel-20-rc1~98^2
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=commitdiff_plain;h=186ab51137886166ad56f1682d7caafff61cf304

Only allow IRC services to modify user mode "R"
---

diff --git a/src/ngircd/irc-mode.c b/src/ngircd/irc-mode.c
index 17769360..ca4cdd06 100644
--- a/src/ngircd/irc-mode.c
+++ b/src/ngircd/irc-mode.c
@@ -256,9 +256,8 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
 							ERR_RESTRICTED_MSG,
 							Client_ID(Origin));
 			break;
-		case 'R': /* Registered (only unsettable) */
-			if (!set || Client_Type(Client) == CLIENT_SERVICE
-				 || Client_Type(Client) == CLIENT_SERVER)
+		case 'R': /* Registered (not [un]settable by clients) */
+			if (Client_Type(Client) == CLIENT_SERVER)
 				x[0] = 'R';
 			else
 				ok = IRC_WriteStrClient(Origin,
diff --git a/src/ngircd/messages.h b/src/ngircd/messages.h
index 4aed70f3..82cc30fe 100644
--- a/src/ngircd/messages.h
+++ b/src/ngircd/messages.h
@@ -138,7 +138,7 @@
 #define ERR_CHANOPRIVSNEEDED_MSG	"482 %s %s :You are not channel operator"
 #define ERR_CANTKILLSERVER_MSG		"483 %s :You can't kill a server!"
 #define ERR_RESTRICTED_MSG		"484 %s :Your connection is restricted"
-#define ERR_NICKREGISTER_MSG		"484 %s :Cannot set user mode (+R) -- Use IRC services"
+#define ERR_NICKREGISTER_MSG		"484 %s :Cannot modify user mode (+R) -- Use IRC services"
 #define ERR_NOOPERHOST_MSG		"491 %s :Not configured for your host"
 #define ERR_NOTONSAMECHANNEL_MSG	"493 %s :You must share a common channel with %s"