From: Florian Westphal <fw@strlen.de>
Date: Fri, 29 Apr 2011 21:15:05 +0000 (+0200)
Subject: parse: fix logical expression testing for non RFC1459 links
X-Git-Tag: rel-18-rc1~15
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=commitdiff_plain;h=05748aa5eeaf75438a0bb238967667605fe4d52e

parse: fix logical expression testing for non RFC1459 links

parse.c:284: warning: suggest parentheses around operand of '!' or
change '&' to '&&' or '!' to '~'

The expression looks dubious, this should probably be
an if-not-set, then... test.
---

diff --git a/src/ngircd/parse.c b/src/ngircd/parse.c
index d7dbffc2..c2603918 100644
--- a/src/ngircd/parse.c
+++ b/src/ngircd/parse.c
@@ -280,7 +280,7 @@ Validate_Prefix( CONN_ID Idx, REQUEST *Req, bool *Closed )
 	assert( client != NULL );
 
 	if (!Req->prefix && Client_Type(client) == CLIENT_SERVER
-	    && !Conn_Options(Idx) & CONN_RFC1459
+	    && !(Conn_Options(Idx) & CONN_RFC1459)
 	    && strcasecmp(Req->command, "ERROR") != 0
 	    && strcasecmp(Req->command, "PING") != 0)
 	{