X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=blobdiff_plain;f=src%2Fngircd%2Firc-info.c;h=4909a96a063a3a9940be0e52d9b9e070925a28c9;hp=7a122ef790a0c5ec0148c3224b83956a8de00020;hb=1f2aa4da6f62124bdbed4f2dce7e40ed4b411e2a;hpb=f37600ee01f6cfd86e8fa80f77ee26ebaf3012b2

diff --git a/src/ngircd/irc-info.c b/src/ngircd/irc-info.c
index 7a122ef7..4909a96a 100644
--- a/src/ngircd/irc-info.c
+++ b/src/ngircd/irc-info.c
@@ -117,7 +117,7 @@ IRC_INFO(CLIENT * Client, REQUEST * Req)
 		target = Client_Search(Req->argv[0]);
 	else
 		target = Client_ThisServer();
-	
+
 	/* Make sure that the target is a server */
 	if (target && Client_Type(target) != CLIENT_SERVER)
 		target = Client_Introducer(target);
@@ -807,12 +807,22 @@ who_flags_status(const char *client_modes)
 }
 
 
+/**
+ * Return channel user mode prefix(es).
+ *
+ * @param Client The client requesting the mode prefixes.
+ * @param chan_user_modes String with channel user modes.
+ * @param str String buffer to which the prefix(es) will be appended.
+ * @param len Size of "str" buffer.
+ * @return Pointer to "str".
+ */
 static char *
-who_flags_qualifier(CLIENT *Client, const char *chan_user_modes, char *str, size_t len)
+who_flags_qualifier(CLIENT *Client, const char *chan_user_modes,
+		    char *str, size_t len)
 {
 	assert(Client != NULL);
-    
-	if (Client_Cap(Client) & CLIENT_CAP_MULTI_PREFIX) {		
+
+	if (Client_Cap(Client) & CLIENT_CAP_MULTI_PREFIX) {
 		if (strchr(chan_user_modes, 'q'))
 			strlcat(str, "~", len);
 		if (strchr(chan_user_modes, 'a'))
@@ -820,13 +830,13 @@ who_flags_qualifier(CLIENT *Client, const char *chan_user_modes, char *str, size
 		if (strchr(chan_user_modes, 'o'))
 			strlcat(str, "@", len);
 		if (strchr(chan_user_modes, 'h'))
-			strlcat(str, "&", len);
+			strlcat(str, "%", len);
 		if (strchr(chan_user_modes, 'v'))
 			strlcat(str, "+", len);
-		
+
 		return str;
 	}
-	
+
 	if (strchr(chan_user_modes, 'q'))
 		strlcat(str, "~", len);
 	else if (strchr(chan_user_modes, 'a'))
@@ -837,7 +847,7 @@ who_flags_qualifier(CLIENT *Client, const char *chan_user_modes, char *str, size
 		strlcat(str, "%", len);
 	else if (strchr(chan_user_modes, 'v'))
 		strlcat(str, "+", len);
-	
+
 	return str;
 }
 
@@ -856,7 +866,6 @@ IRC_WHO_Channel(CLIENT *Client, CHANNEL *Chan, bool OnlyOps)
 	bool is_visible, is_member, is_ircop;
 	CL2CHAN *cl2chan;
 	const char *client_modes;
-	const char *chan_user_modes;
 	char flags[10];
 	CLIENT *c;
 	int count = 0;
@@ -888,9 +897,9 @@ IRC_WHO_Channel(CLIENT *Client, CHANNEL *Chan, bool OnlyOps)
 			if (is_ircop)
 				strlcat(flags, "*", sizeof(flags));
 
-			chan_user_modes = Channel_UserModes(Chan, c);
-			who_flags_qualifier(c, chan_user_modes, flags, sizeof(flags));
- 
+			who_flags_qualifier(Client, Channel_UserModes(Chan, c),
+					    flags, sizeof(flags));
+
 			if (!write_whoreply(Client, c, Channel_Name(Chan),
 					    flags))
 				return DISCONNECTED;
@@ -1105,7 +1114,8 @@ IRC_WHOIS_SendReply(CLIENT *Client, CLIENT *from, CLIENT *c)
 		if (str[strlen(str) - 1] != ':')
 			strlcat(str, " ", sizeof(str));
 
-		who_flags_qualifier(c, Channel_UserModes(chan, c), str, sizeof(str));
+		who_flags_qualifier(Client, Channel_UserModes(chan, c),
+				    str, sizeof(str));
 		strlcat(str, Channel_Name(chan), sizeof(str));
 
 		if (strlen(str) > (LINE_LEN - CHANNEL_NAME_LEN - 4)) {
@@ -1479,7 +1489,7 @@ IRC_Send_LUSERS(CLIENT *Client)
 			Conn_CountMax(), Conn_CountAccepted()))
 		return DISCONNECTED;
 #endif
-	
+
 	return CONNECTED;
 } /* IRC_Send_LUSERS */
 
@@ -1609,8 +1619,9 @@ IRC_Send_NAMES(CLIENT * Client, CHANNEL * Chan)
 		if (is_member || is_visible) {
 			if (str[strlen(str) - 1] != ':')
 				strlcat(str, " ", sizeof(str));
-			
-			who_flags_qualifier(cl,	Channel_UserModes(Chan, cl), str, sizeof(str));
+
+			who_flags_qualifier(Client, Channel_UserModes(Chan, cl),
+					    str, sizeof(str));
 			strlcat(str, Client_ID(cl), sizeof(str));
 
 			if (strlen(str) > (LINE_LEN - CLIENT_NICK_LEN - 4)) {