]> arthur.barton.de Git - ngircd-alex.git/blobdiff - src/ngircd/irc-mode.c
Rework check for number of parameters
[ngircd-alex.git] / src / ngircd / irc-mode.c
index 907c929766f9355b8d201a7fee3eaac218fd574e..38fec0d028b5761bcf2bd432a2633cae9871f7fc 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * ngIRCd -- The Next Generation IRC Daemon
- * Copyright (c)2001-2012 Alexander Barton (alex@barton.de) and Contributors.
+ * Copyright (c)2001-2013 Alexander Barton (alex@barton.de) and Contributors.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -25,6 +25,7 @@
 #include "defines.h"
 #include "conn.h"
 #include "channel.h"
+#include "irc-macros.h"
 #include "irc-write.h"
 #include "lists.h"
 #include "log.h"
@@ -35,9 +36,6 @@
 #include "exp.h"
 #include "irc-mode.h"
 
-
-static void Announce_Client_Hostname PARAMS((CLIENT *Origin, CLIENT *Client));
-
 static bool Client_Mode PARAMS((CLIENT *Client, REQUEST *Req, CLIENT *Origin,
                                CLIENT *Target));
 static bool Channel_Mode PARAMS((CLIENT *Client, REQUEST *Req, CLIENT *Origin,
@@ -52,16 +50,15 @@ static bool Send_ListChange PARAMS((const bool IsAdd, const char ModeChar,
                                    CLIENT *Prefix, CLIENT *Client,
                                    CHANNEL *Channel, const char *Mask));
 
-
 /**
  * Handler for the IRC "MODE" command.
  *
- * See RFC 2812 section 3.1.5 ("user mode message") and section 3.2.3
- * ("channel mode message"), and RFC 2811 section 4 ("channel modes").
+ * This function detects whether user or channel modes should be modified
+ * and calls the appropriate sub-functions.
  *
- * @param Client       The client from which this command has been received.
- * @param Req          Request structure with prefix and all parameters.
- * @returns            CONNECTED or DISCONNECTED.
+ * @param Client The client from which this command has been received.
+ * @param Req Request structure with prefix and all parameters.
+ * @return CONNECTED or DISCONNECTED.
  */
 GLOBAL bool
 IRC_MODE( CLIENT *Client, REQUEST *Req )
@@ -72,20 +69,7 @@ IRC_MODE( CLIENT *Client, REQUEST *Req )
        assert(Client != NULL);
        assert(Req != NULL);
 
-       /* No parameters? */
-       if (Req->argc < 1)
-               return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
-                                         Client_ID(Client), Req->command);
-
-       /* Origin for answers */
-       if (Client_Type(Client) == CLIENT_SERVER) {
-               origin = Client_Search(Req->prefix);
-               if (!origin)
-                       return IRC_WriteStrClient(Client, ERR_NOSUCHNICK_MSG,
-                                                 Client_ID(Client),
-                                                 Req->prefix);
-       } else
-               origin = Client;
+       _IRC_GET_SENDER_OR_RETURN_(origin, Req, Client)
 
        /* Channel or user mode? */
        cl = NULL; chan = NULL;
@@ -100,11 +84,10 @@ IRC_MODE( CLIENT *Client, REQUEST *Req )
                return Channel_Mode(Client, Req, origin, chan);
 
        /* No target found! */
-       return IRC_WriteStrClient(Client, ERR_NOSUCHNICK_MSG,
+       return IRC_WriteErrClient(Client, ERR_NOSUCHNICK_MSG,
                        Client_ID(Client), Req->argv[0]);
 } /* IRC_MODE */
 
-
 /**
  * Check if the "mode limit" for a client has been reached.
  *
@@ -125,15 +108,14 @@ Mode_Limit_Reached(CLIENT *Client, int Count)
        return true;
 }
 
-
 /**
  * Handle client mode requests
  *
- * @param Client       The client from which this command has been received.
- * @param Req          Request structure with prefix and all parameters.
- * @param Origin       The originator of the MODE command (prefix).
- * @param Target       The target (client) of this MODE command.
- * @returns            CONNECTED or DISCONNECTED.
+ * @param Client The client from which this command has been received.
+ * @param Req Request structure with prefix and all parameters.
+ * @param Origin The originator of the MODE command (prefix).
+ * @param Target The target (client) of this MODE command.
+ * @return CONNECTED or DISCONNECTED.
  */
 static bool
 Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
@@ -148,7 +130,7 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
        if (Client_Type(Client) == CLIENT_USER) {
                /* Users are only allowed to manipulate their own modes! */
                if (Target != Client)
-                       return IRC_WriteStrClient(Client,
+                       return IRC_WriteErrClient(Client,
                                                  ERR_USERSDONTMATCH_MSG,
                                                  Client_ID(Client));
        }
@@ -156,7 +138,7 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
        /* Mode request: let's answer it :-) */
        if (Req->argc == 1)
                return IRC_WriteStrClient(Origin, RPL_UMODEIS_MSG,
-                                         Client_ID(Origin),
+                                         Client_ID(Target),
                                          Client_Modes(Target));
 
        mode_arg = 1;
@@ -170,7 +152,7 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
                set = false;
                strcpy(the_modes, "-");
        } else
-               return IRC_WriteStrClient(Origin, ERR_UMODEUNKNOWNFLAG_MSG,
+               return IRC_WriteErrClient(Origin, ERR_UMODEUNKNOWNFLAG_MSG,
                                          Client_ID(Origin));
 
        x[1] = '\0';
@@ -229,13 +211,13 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
                                x[0] = 'a';
                                Client_SetAway(Origin, DEFAULT_AWAY_MSG);
                        } else
-                               ok = IRC_WriteStrClient(Origin,
+                               ok = IRC_WriteErrClient(Origin,
                                                        ERR_NOPRIVILEGES_MSG,
                                                        Client_ID(Origin));
                        break;
                case 'B': /* Bot */
                        if (Client_HasMode(Client, 'r'))
-                               ok = IRC_WriteStrClient(Origin,
+                               ok = IRC_WriteErrClient(Origin,
                                                        ERR_RESTRICTED_MSG,
                                                        Client_ID(Origin));
                        else
@@ -247,7 +229,7 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
                            || Client_OperByMe(Origin))
                                x[0] = 'c';
                        else
-                               ok = IRC_WriteStrClient(Origin,
+                               ok = IRC_WriteErrClient(Origin,
                                                        ERR_NOPRIVILEGES_MSG,
                                                        Client_ID(Origin));
                        break;
@@ -256,7 +238,7 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
                                Client_SetOperByMe(Target, false);
                                x[0] = 'o';
                        } else
-                               ok = IRC_WriteStrClient(Origin,
+                               ok = IRC_WriteErrClient(Origin,
                                                        ERR_NOPRIVILEGES_MSG,
                                                        Client_ID(Origin));
                        break;
@@ -265,7 +247,7 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
                            || Client_OperByMe(Origin))
                                x[0] = 'q';
                        else
-                               ok = IRC_WriteStrClient(Origin,
+                               ok = IRC_WriteErrClient(Origin,
                                                        ERR_NOPRIVILEGES_MSG,
                                                        Client_ID(Origin));
                        break;
@@ -273,7 +255,7 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
                        if (set || Client_Type(Client) == CLIENT_SERVER)
                                x[0] = 'r';
                        else
-                               ok = IRC_WriteStrClient(Origin,
+                               ok = IRC_WriteErrClient(Origin,
                                                        ERR_RESTRICTED_MSG,
                                                        Client_ID(Origin));
                        break;
@@ -281,13 +263,13 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
                        if (Client_Type(Client) == CLIENT_SERVER)
                                x[0] = 'R';
                        else
-                               ok = IRC_WriteStrClient(Origin,
+                               ok = IRC_WriteErrClient(Origin,
                                                        ERR_NICKREGISTER_MSG,
                                                        Client_ID(Origin));
                        break;
                case 'x': /* Cloak hostname */
                        if (Client_HasMode(Client, 'r'))
-                               ok = IRC_WriteStrClient(Origin,
+                               ok = IRC_WriteErrClient(Origin,
                                                        ERR_RESTRICTED_MSG,
                                                        Client_ID(Origin));
                        else if (!set || Conf_CloakHostModeX[0]
@@ -296,7 +278,7 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
                                x[0] = 'x';
                                send_RPL_HOSTHIDDEN_MSG = true;
                        } else
-                               ok = IRC_WriteStrClient(Origin,
+                               ok = IRC_WriteErrClient(Origin,
                                                        ERR_NOPRIVILEGES_MSG,
                                                        Client_ID(Origin));
                        break;
@@ -306,7 +288,7 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
                                    "Unknown mode \"%c%c\" from \"%s\"!?",
                                    set ? '+' : '-', *mode_ptr,
                                    Client_ID(Origin));
-                               ok = IRC_WriteStrClient(Origin,
+                               ok = IRC_WriteErrClient(Origin,
                                                        ERR_UMODEUNKNOWNFLAG2_MSG,
                                                        Client_ID(Origin),
                                                        set ? '+' : '-',
@@ -368,9 +350,17 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
                                                  "MODE %s :%s",
                                                  Client_ID(Target),
                                                  the_modes);
-                       if (send_RPL_HOSTHIDDEN_MSG)
-                               Announce_Client_Hostname(Origin, Client);
                }
+
+               if (send_RPL_HOSTHIDDEN_MSG && Client_Conn(Target) > NONE) {
+                       /* A new (cloaked) hostname must be announced */
+                       IRC_WriteStrClientPrefix(Target, Origin,
+                                                RPL_HOSTHIDDEN_MSG,
+                                                Client_ID(Target),
+                                                Client_HostnameDisplayed(Target));
+
+               }
+
                LogDebug("%s \"%s\": Mode change, now \"%s\".",
                         Client_TypeText(Target), Client_Mask(Target),
                         Client_Modes(Target));
@@ -380,28 +370,13 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
        return ok;
 } /* Client_Mode */
 
-
-/**
- * Announce changed client hostname in the network.
+/*
+ * Reply to a channel mode request.
  *
- * @param Client The client of which the hostname changed.
+ * @param Origin The originator of the MODE command (prefix).
+ * @param Channel The channel of which the modes should be sent.
+ * @return CONNECTED or DISCONNECTED.
  */
-static void
-Announce_Client_Hostname(CLIENT *Origin, CLIENT *Client)
-{
-       assert(Client != NULL);
-
-       /* Inform the client itself */
-       IRC_WriteStrClient(Client, RPL_HOSTHIDDEN_MSG, Client_ID(Client),
-                          Client_HostnameDisplayed(Client));
-
-       /* Inform other servers in the network */
-       IRC_WriteStrServersPrefixFlag(Origin, Client_ThisServer(), 'M',
-                                     "METADATA %s host :%s", Client_ID(Client),
-                                     Client_HostnameDisplayed(Client));
-}
-
-
 static bool
 Channel_Mode_Answer_Request(CLIENT *Origin, CHANNEL *Channel)
 {
@@ -447,15 +422,20 @@ Channel_Mode_Answer_Request(CLIENT *Origin, CHANNEL *Channel)
        return CONNECTED;
 }
 
-
 /**
  * Handle channel mode and channel-user mode changes
+ *
+ * @param Client The client from which this command has been received.
+ * @param Req Request structure with prefix and all parameters.
+ * @param Origin The originator of the MODE command (prefix).
+ * @param Channel The target channel of this MODE command.
+ * @return CONNECTED or DISCONNECTED.
  */
 static bool
 Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
 {
        char the_modes[COMMAND_LEN], the_args[COMMAND_LEN], x[2],
-           argadd[CLIENT_PASS_LEN], *mode_ptr, *o_mode_ptr;
+           argadd[CLIENT_PASS_LEN], *mode_ptr;
        bool connected, set, skiponce, retval, use_servermode,
             is_halfop, is_op, is_admin, is_owner, is_machine, is_oper;
        int mode_arg, arg_arg, mode_arg_count = 0;
@@ -466,7 +446,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
        is_halfop = is_op = is_admin = is_owner = is_machine = is_oper = false;
 
        if (Channel_IsModeless(Channel))
-               return IRC_WriteStrClient(Client, ERR_NOCHANMODES_MSG,
+               return IRC_WriteErrClient(Client, ERR_NOCHANMODES_MSG,
                                Client_ID(Client), Channel_Name(Channel));
 
        /* Mode request: let's answer it :-) */
@@ -487,7 +467,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
 
        /* Check if client is member of channel or an oper or an server/service */
        if(!Channel_IsMemberOf(Channel, Client) && !is_oper && !is_machine)
-               return IRC_WriteStrClient(Origin, ERR_NOTONCHANNEL_MSG,
+               return IRC_WriteErrClient(Origin, ERR_NOTONCHANNEL_MSG,
                                          Client_ID(Origin),
                                          Channel_Name(Channel));
 
@@ -565,19 +545,15 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                if (arg_arg >= Req->argc)
                        arg_arg = -1;
 
-               if(!is_machine) {
-                       o_mode_ptr = Channel_UserModes(Channel, Client);
-                       while( *o_mode_ptr ) {
-                               if ( *o_mode_ptr == 'q')
-                                       is_owner = true;
-                               if ( *o_mode_ptr == 'a')
-                                       is_admin = true;
-                               if ( *o_mode_ptr == 'o')
-                                       is_op = true;
-                               if ( *o_mode_ptr == 'h')
-                                       is_halfop = true;
-                               o_mode_ptr++;
-                       }
+               if(!is_machine && !is_oper) {
+                       if (Channel_UserHasMode(Channel, Client, 'q'))
+                               is_owner = true;
+                       if (Channel_UserHasMode(Channel, Client, 'a'))
+                               is_admin = true;
+                       if (Channel_UserHasMode(Channel, Client, 'o'))
+                               is_op = true;
+                       if (Channel_UserHasMode(Channel, Client, 'h'))
+                               is_halfop = true;
                }
 
                /* Validate modes */
@@ -591,7 +567,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                case 'z': /* Secure connections only */
                        if(!is_oper && !is_machine && !is_owner &&
                           !is_admin && !is_op) {
-                               connected = IRC_WriteStrClient(Origin,
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_CHANOPRIVSNEEDED_MSG,
                                        Client_ID(Origin), Channel_Name(Channel));
                                goto chan_exit;
@@ -607,7 +583,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                           is_admin || is_op || is_halfop)
                                x[0] = *mode_ptr;
                        else
-                               connected = IRC_WriteStrClient(Origin,
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_CHANOPRIVSNEEDED_MSG,
                                        Client_ID(Origin), Channel_Name(Channel));
                        break;
@@ -619,7 +595,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                    is_admin || is_op || is_halfop)
                                        x[0] = *mode_ptr;
                                else
-                                       connected = IRC_WriteStrClient(Origin,
+                                       connected = IRC_WriteErrClient(Origin,
                                                ERR_CHANOPRIVSNEEDED_MSG,
                                                Client_ID(Origin),
                                                Channel_Name(Channel));
@@ -635,7 +611,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                                sizeof(argadd));
                                        x[0] = *mode_ptr;
                                } else {
-                                       connected = IRC_WriteStrClient(Origin,
+                                       connected = IRC_WriteErrClient(Origin,
                                                ERR_CHANOPRIVSNEEDED_MSG,
                                                Client_ID(Origin),
                                                Channel_Name(Channel));
@@ -643,9 +619,13 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                Req->argv[arg_arg][0] = '\0';
                                arg_arg++;
                        } else {
-                               connected = IRC_WriteStrClient(Origin,
+#ifdef STRICT_RFC
+                               /* Only send error message in "strict" mode,
+                                * this is how ircd2.11 and others behave ... */
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_NEEDMOREPARAMS_MSG,
                                        Client_ID(Origin), Req->command);
+#endif
                                goto chan_exit;
                        }
                        break;
@@ -657,7 +637,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                    is_admin || is_op || is_halfop)
                                        x[0] = *mode_ptr;
                                else
-                                       connected = IRC_WriteStrClient(Origin,
+                                       connected = IRC_WriteErrClient(Origin,
                                                ERR_CHANOPRIVSNEEDED_MSG,
                                                Client_ID(Origin),
                                                Channel_Name(Channel));
@@ -675,7 +655,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                                x[0] = *mode_ptr;
                                        }
                                } else {
-                                       connected = IRC_WriteStrClient(Origin,
+                                       connected = IRC_WriteErrClient(Origin,
                                                ERR_CHANOPRIVSNEEDED_MSG,
                                                Client_ID(Origin),
                                                Channel_Name(Channel));
@@ -683,9 +663,13 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                Req->argv[arg_arg][0] = '\0';
                                arg_arg++;
                        } else {
-                               connected = IRC_WriteStrClient(Origin,
+#ifdef STRICT_RFC
+                               /* Only send error message in "strict" mode,
+                                * this is how ircd2.11 and others behave ... */
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_NEEDMOREPARAMS_MSG,
                                        Client_ID(Origin), Req->command);
+#endif
                                goto chan_exit;
                        }
                        break;
@@ -696,14 +680,14 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                if(is_oper || is_machine)
                                        x[0] = 'O';
                                else
-                                       connected = IRC_WriteStrClient(Origin,
+                                       connected = IRC_WriteErrClient(Origin,
                                                ERR_NOPRIVILEGES_MSG,
                                                Client_ID(Origin));
                        } else if(is_oper || is_machine || is_owner ||
                                  is_admin || is_op)
                                x[0] = 'O';
                        else
-                               connected = IRC_WriteStrClient(Origin,
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_CHANOPRIVSNEEDED_MSG,
                                        Client_ID(Origin),
                                        Channel_Name(Channel));
@@ -715,14 +699,14 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                if(is_oper || is_machine)
                                        x[0] = 'P';
                                else
-                                       connected = IRC_WriteStrClient(Origin,
+                                       connected = IRC_WriteErrClient(Origin,
                                                ERR_NOPRIVILEGES_MSG,
                                                Client_ID(Origin));
                        } else if(is_oper || is_machine || is_owner ||
                                  is_admin || is_op)
                                x[0] = 'P';
                        else
-                               connected = IRC_WriteStrClient(Origin,
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_CHANOPRIVSNEEDED_MSG,
                                        Client_ID(Origin),
                                        Channel_Name(Channel));
@@ -731,7 +715,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                case 'q': /* Owner */
                case 'a': /* Channel admin */
                        if(!is_oper && !is_machine && !is_owner && !is_admin) {
-                               connected = IRC_WriteStrClient(Origin,
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_CHANOPPRIVTOOLOW_MSG,
                                        Client_ID(Origin),
                                        Channel_Name(Channel));
@@ -740,7 +724,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                case 'o': /* Channel operator */
                        if(!is_oper && !is_machine && !is_owner &&
                           !is_admin && !is_op) {
-                               connected = IRC_WriteStrClient(Origin,
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_CHANOPRIVSNEEDED_MSG,
                                        Client_ID(Origin),
                                        Channel_Name(Channel));
@@ -749,7 +733,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                case 'h': /* Half Op */
                        if(!is_oper && !is_machine && !is_owner &&
                           !is_admin && !is_op) {
-                               connected = IRC_WriteStrClient(Origin,
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_CHANOPRIVSNEEDED_MSG,
                                        Client_ID(Origin),
                                        Channel_Name(Channel));
@@ -763,12 +747,12 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                        if (client)
                                                x[0] = *mode_ptr;
                                        else
-                                               connected = IRC_WriteStrClient(Origin,
+                                               connected = IRC_WriteErrClient(Origin,
                                                        ERR_NOSUCHNICK_MSG,
                                                        Client_ID(Origin),
                                                        Req->argv[arg_arg]);
                                } else {
-                                       connected = IRC_WriteStrClient(Origin,
+                                       connected = IRC_WriteErrClient(Origin,
                                                ERR_CHANOPRIVSNEEDED_MSG,
                                                Client_ID(Origin),
                                                Channel_Name(Channel));
@@ -776,9 +760,17 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                Req->argv[arg_arg][0] = '\0';
                                arg_arg++;
                        } else {
-                               connected = IRC_WriteStrClient(Origin,
+#ifdef STRICT_RFC
+                               /* Report an error to the client, when a user
+                                * mode should be changed but no nickname is
+                                * given. But don't do it when not in "strict"
+                                * mode, because most other servers don't do
+                                * it as well and some clients send "wired"
+                                * MODE commands like "MODE #chan -ooo nick". */
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_NEEDMOREPARAMS_MSG,
                                        Client_ID(Origin), Req->command);
+#endif
                                goto chan_exit;
                        }
                        break;
@@ -800,7 +792,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                                Client, Channel,
                                                Req->argv[arg_arg]);
                                } else {
-                                       connected = IRC_WriteStrClient(Origin,
+                                       connected = IRC_WriteErrClient(Origin,
                                                ERR_CHANOPRIVSNEEDED_MSG,
                                                Client_ID(Origin),
                                                Channel_Name(Channel));
@@ -827,7 +819,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
                                    "Unknown mode \"%c%c\" from \"%s\" on %s!?",
                                    set ? '+' : '-', *mode_ptr,
                                    Client_ID(Origin), Channel_Name(Channel));
-                               connected = IRC_WriteStrClient(Origin,
+                               connected = IRC_WriteErrClient(Origin,
                                        ERR_UNKNOWNMODE_MSG,
                                        Client_ID(Origin), *mode_ptr,
                                        Channel_Name(Channel));
@@ -850,12 +842,11 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
 
                /* Validate target client */
                if (client && (!Channel_IsMemberOf(Channel, client))) {
-                       if (!IRC_WriteStrClient
-                           (Origin, ERR_USERNOTINCHANNEL_MSG,
-                            Client_ID(Origin), Client_ID(client),
-                            Channel_Name(Channel)))
+                       if (!IRC_WriteErrClient(Origin, ERR_USERNOTINCHANNEL_MSG,
+                                               Client_ID(Origin),
+                                               Client_ID(client),
+                                               Channel_Name(Channel)))
                                break;
-
                        continue;
                }
 
@@ -940,31 +931,35 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
        return connected;
 } /* Channel_Mode */
 
-
+/**
+ * Handler for the IRC "AWAY" command.
+ *
+ * @param Client The client from which this command has been received.
+ * @param Req Request structure with prefix and all parameters.
+ * @return CONNECTED or DISCONNECTED.
+ */
 GLOBAL bool
 IRC_AWAY( CLIENT *Client, REQUEST *Req )
 {
-       assert( Client != NULL );
-       assert( Req != NULL );
-
-       if( Req->argc > 1 ) return IRC_WriteStrClient( Client, ERR_NEEDMOREPARAMS_MSG, Client_ID( Client ), Req->command );
-
-       if(( Req->argc == 1 ) && (Req->argv[0][0] ))
-       {
-               Client_SetAway( Client, Req->argv[0] );
-               Client_ModeAdd( Client, 'a' );
-               IRC_WriteStrServersPrefix( Client, Client, "MODE %s :+a", Client_ID( Client ));
-               return IRC_WriteStrClient( Client, RPL_NOWAWAY_MSG, Client_ID( Client ));
-       }
-       else
-       {
-               Client_ModeDel( Client, 'a' );
-               IRC_WriteStrServersPrefix( Client, Client, "MODE %s :-a", Client_ID( Client ));
-               return IRC_WriteStrClient( Client, RPL_UNAWAY_MSG, Client_ID( Client ));
+       assert (Client != NULL);
+       assert (Req != NULL);
+
+       if (Req->argc == 1 && Req->argv[0][0]) {
+               Client_SetAway(Client, Req->argv[0]);
+               Client_ModeAdd(Client, 'a');
+               IRC_WriteStrServersPrefix(Client, Client, "MODE %s :+a",
+                                         Client_ID( Client));
+               return IRC_WriteStrClient(Client, RPL_NOWAWAY_MSG,
+                                         Client_ID( Client));
+       } else {
+               Client_ModeDel(Client, 'a');
+               IRC_WriteStrServersPrefix(Client, Client, "MODE %s :-a",
+                                         Client_ID( Client));
+               return IRC_WriteStrClient(Client, RPL_UNAWAY_MSG,
+                                         Client_ID( Client));
        }
 } /* IRC_AWAY */
 
-
 /**
  * Add entries to channel invite, ban and exception lists.
  *
@@ -979,7 +974,7 @@ static bool
 Add_To_List(char what, CLIENT *Prefix, CLIENT *Client, CHANNEL *Channel,
            const char *Pattern)
 {
-       const char *mask;
+       char mask[MASK_LEN];
        struct list_head *list = NULL;
        long int current_count;
 
@@ -988,7 +983,7 @@ Add_To_List(char what, CLIENT *Prefix, CLIENT *Client, CHANNEL *Channel,
        assert(Pattern != NULL);
        assert(what == 'I' || what == 'b' || what == 'e');
 
-       mask = Lists_MakeMask(Pattern);
+       Lists_MakeMask(Pattern, mask, sizeof(mask));
        current_count = Lists_Count(Channel_GetListInvites(Channel))
                        + Lists_Count(Channel_GetListExcepts(Channel))
                        + Lists_Count(Channel_GetListBans(Channel));
@@ -1009,7 +1004,7 @@ Add_To_List(char what, CLIENT *Prefix, CLIENT *Client, CHANNEL *Channel,
                return CONNECTED;
        if (Client_Type(Client) == CLIENT_USER &&
            current_count >= MAX_HNDL_CHANNEL_LISTS)
-               return IRC_WriteStrClient(Client, ERR_LISTFULL_MSG,
+               return IRC_WriteErrClient(Client, ERR_LISTFULL_MSG,
                                          Client_ID(Client),
                                          Channel_Name(Channel), mask,
                                          MAX_HNDL_CHANNEL_LISTS);
@@ -1031,9 +1026,8 @@ Add_To_List(char what, CLIENT *Prefix, CLIENT *Client, CHANNEL *Channel,
        return Send_ListChange(true, what, Prefix, Client, Channel, mask);
 }
 
-
 /**
- * Delete entries from channel invite, ban and exeption lists.
+ * Delete entries from channel invite, ban and exception lists.
  *
  * @param what Can be 'I' for invite, 'b' for ban, and 'e' for exception list.
  * @param Prefix The originator of the command.
@@ -1046,7 +1040,7 @@ static bool
 Del_From_List(char what, CLIENT *Prefix, CLIENT *Client, CHANNEL *Channel,
              const char *Pattern)
 {
-       const char *mask;
+       char mask[MASK_LEN];
        struct list_head *list = NULL;
 
        assert(Client != NULL);
@@ -1054,7 +1048,7 @@ Del_From_List(char what, CLIENT *Prefix, CLIENT *Client, CHANNEL *Channel,
        assert(Pattern != NULL);
        assert(what == 'I' || what == 'b' || what == 'e');
 
-       mask = Lists_MakeMask(Pattern);
+       Lists_MakeMask(Pattern, mask, sizeof(mask));
 
        switch (what) {
                case 'I':
@@ -1075,7 +1069,6 @@ Del_From_List(char what, CLIENT *Prefix, CLIENT *Client, CHANNEL *Channel,
        return Send_ListChange(false, what, Prefix, Client, Channel, mask);
 }
 
-
 /**
  * Send information about changed channel invite/ban/exception lists to clients.
  *
@@ -1113,5 +1106,4 @@ Send_ListChange(const bool IsAdd, const char ModeChar, CLIENT *Prefix,
        return ok;
 } /* Send_ListChange */
 
-
 /* -eof- */