]> arthur.barton.de Git - ngircd-alex.git/blobdiff - src/ngircd/irc-channel.c
When sending an error use the IRC_WriteErrClient() variant
[ngircd-alex.git] / src / ngircd / irc-channel.c
index f9d2dc125d3708b11ad629ed9551b7f08f4b2598..0421d9170201b9d7d81f26d6b61feea4ee584c2d 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * ngIRCd -- The Next Generation IRC Daemon
- * Copyright (c)2001-2010 Alexander Barton (alex@barton.de)
+ * Copyright (c)2001-2013 Alexander Barton (alex@barton.de) and Contributors.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
 #include "parse.h"
 #include "irc.h"
 #include "irc-info.h"
+#include "irc-macros.h"
 #include "irc-write.h"
 #include "conf.h"
 
 #include "exp.h"
 #include "irc-channel.h"
 
-
 /**
  * Part from all channels.
  *
@@ -67,7 +67,6 @@ part_from_all_channels(CLIENT* client, CLIENT *target)
        return CONNECTED;
 } /* part_from_all_channels */
 
-
 /**
  * Check weather a local client is allowed to join an already existing
  * channel or not.
@@ -83,10 +82,9 @@ join_allowed(CLIENT *Client, CHANNEL *chan, const char *channame,
             const char *key)
 {
        bool is_invited, is_banned, is_exception;
-       const char *channel_modes;
 
        /* Allow IRC operators to overwrite channel limits */
-       if (strchr(Client_Modes(Client), 'o'))
+       if (Client_HasMode(Client, 'o'))
                return true;
 
        is_banned = Lists_Check(Channel_GetListBans(chan), Client);
@@ -95,15 +93,14 @@ join_allowed(CLIENT *Client, CHANNEL *chan, const char *channame,
 
        if (is_banned && !is_invited && !is_exception) {
                /* Client is banned from channel (and not on invite list) */
-               IRC_WriteStrClient(Client, ERR_BANNEDFROMCHAN_MSG,
+               IRC_WriteErrClient(Client, ERR_BANNEDFROMCHAN_MSG,
                                   Client_ID(Client), channame);
                return false;
        }
 
-       channel_modes = Channel_Modes(chan);
-       if (strchr(channel_modes, 'i') && !is_invited) {
+       if (Channel_HasMode(chan, 'i') && !is_invited) {
                /* Channel is "invite-only" and client is not on invite list */
-               IRC_WriteStrClient(Client, ERR_INVITEONLYCHAN_MSG,
+               IRC_WriteErrClient(Client, ERR_INVITEONLYCHAN_MSG,
                                   Client_ID(Client), channame);
                return false;
        }
@@ -111,37 +108,37 @@ join_allowed(CLIENT *Client, CHANNEL *chan, const char *channame,
        if (!Channel_CheckKey(chan, Client, key ? key : "")) {
                /* Channel is protected by a channel key and the client
                 * didn't specify the correct one */
-               IRC_WriteStrClient(Client, ERR_BADCHANNELKEY_MSG,
+               IRC_WriteErrClient(Client, ERR_BADCHANNELKEY_MSG,
                                   Client_ID(Client), channame);
                return false;
        }
 
-       if (strchr(channel_modes, 'l') &&
+       if (Channel_HasMode(chan, 'l') &&
            (Channel_MaxUsers(chan) <= Channel_MemberCount(chan))) {
                /* There are more clints joined to this channel than allowed */
-               IRC_WriteStrClient(Client, ERR_CHANNELISFULL_MSG,
+               IRC_WriteErrClient(Client, ERR_CHANNELISFULL_MSG,
                                   Client_ID(Client), channame);
                return false;
        }
 
-       if (strchr(channel_modes, 'z') && !Conn_UsesSSL(Client_Conn(Client))) {
+       if (Channel_HasMode(chan, 'z') && !Conn_UsesSSL(Client_Conn(Client))) {
                /* Only "secure" clients are allowed, but clients doesn't
                 * use SSL encryption */
-               IRC_WriteStrClient(Client, ERR_SECURECHANNEL_MSG,
+               IRC_WriteErrClient(Client, ERR_SECURECHANNEL_MSG,
                                   Client_ID(Client), channame);
                return false;
        }
 
-       if (strchr(channel_modes, 'O') && !Client_OperByMe(Client)) {
+       if (Channel_HasMode(chan, 'O') && !Client_HasMode(Client, 'o')) {
                /* Only IRC operators are allowed! */
-               IRC_WriteStrClient(Client, ERR_OPONLYCHANNEL_MSG,
+               IRC_WriteErrClient(Client, ERR_OPONLYCHANNEL_MSG,
                                   Client_ID(Client), channame);
                return false;
        }
 
-       if (strchr(channel_modes, 'R') && !strchr(Client_Modes(Client), 'R')) {
+       if (Channel_HasMode(chan, 'R') && !Client_HasMode(Client, 'R')) {
                /* Only registered users are allowed! */
-               IRC_WriteStrClient(Client, ERR_REGONLYCHANNEL_MSG,
+               IRC_WriteErrClient(Client, ERR_REGONLYCHANNEL_MSG,
                                   Client_ID(Client), channame);
                return false;
        }
@@ -149,7 +146,6 @@ join_allowed(CLIENT *Client, CHANNEL *chan, const char *channame,
        return true;
 } /* join_allowed */
 
-
 /**
  * Set user channel modes.
  *
@@ -169,16 +165,15 @@ join_set_channelmodes(CHANNEL *chan, CLIENT *target, const char *flags)
 
        /* If the channel is persistent (+P) and client is an IRC op:
         * make client chanop, if not disabled in configuration. */
-       if (strchr(Channel_Modes(chan), 'P') && Conf_OperChanPAutoOp
-           && strchr(Client_Modes(target), 'o'))
+       if (Channel_HasMode(chan, 'P') && Conf_OperChanPAutoOp
+           && Client_HasMode(target, 'o'))
                Channel_UserModeAdd(chan, target, 'o');
 } /* join_set_channelmodes */
 
-
 /**
  * Forward JOIN command to a specific server
  *
- * This function diffentiates between servers using RFC 2813 mode that
+ * This function differentiates between servers using RFC 2813 mode that
  * support the JOIN command with appended ASCII 7 character and channel
  * modes, and servers using RFC 1459 protocol which require separate JOIN
  * and MODE commands.
@@ -211,7 +206,6 @@ cb_join_forward(CLIENT *To, CLIENT *Prefix, void *Data)
                                         Client_ID(Prefix));
 } /* cb_join_forward */
 
-
 /**
  * Forward JOIN command to all servers
  *
@@ -256,9 +250,8 @@ join_forward(CLIENT *Client, CLIENT *target, CHANNEL *chan,
        }
 } /* join_forward */
 
-
 /**
- * Aknowledge user JOIN request and send "channel info" numerics.
+ * Acknowledge user JOIN request and send "channel info" numerics.
  *
  * @param Client       Client used to prefix the genrated commands
  * @param target       Forward commands/numerics to this user
@@ -299,15 +292,12 @@ join_send_topic(CLIENT *Client, CLIENT *target, CHANNEL *chan,
                                  Channel_Name(chan));
 } /* join_send_topic */
 
-
 /**
  * Handler for the IRC "JOIN" command.
  *
- * See RFC 2812, 3.2.1 "Join message"; RFC 2813, 4.2.1 "Join message".
- *
- * @param Client The client from which this command has been received
- * @param Req Request structure with prefix and all parameters
- * @returns CONNECTED or DISCONNECTED
+ * @param Client The client from which this command has been received.
+ * @param Req Request structure with prefix and all parameters.
+ * @return CONNECTED or DISCONNECTED.
  */
 GLOBAL bool
 IRC_JOIN( CLIENT *Client, REQUEST *Req )
@@ -319,20 +309,7 @@ IRC_JOIN( CLIENT *Client, REQUEST *Req )
        assert (Client != NULL);
        assert (Req != NULL);
 
-       /* Bad number of arguments? */
-       if (Req->argc < 1 || Req->argc > 2)
-               return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
-                                         Client_ID(Client), Req->command);
-
-       /* Who is the sender? */
-       if (Client_Type(Client) == CLIENT_SERVER)
-               target = Client_Search(Req->prefix);
-       else
-               target = Client;
-
-       if (!target)
-               return IRC_WriteStrClient(Client, ERR_NOSUCHNICK_MSG,
-                                         Client_ID(Client), Req->prefix);
+       _IRC_GET_SENDER_OR_RETURN_(target, Req, Client)
 
        /* Is argument "0"? */
        if (Req->argc == 1 && !strncmp("0", Req->argv[0], 2))
@@ -346,8 +323,8 @@ IRC_JOIN( CLIENT *Client, REQUEST *Req )
        channame = strtok_r(channame, ",", &lastchan);
 
        /* Make sure that "channame" is not the empty string ("JOIN :") */
-       if (! channame)
-               return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
+       if (!channame)
+               return IRC_WriteErrClient(Client, ERR_NEEDMOREPARAMS_MSG,
                                          Client_ID(Client), Req->command);
 
        while (channame) {
@@ -363,12 +340,6 @@ IRC_JOIN( CLIENT *Client, REQUEST *Req )
                }
 
                chan = Channel_Search(channame);
-               if (!chan && Conf_PredefChannelsOnly) {
-                        /* channel must be created, but forbidden by config */
-                       IRC_WriteStrClient(Client, ERR_BANNEDFROMCHAN_MSG,
-                                          Client_ID(Client), channame);
-                       goto join_next;
-               }
 
                /* Local client? */
                if (Client_Type(Client) == CLIENT_USER) {
@@ -376,12 +347,21 @@ IRC_JOIN( CLIENT *Client, REQUEST *Req )
                                /* Already existing channel: already member? */
                                if (Channel_IsMemberOf(chan, Client))
                                    goto join_next;
+                       } else {
+                               /* Channel must be created */
+                               if (!strchr(Conf_AllowedChannelTypes, channame[0])) {
+                                       /* ... but channel type is not allowed! */
+                                       IRC_WriteErrClient(Client,
+                                               ERR_NOSUCHCHANNEL_MSG,
+                                               Client_ID(Client), channame);
+                                       goto join_next;
+                               }
                        }
 
                        /* Test if the user has reached the channel limit */
                        if ((Conf_MaxJoins > 0) &&
                            (Channel_CountForUser(Client) >= Conf_MaxJoins)) {
-                               if (!IRC_WriteStrClient(Client,
+                               if (!IRC_WriteErrClient(Client,
                                                ERR_TOOMANYCHANNELS_MSG,
                                                Client_ID(Client), channame))
                                        return DISCONNECTED;
@@ -443,15 +423,12 @@ IRC_JOIN( CLIENT *Client, REQUEST *Req )
        return CONNECTED;
 } /* IRC_JOIN */
 
-
 /**
  * Handler for the IRC "PART" command.
  *
- * See RFC 2812, 3.2.2: "Part message".
- *
- * @param Client       The client from which this command has been received
- * @param Req          Request structure with prefix and all parameters
- * @returns            CONNECTED or DISCONNECTED
+ * @param Client The client from which this command has been received.
+ * @param Req Request structure with prefix and all parameters.
+ * @return CONNECTED or DISCONNECTED.
  */
 GLOBAL bool
 IRC_PART(CLIENT * Client, REQUEST * Req)
@@ -462,25 +439,14 @@ IRC_PART(CLIENT * Client, REQUEST * Req)
        assert(Client != NULL);
        assert(Req != NULL);
 
-       if (Req->argc < 1 || Req->argc > 2)
-               return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
-                                         Client_ID(Client), Req->command);
-
-       /* Get the sender */
-       if (Client_Type(Client) == CLIENT_SERVER)
-               target = Client_Search(Req->prefix);
-       else
-               target = Client;
-       if (!target)
-               return IRC_WriteStrClient(Client, ERR_NOSUCHNICK_MSG,
-                                         Client_ID(Client), Req->prefix);
+       _IRC_GET_SENDER_OR_RETURN_(target, Req, Client)
 
        /* Loop over all the given channel names */
        chan = strtok(Req->argv[0], ",");
 
        /* Make sure that "chan" is not the empty string ("PART :") */
-       if (! chan)
-               return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
+       if (!chan)
+               return IRC_WriteErrClient(Client, ERR_NEEDMOREPARAMS_MSG,
                                          Client_ID(Client), Req->command);
 
        while (chan) {
@@ -496,15 +462,12 @@ IRC_PART(CLIENT * Client, REQUEST * Req)
        return CONNECTED;
 } /* IRC_PART */
 
-
 /**
  * Handler for the IRC "TOPIC" command.
  *
- * See RFC 2812, 3.2.4 "Topic message".
- *
- * @param Client       The client from which this command has been received
- * @param Req          Request structure with prefix and all parameters
- * @returns            CONNECTED or DISCONNECTED
+ * @param Client The client from which this command has been received.
+ * @param Req Request structure with prefix and all parameters.
+ * @return CONNECTED or DISCONNECTED.
  */
 GLOBAL bool
 IRC_TOPIC( CLIENT *Client, REQUEST *Req )
@@ -517,32 +480,23 @@ IRC_TOPIC( CLIENT *Client, REQUEST *Req )
        assert( Client != NULL );
        assert( Req != NULL );
 
-       if (Req->argc < 1 || Req->argc > 2)
-               return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
-                                         Client_ID(Client), Req->command);
+       IRC_SetPenalty(Client, 1);
 
-       if (Client_Type(Client) == CLIENT_SERVER)
-               from = Client_Search(Req->prefix);
-       else
-               from = Client;
-
-       if (!from)
-               return IRC_WriteStrClient(Client, ERR_NOSUCHNICK_MSG,
-                                         Client_ID(Client), Req->prefix);
+       _IRC_GET_SENDER_OR_RETURN_(from, Req, Client)
 
        chan = Channel_Search(Req->argv[0]);
        if (!chan)
-               return IRC_WriteStrClient(from, ERR_NOSUCHCHANNEL_MSG,
+               return IRC_WriteErrClient(from, ERR_NOSUCHCHANNEL_MSG,
                                          Client_ID(from), Req->argv[0]);
 
        /* Only remote servers and channel members are allowed to change the
-        * channel topic, and IRC opreators when the Conf_OperCanMode option
+        * channel topic, and IRC operators when the Conf_OperCanMode option
         * is set in the server configuration. */
        if (Client_Type(Client) != CLIENT_SERVER) {
                topic_power = Client_HasMode(from, 'o');
                if (!Channel_IsMemberOf(chan, from)
                    && !(Conf_OperCanMode && topic_power))
-                       return IRC_WriteStrClient(from, ERR_NOTONCHANNEL_MSG,
+                       return IRC_WriteErrClient(from, ERR_NOTONCHANNEL_MSG,
                                                  Client_ID(from), Req->argv[0]);
        } else
                topic_power = true;
@@ -571,14 +525,14 @@ IRC_TOPIC( CLIENT *Client, REQUEST *Req )
                                                  Channel_Name(chan));
        }
 
-       if (strchr(Channel_Modes(chan), 't')) {
+       if (Channel_HasMode(chan, 't')) {
                /* Topic Lock. Is the user a channel op or IRC operator? */
                if(!topic_power &&
-                  !strchr(Channel_UserModes(chan, from), 'h') &&
-                  !strchr(Channel_UserModes(chan, from), 'o') &&
-                  !strchr(Channel_UserModes(chan, from), 'a') &&
-                  !strchr(Channel_UserModes(chan, from), 'q'))
-                       return IRC_WriteStrClient(from, ERR_CHANOPRIVSNEEDED_MSG,
+                  !Channel_UserHasMode(chan, from, 'h') &&
+                  !Channel_UserHasMode(chan, from, 'o') &&
+                  !Channel_UserHasMode(chan, from, 'a') &&
+                  !Channel_UserHasMode(chan, from, 'q'))
+                       return IRC_WriteErrClient(from, ERR_CHANOPRIVSNEEDED_MSG,
                                                  Client_ID(from),
                                                  Channel_Name(chan));
        }
@@ -606,15 +560,9 @@ IRC_TOPIC( CLIENT *Client, REQUEST *Req )
                return CONNECTED;
 } /* IRC_TOPIC */
 
-
 /**
  * Handler for the IRC "LIST" command.
  *
- * See RFC 2812, 3.2.6 "List message".
- *
- * This implementation handles the local case as well as the forwarding of the
- * LIST command to other servers in the IRC network.
- *
  * @param Client The client from which this command has been received.
  * @param Req Request structure with prefix and all parameters.
  * @return CONNECTED or DISCONNECTED.
@@ -630,31 +578,20 @@ IRC_LIST( CLIENT *Client, REQUEST *Req )
        assert(Client != NULL);
        assert(Req != NULL);
 
-       /* Bad number of prameters? */
-       if (Req->argc > 2)
-               return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
-                                         Client_ID(Client), Req->command);
+       IRC_SetPenalty(Client, 2);
+
+       _IRC_GET_SENDER_OR_RETURN_(from, Req, Client)
 
        if (Req->argc > 0)
                pattern = strtok(Req->argv[0], ",");
        else
                pattern = "*";
 
-       /* Get sender from prefix, if any */
-       if (Client_Type(Client) == CLIENT_SERVER)
-               from = Client_Search(Req->prefix);
-       else
-               from = Client;
-
-       if (!from)
-               return IRC_WriteStrClient(Client, ERR_NOSUCHSERVER_MSG,
-                                         Client_ID(Client), Req->prefix);
-
        if (Req->argc == 2) {
                /* Forward to other server? */
                target = Client_Search(Req->argv[1]);
                if (! target || Client_Type(target) != CLIENT_SERVER)
-                       return IRC_WriteStrClient(from, ERR_NOSUCHSERVER_MSG,
+                       return IRC_WriteErrClient(from, ERR_NOSUCHSERVER_MSG,
                                                  Client_ID(Client),
                                                  Req->argv[1]);
 
@@ -676,12 +613,16 @@ IRC_LIST( CLIENT *Client, REQUEST *Req )
                        /* Check search pattern */
                        if (MatchCaseInsensitive(pattern, Channel_Name(chan))) {
                                /* Gotcha! */
-                               if (!strchr(Channel_Modes(chan), 's')
+                               if (!Channel_HasMode(chan, 's')
                                    || Channel_IsMemberOf(chan, from)
-                                   || (!Conf_MorePrivacy && Client_OperByMe(Client))) {
-                                       if (IRC_CheckListTooBig(from, count,
-                                                                MAX_RPL_LIST,
-                                                                "LIST"))
+                                   || (!Conf_MorePrivacy
+                                       && Client_HasMode(Client, 'o')
+                                       && Client_Conn(Client) > NONE))
+                               {
+                                       if ((Conf_MaxListSize > 0)
+                                           && IRC_CheckListTooBig(from, count,
+                                                                  Conf_MaxListSize,
+                                                                  "LIST"))
                                                break;
                                        if (!IRC_WriteStrClient(from,
                                             RPL_LIST_MSG, Client_ID(from),
@@ -702,25 +643,20 @@ IRC_LIST( CLIENT *Client, REQUEST *Req )
                        pattern = NULL;
        }
 
-       IRC_SetPenalty(from, 2);
        return IRC_WriteStrClient(from, RPL_LISTEND_MSG, Client_ID(from));
 } /* IRC_LIST */
 
-
 /**
- * Handler for the IRC+ command "CHANINFO".
+ * Handler for the IRC+ "CHANINFO" command.
  *
- * See doc/Protocol.txt, section II.3:
- * "Exchange channel-modes, topics, and persistent channels".
- *
- * @param Client       The client from which this command has been received
- * @param Req          Request structure with prefix and all parameters
- * @returns            CONNECTED or DISCONNECTED
+ * @param Client The client from which this command has been received.
+ * @param Req Request structure with prefix and all parameters.
+ * @return CONNECTED or DISCONNECTED.
  */
 GLOBAL bool
 IRC_CHANINFO( CLIENT *Client, REQUEST *Req )
 {
-       char modes_add[COMMAND_LEN], l[16], *ptr;
+       char modes_add[COMMAND_LEN], l[16];
        CLIENT *from;
        CHANNEL *chan;
        int arg_topic;
@@ -730,72 +666,67 @@ IRC_CHANINFO( CLIENT *Client, REQUEST *Req )
 
        /* Bad number of parameters? */
        if (Req->argc < 2 || Req->argc == 4 || Req->argc > 5)
-               return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
+               return IRC_WriteErrClient(Client, ERR_NEEDMOREPARAMS_MSG,
                                          Client_ID(Client), Req->command);
 
        /* Compatibility kludge */
-       if( Req->argc == 5 ) arg_topic = 4;
-       else if( Req->argc == 3 ) arg_topic = 2;
-       else arg_topic = -1;
+       if (Req->argc == 5)
+               arg_topic = 4;
+       else if(Req->argc == 3)
+               arg_topic = 2;
+       else
+               arg_topic = -1;
 
-       /* Search origin */
-       from = Client_Search( Req->prefix );
-       if( ! from ) return IRC_WriteStrClient( Client, ERR_NOSUCHNICK_MSG, Client_ID( Client ), Req->prefix );
+       _IRC_GET_SENDER_OR_RETURN_(from, Req, Client)
 
        /* Search or create channel */
        chan = Channel_Search( Req->argv[0] );
-       if( ! chan ) chan = Channel_Create( Req->argv[0] );
-       if( ! chan ) return CONNECTED;
-
-       if( Req->argv[1][0] == '+' )
-       {
-               ptr = Channel_Modes( chan );
-               if( ! *ptr )
-               {
-                       /* OK, this channel doesn't have modes jet, set the received ones: */
-                       Channel_SetModes( chan, &Req->argv[1][1] );
-
-                       if( Req->argc == 5 )
-                       {
-                               if( strchr( Channel_Modes( chan ), 'k' )) Channel_SetKey( chan, Req->argv[2] );
-                               if( strchr( Channel_Modes( chan ), 'l' )) Channel_SetMaxUsers( chan, atol( Req->argv[3] ));
-                       }
-                       else
-                       {
+       if (!chan)
+               chan = Channel_Create( Req->argv[0] );
+       if (!chan)
+               return CONNECTED;
+
+       if (Req->argv[1][0] == '+') {
+               if (!*Channel_Modes(chan)) {
+                       /* OK, this channel doesn't have modes yet,
+                        * set the received ones: */
+                       Channel_SetModes(chan, &Req->argv[1][1]);
+
+                       if(Req->argc == 5) {
+                               if(Channel_HasMode(chan, 'k'))
+                                       Channel_SetKey(chan, Req->argv[2]);
+                               if(Channel_HasMode(chan, 'l'))
+                                       Channel_SetMaxUsers(chan, atol(Req->argv[3]));
+                       } else {
                                /* Delete modes which we never want to inherit */
-                               Channel_ModeDel( chan, 'l' );
-                               Channel_ModeDel( chan, 'k' );
+                               Channel_ModeDel(chan, 'l');
+                               Channel_ModeDel(chan, 'k');
                        }
 
-                       strcpy( modes_add, "" );
-                       ptr = Channel_Modes( chan );
-                       while( *ptr )
-                       {
-                               if( *ptr == 'l' )
-                               {
-                                       snprintf( l, sizeof( l ), " %lu", Channel_MaxUsers( chan ));
-                                       strlcat( modes_add, l, sizeof( modes_add ));
-                               }
-                               if( *ptr == 'k' )
-                               {
-                                       strlcat( modes_add, " ", sizeof( modes_add ));
-                                       strlcat( modes_add, Channel_Key( chan ), sizeof( modes_add ));
-                               }
-                               ptr++;
+                       strcpy(modes_add, "");
+                       if (Channel_HasMode(chan, 'l'))  {
+                               snprintf(l, sizeof(l), " %lu",
+                                        Channel_MaxUsers(chan));
+                               strlcat(modes_add, l, sizeof(modes_add));
+                       }
+                       if (Channel_HasMode(chan, 'k'))  {
+                               strlcat(modes_add, " ", sizeof(modes_add));
+                               strlcat(modes_add, Channel_Key(chan),
+                                       sizeof(modes_add));
                        }
 
                        /* Inform members of this channel */
-                       IRC_WriteStrChannelPrefix( Client, chan, from, false, "MODE %s +%s%s", Req->argv[0], Channel_Modes( chan ), modes_add );
+                       IRC_WriteStrChannelPrefix(Client, chan, from, false,
+                                                 "MODE %s +%s%s", Req->argv[0],
+                                                 Channel_Modes(chan), modes_add);
                }
        }
-       else Log( LOG_WARNING, "CHANINFO: invalid MODE format ignored!" );
+       else
+               Log(LOG_WARNING, "CHANINFO: invalid MODE format ignored!");
 
-       if( arg_topic > 0 )
-       {
+       if (arg_topic > 0) {
                /* We got a topic */
-               ptr = Channel_Topic( chan );
-               if(( ! *ptr ) && ( Req->argv[arg_topic][0] ))
-               {
+               if (!*Channel_Topic(chan) && Req->argv[arg_topic][0]) {
                        /* OK, there is no topic jet */
                        Channel_SetTopic(chan, Client, Req->argv[arg_topic]);
                        IRC_WriteStrChannelPrefix(Client, chan, from, false,
@@ -803,13 +734,24 @@ IRC_CHANINFO( CLIENT *Client, REQUEST *Req )
                }
        }
 
-       /* Forward CHANINFO to other serevrs */
-       if( Req->argc == 5 ) IRC_WriteStrServersPrefixFlag( Client, from, 'C', "CHANINFO %s %s %s %s :%s", Req->argv[0], Req->argv[1], Req->argv[2], Req->argv[3], Req->argv[4] );
-       else if( Req->argc == 3 ) IRC_WriteStrServersPrefixFlag( Client, from, 'C', "CHANINFO %s %s :%s", Req->argv[0], Req->argv[1], Req->argv[2] );
-       else IRC_WriteStrServersPrefixFlag( Client, from, 'C', "CHANINFO %s %s", Req->argv[0], Req->argv[1] );
+       /* Forward CHANINFO to other servers */
+       if (Req->argc == 5)
+               IRC_WriteStrServersPrefixFlag(Client, from, 'C',
+                                             "CHANINFO %s %s %s %s :%s",
+                                             Req->argv[0], Req->argv[1],
+                                             Req->argv[2], Req->argv[3],
+                                             Req->argv[4]);
+       else if (Req->argc == 3)
+               IRC_WriteStrServersPrefixFlag(Client, from, 'C',
+                                             "CHANINFO %s %s :%s",
+                                             Req->argv[0], Req->argv[1],
+                                             Req->argv[2]);
+       else
+               IRC_WriteStrServersPrefixFlag(Client, from, 'C',
+                                             "CHANINFO %s %s",
+                                             Req->argv[0], Req->argv[1]);
 
        return CONNECTED;
 } /* IRC_CHANINFO */
 
-
 /* -eof- */