]> arthur.barton.de Git - ngircd-alex.git/blobdiff - src/ngircd/conf.c
Initialize Conf_ScrubCTCP even when SYSLOG isn't #define'd
[ngircd-alex.git] / src / ngircd / conf.c
index b10f4905c9ec7befb08b5b5717cc6397cc48bea9..6692ecbbdd8b5f8bb21f981fec5981acfb21e3a9 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * ngIRCd -- The Next Generation IRC Daemon
- * Copyright (c)2001-2013 Alexander Barton (alex@barton.de) and Contributors.
+ * Copyright (c)2001-2014 Alexander Barton (alex@barton.de) and Contributors.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -16,9 +16,7 @@
  * Configuration management (reading, parsing & validation)
  */
 
-#include "imp.h"
 #include <assert.h>
-#include <ctype.h>
 #include <errno.h>
 #ifdef PROTOTYPES
 #      include <stdarg.h>
 #include <stdlib.h>
 #include <string.h>
 #include <strings.h>
+#include <time.h>
 #include <unistd.h>
 #include <pwd.h>
 #include <grp.h>
 #include <sys/types.h>
-#include <unistd.h>
 #include <dirent.h>
 
-#include "array.h"
 #include "ngircd.h"
 #include "conn.h"
 #include "channel.h"
-#include "defines.h"
 #include "log.h"
 #include "match.h"
-#include "tool.h"
 
-#include "exp.h"
 #include "conf.h"
 
 
@@ -93,6 +87,12 @@ static void Init_Server_Struct PARAMS(( CONF_SERVER *Server ));
 #define DEFAULT_LISTEN_ADDRSTR "0.0.0.0"
 #endif
 
+#ifdef HAVE_LIBSSL
+#define DEFAULT_CIPHERS                "HIGH:!aNULL:@STRENGTH"
+#endif
+#ifdef HAVE_LIBGNUTLS
+#define DEFAULT_CIPHERS                "SECURE128"
+#endif
 
 #ifdef SSL_SUPPORT
 
@@ -117,6 +117,9 @@ ConfSSL_Init(void)
        array_free_wipe(&Conf_SSLOptions.KeyFilePassword);
 
        array_free(&Conf_SSLOptions.ListenPorts);
+
+       free(Conf_SSLOptions.CipherList);
+       Conf_SSLOptions.CipherList = NULL;
 }
 
 /**
@@ -207,7 +210,7 @@ ports_puts(array *a)
  * Parse a comma separated string into an array of port numbers (integers).
  */
 static void
-ports_parse(array *a, int Line, char *Arg)
+ports_parse(array *a, const char *File, int Line, char *Arg)
 {
        char *ptr;
        int port;
@@ -223,10 +226,10 @@ ports_parse(array *a, int Line, char *Arg)
                        port16 = (UINT16) port;
                        if (!array_catb(a, (char*)&port16, sizeof port16))
                                Config_Error(LOG_ERR, "%s, line %d Could not add port number %ld: %s",
-                                                       NGIRCd_ConfFile, Line, port, strerror(errno));
+                                            File, Line, port, strerror(errno));
                } else {
                        Config_Error( LOG_ERR, "%s, line %d (section \"Global\"): Illegal port number %ld!",
-                                                                       NGIRCd_ConfFile, Line, port );
+                                    File, Line, port );
                }
 
                ptr = strtok( NULL, "," );
@@ -360,9 +363,9 @@ Conf_Test( void )
                printf("  MotdPhrase = %s\n", array_bytes(&Conf_Motd)
                       ? (const char*) array_start(&Conf_Motd) : "");
        }
-#ifndef PAM
-       printf("  Password = %s\n", Conf_ServerPwd);
-#endif
+       printf("  Network = %s\n", Conf_Network);
+       if (!Conf_PAM) 
+               printf("  Password = %s\n", Conf_ServerPwd);
        printf("  PidFile = %s\n", Conf_PidFile);
        printf("  Ports = ");
        ports_puts(&Conf_ListenPorts);
@@ -432,6 +435,8 @@ Conf_Test( void )
        puts("[SSL]");
        printf("  CertFile = %s\n", Conf_SSLOptions.CertFile
                                        ? Conf_SSLOptions.CertFile : "");
+       printf("  CipherList = %s\n", Conf_SSLOptions.CipherList ?
+              Conf_SSLOptions.CipherList : DEFAULT_CIPHERS);
        printf("  DHFile = %s\n", Conf_SSLOptions.DHFile
                                        ? Conf_SSLOptions.DHFile : "");
        printf("  KeyFile = %s\n", Conf_SSLOptions.KeyFile
@@ -522,7 +527,11 @@ Conf_UnsetServer( CONN_ID Idx )
                                /* "Short" connection, enforce "ConnectRetry"
                                 * but randomize it a little bit: 15 seconds. */
                                Conf_Server[i].lasttry =
+#ifdef HAVE_ARC4RANDOM
+                                       t + (arc4random() % 15);
+#else
                                        t + rand() / (RAND_MAX / 15);
+#endif
                        }
                }
        }
@@ -734,6 +743,7 @@ Set_Defaults(bool InitServers)
        strcpy(Conf_ServerAdminMail, "");
        snprintf(Conf_ServerInfo, sizeof Conf_ServerInfo, "%s %s",
                 PACKAGE_NAME, PACKAGE_VERSION);
+       strcpy(Conf_Network, "");
        free(Conf_ListenAddress);
        Conf_ListenAddress = NULL;
        array_free(&Conf_ListenPorts);
@@ -796,8 +806,8 @@ Set_Defaults(bool InitServers)
        Conf_PAM = false;
 #endif
        Conf_PAMIsOptional = false;
-#ifdef SYSLOG
        Conf_ScrubCTCP = false;
+#ifdef SYSLOG
 #ifdef LOG_LOCAL5
        Conf_SyslogFacility = LOG_LOCAL5;
 #else
@@ -1027,15 +1037,23 @@ Read_Config(bool TestOnly, bool IsStarting)
        CheckFileReadable("CertFile", Conf_SSLOptions.CertFile);
        CheckFileReadable("DHFile", Conf_SSLOptions.DHFile);
        CheckFileReadable("KeyFile", Conf_SSLOptions.KeyFile);
+
+       /* Set the default ciphers if none were configured */
+       if (!Conf_SSLOptions.CipherList)
+               Conf_SSLOptions.CipherList = strdup_warn(DEFAULT_CIPHERS);
 #endif
 
        return true;
 }
 
 /**
- * ...
+ * Read in and handle a configuration file.
+ *
+ * @param File Name of the configuration file.
+ * @param fd File descriptor already opened for reading.
  */
-static void Read_Config_File(const char *File, FILE *fd)
+static void
+Read_Config_File(const char *File, FILE *fd)
 {
        char section[LINE_LEN], str[LINE_LEN], *var, *arg, *ptr;
        int i, line = 0;
@@ -1044,7 +1062,7 @@ static void Read_Config_File(const char *File, FILE *fd)
        /* Read configuration file */
        section[0] = '\0';
        while (true) {
-               if (!fgets(str, LINE_LEN, fd))
+               if (!fgets(str, sizeof(str), fd))
                        break;
                ngt_TrimStr(str);
                line++;
@@ -1053,6 +1071,12 @@ static void Read_Config_File(const char *File, FILE *fd)
                if (str[0] == ';' || str[0] == '#' || str[0] == '\0')
                        continue;
 
+               if (strlen(str) >= sizeof(str) - 1) {
+                       Config_Error(LOG_WARNING, "%s, line %d too long!",
+                                    File, line);
+                       continue;
+               }
+
                /* Is this the beginning of a new section? */
                if ((str[0] == '[') && (str[strlen(str) - 1] == ']')) {
                        strlcpy(section, str, sizeof(section));
@@ -1122,7 +1146,7 @@ static void Read_Config_File(const char *File, FILE *fd)
 
                        Config_Error(LOG_ERR,
                                     "%s, line %d: Unknown section \"%s\"!",
-                                    NGIRCd_ConfFile, line, section);
+                                    File, line, section);
                        section[0] = 0x1;
                }
                if (section[0] == 0x1)
@@ -1132,7 +1156,7 @@ static void Read_Config_File(const char *File, FILE *fd)
                ptr = strchr(str, '=');
                if (!ptr) {
                        Config_Error(LOG_ERR, "%s, line %d: Syntax error!",
-                                    NGIRCd_ConfFile, line);
+                                    File, line);
                        continue;
                }
                *ptr = '\0';
@@ -1160,7 +1184,7 @@ static void Read_Config_File(const char *File, FILE *fd)
                else
                        Config_Error(LOG_ERR,
                                     "%s, line %d: Variable \"%s\" outside section!",
-                                    NGIRCd_ConfFile, line, var);
+                                    File, line, var);
        }
 }
 
@@ -1192,7 +1216,7 @@ Check_ArgIsTrue(const char *Arg)
  * @returns    New configured maximum nickname length.
  */
 static unsigned int
-Handle_MaxNickLength(int Line, const char *Arg)
+Handle_MaxNickLength(const char *File, int Line, const char *Arg)
 {
        unsigned new;
 
@@ -1200,13 +1224,13 @@ Handle_MaxNickLength(int Line, const char *Arg)
        if (new > CLIENT_NICK_LEN) {
                Config_Error(LOG_WARNING,
                             "%s, line %d: Value of \"MaxNickLength\" exceeds %u!",
-                            NGIRCd_ConfFile, Line, CLIENT_NICK_LEN - 1);
+                            File, Line, CLIENT_NICK_LEN - 1);
                return CLIENT_NICK_LEN;
        }
        if (new < 2) {
                Config_Error(LOG_WARNING,
                             "%s, line %d: Value of \"MaxNickLength\" must be at least 1!",
-                            NGIRCd_ConfFile, Line);
+                            File, Line);
                return 2;
        }
        return new;
@@ -1216,14 +1240,14 @@ Handle_MaxNickLength(int Line, const char *Arg)
  * Output a warning messages if IDENT is configured but not compiled in.
  */
 static void
-WarnIdent(int UNUSED Line)
+WarnIdent(const char UNUSED *File, int UNUSED Line)
 {
 #ifndef IDENTAUTH
        if (Conf_Ident) {
                /* user has enabled ident lookups explicitly, but ... */
                Config_Error(LOG_WARNING,
                        "%s: line %d: \"Ident = yes\", but ngircd was built without IDENT support!",
-                       NGIRCd_ConfFile, Line);
+                       File, Line);
        }
 #endif
 }
@@ -1232,14 +1256,14 @@ WarnIdent(int UNUSED Line)
  * Output a warning messages if IPv6 is configured but not compiled in.
  */
 static void
-WarnIPv6(int UNUSED Line)
+WarnIPv6(const char UNUSED *File, int UNUSED Line)
 {
 #ifndef WANT_IPV6
        if (Conf_ConnectIPv6) {
                /* user has enabled IPv6 explicitly, but ... */
                Config_Error(LOG_WARNING,
                        "%s: line %d: \"ConnectIPv6 = yes\", but ngircd was built without IPv6 support!",
-                       NGIRCd_ConfFile, Line);
+                       File, Line);
        }
 #endif
 }
@@ -1248,13 +1272,13 @@ WarnIPv6(int UNUSED Line)
  * Output a warning messages if PAM is configured but not compiled in.
  */
 static void
-WarnPAM(int UNUSED Line)
+WarnPAM(const char UNUSED *File, int UNUSED Line)
 {
 #ifndef PAM
        if (Conf_PAM) {
                Config_Error(LOG_WARNING,
                        "%s: line %d: \"PAM = yes\", but ngircd was built without PAM support!",
-                       NGIRCd_ConfFile, Line);
+                       File, Line);
        }
 #endif
 }
@@ -1384,6 +1408,7 @@ Handle_GLOBAL(const char *File, int Line, char *Var, char *Arg )
        struct group *grp;
        size_t len;
        const char *section;
+       char *ptr;
 
        assert(File != NULL);
        assert(Line > 0);
@@ -1455,17 +1480,30 @@ Handle_GLOBAL(const char *File, int Line, char *Var, char *Arg )
                len = strlen(Arg);
                if (len == 0)
                        return;
-               if (len >= LINE_LEN) {
+               if (len >= 127) {
                        Config_Error_TooLong(File, Line, Var);
                        return;
                }
                if (!array_copyb(&Conf_Motd, Arg, len + 1))
                        Config_Error(LOG_WARNING,
                                     "%s, line %d: Could not append MotdPhrase: %s",
-                                    NGIRCd_ConfFile, Line, strerror(errno));
+                                    File, Line, strerror(errno));
                Using_MotdFile = false;
                return;
        }
+       if (strcasecmp(Var, "Network") == 0) {
+               len = strlcpy(Conf_Network, Arg, sizeof(Conf_Network));
+               if (len >= sizeof(Conf_Network))
+                       Config_Error_TooLong(File, Line, Var);
+               ptr = strchr(Conf_Network, ' ');
+               if (ptr) {
+                       Config_Error(LOG_WARNING,
+                                    "%s, line %d: \"Network\" can't contain spaces!",
+                                    File, Line);
+                       *ptr = '\0';
+               }
+               return;
+       }
        if(strcasecmp(Var, "Password") == 0) {
                len = strlcpy(Conf_ServerPwd, Arg, sizeof(Conf_ServerPwd));
                if (len >= sizeof(Conf_ServerPwd))
@@ -1479,7 +1517,7 @@ Handle_GLOBAL(const char *File, int Line, char *Var, char *Arg )
                return;
        }
        if (strcasecmp(Var, "Ports") == 0) {
-               ports_parse(&Conf_ListenPorts, Line, Arg);
+               ports_parse(&Conf_ListenPorts, File, Line, Arg);
                return;
        }
        if (strcasecmp(Var, "ServerGID") == 0) {
@@ -1491,7 +1529,7 @@ Handle_GLOBAL(const char *File, int Line, char *Var, char *Arg )
                        if (!Conf_GID && strcmp(Arg, "0"))
                                Config_Error(LOG_WARNING,
                                             "%s, line %d: Value of \"%s\" is not a valid group name or ID!",
-                                            NGIRCd_ConfFile, Line, Var);
+                                            File, Line, Var);
                }
                return;
        }
@@ -1504,7 +1542,7 @@ Handle_GLOBAL(const char *File, int Line, char *Var, char *Arg )
                        if (!Conf_UID && strcmp(Arg, "0"))
                                Config_Error(LOG_WARNING,
                                             "%s, line %d: Value of \"%s\" is not a valid user name or ID!",
-                                            NGIRCd_ConfFile, Line, Var);
+                                            File, Line, Var);
                }
                return;
        }
@@ -1515,11 +1553,11 @@ Handle_GLOBAL(const char *File, int Line, char *Var, char *Arg )
                 * after marking it "deprecated"). */
                Config_Error(LOG_WARNING,
                             "%s, line %d (section \"Global\"): \"No\"-Prefix is deprecated, use \"%s = %s\" in [Options] section!",
-                            NGIRCd_ConfFile, Line, NoNo(Var), InvertArg(Arg));
+                            File, Line, NoNo(Var), InvertArg(Arg));
                if (strcasecmp(Var, "NoIdent") == 0)
-                       WarnIdent(Line);
+                       WarnIdent(File, Line);
                else if (strcasecmp(Var, "NoPam") == 0)
-                       WarnPAM(Line);
+                       WarnPAM(File, Line);
                return;
        }
        if ((section = CheckLegacyGlobalOption(File, Line, Var, Arg))) {
@@ -1529,12 +1567,12 @@ Handle_GLOBAL(const char *File, int Line, char *Var, char *Arg )
                if (strncasecmp(Var, "SSL", 3) == 0) {
                        Config_Error(LOG_WARNING,
                                     "%s, line %d (section \"Global\"): \"%s\" is deprecated here, move it to %s and rename to \"%s\"!",
-                                    NGIRCd_ConfFile, Line, Var, section,
+                                    File, Line, Var, section,
                                     Var + 3);
                } else {
                        Config_Error(LOG_WARNING,
                                     "%s, line %d (section \"Global\"): \"%s\" is deprecated here, move it to %s!",
-                                    NGIRCd_ConfFile, Line, Var, section);
+                                    File, Line, Var, section);
                }
                return;
        }
@@ -1562,7 +1600,7 @@ Handle_LIMITS(const char *File, int Line, char *Var, char *Arg)
                if (Conf_ConnectRetry < 5) {
                        Config_Error(LOG_WARNING,
                                     "%s, line %d: Value of \"ConnectRetry\" too low!",
-                                    NGIRCd_ConfFile, Line);
+                                    File, Line);
                        Conf_ConnectRetry = 5;
                }
                return;
@@ -1592,7 +1630,7 @@ Handle_LIMITS(const char *File, int Line, char *Var, char *Arg)
                return;
        }
        if (strcasecmp(Var, "MaxNickLength") == 0) {
-               Conf_MaxNickLength = Handle_MaxNickLength(Line, Arg);
+               Conf_MaxNickLength = Handle_MaxNickLength(File, Line, Arg);
                return;
        }
        if (strcasecmp(Var, "MaxListSize") == 0) {
@@ -1606,7 +1644,7 @@ Handle_LIMITS(const char *File, int Line, char *Var, char *Arg)
                if (Conf_PingTimeout < 5) {
                        Config_Error(LOG_WARNING,
                                     "%s, line %d: Value of \"PingTimeout\" too low!",
-                                    NGIRCd_ConfFile, Line);
+                                    File, Line);
                        Conf_PingTimeout = 5;
                }
                return;
@@ -1616,7 +1654,7 @@ Handle_LIMITS(const char *File, int Line, char *Var, char *Arg)
                if (Conf_PongTimeout < 5) {
                        Config_Error(LOG_WARNING,
                                     "%s, line %d: Value of \"PongTimeout\" too low!",
-                                    NGIRCd_ConfFile, Line);
+                                    File, Line);
                        Conf_PongTimeout = 5;
                }
                return;
@@ -1701,7 +1739,7 @@ Handle_OPTIONS(const char *File, int Line, char *Var, char *Arg)
        }
        if (strcasecmp(Var, "ConnectIPv6") == 0) {
                Conf_ConnectIPv6 = Check_ArgIsTrue(Arg);
-               WarnIPv6(Line);
+               WarnIPv6(File, Line);
                return;
        }
        if (strcasecmp(Var, "ConnectIPv4") == 0) {
@@ -1738,7 +1776,7 @@ Handle_OPTIONS(const char *File, int Line, char *Var, char *Arg)
        }
        if (strcasecmp(Var, "Ident") == 0) {
                Conf_Ident = Check_ArgIsTrue(Arg);
-               WarnIdent(Line);
+               WarnIdent(File, Line);
                return;
        }
        if (strcasecmp(Var, "IncludeDir") == 0) {
@@ -1775,7 +1813,7 @@ Handle_OPTIONS(const char *File, int Line, char *Var, char *Arg)
        }
        if (strcasecmp(Var, "PAM") == 0) {
                Conf_PAM = Check_ArgIsTrue(Arg);
-               WarnPAM(Line);
+               WarnPAM(File, Line);
                return;
        }
        if (strcasecmp(Var, "PAMIsOptional") == 0 ) {
@@ -1866,7 +1904,12 @@ Handle_SSL(const char *File, int Line, char *Var, char *Arg)
                return;
        }
        if (strcasecmp(Var, "Ports") == 0) {
-               ports_parse(&Conf_SSLOptions.ListenPorts, Line, Arg);
+               ports_parse(&Conf_SSLOptions.ListenPorts, File, Line, Arg);
+               return;
+       }
+       if (strcasecmp(Var, "CipherList") == 0) {
+               assert(Conf_SSLOptions.CipherList == NULL);
+               Conf_SSLOptions.CipherList = strdup_warn(Arg);
                return;
        }
 
@@ -1962,15 +2005,15 @@ Handle_SERVER(const char *File, int Line, char *Var, char *Arg )
                        return;
 
                Config_Error(LOG_ERR, "%s, line %d (section \"Server\"): Can't parse IP address \"%s\"",
-                               NGIRCd_ConfFile, Line, Arg);
+                            File, Line, Arg);
                return;
        }
        if( strcasecmp( Var, "MyPassword" ) == 0 ) {
                /* Password of this server which is sent to the peer */
                if (*Arg == ':') {
                        Config_Error(LOG_ERR,
-                               "%s, line %d (section \"Server\"): MyPassword must not start with ':'!",
-                                                                               NGIRCd_ConfFile, Line);
+                                    "%s, line %d (section \"Server\"): MyPassword must not start with ':'!",
+                                    File, Line);
                }
                len = strlcpy( New_Server.pwd_in, Arg, sizeof( New_Server.pwd_in ));
                if (len >= sizeof( New_Server.pwd_in ))
@@ -1991,8 +2034,8 @@ Handle_SERVER(const char *File, int Line, char *Var, char *Arg )
                        New_Server.port = (UINT16)port;
                else
                        Config_Error(LOG_ERR,
-                               "%s, line %d (section \"Server\"): Illegal port number %ld!",
-                               NGIRCd_ConfFile, Line, port );
+                                    "%s, line %d (section \"Server\"): Illegal port number %ld!",
+                                    File, Line, port );
                return;
        }
 #ifdef SSL_SUPPORT
@@ -2213,7 +2256,7 @@ Validate_Config(bool Configtest, bool Rehash)
        }
 
 #ifdef PAM
-       if (Conf_ServerPwd[0])
+       if (Conf_PAM && Conf_ServerPwd[0])
                Config_Error(LOG_ERR,
                             "This server uses PAM, \"Password\" in [Global] section will be ignored!");
 #endif