]> arthur.barton.de Git - ngircd-alex.git/blobdiff - src/ngircd/conf.c
Move "ClientHost" and "ClientUserNick" to end of [Global] section
[ngircd-alex.git] / src / ngircd / conf.c
index 2b592b16d3ce44931aff3b047198d3c50488234d..12893ad8f86446abaa1574280abefb14be6889a8 100644 (file)
@@ -1,19 +1,21 @@
 /*
  * ngIRCd -- The Next Generation IRC Daemon
- * Copyright (c)2001-2009 Alexander Barton (alex@barton.de)
+ * Copyright (c)2001-2010 Alexander Barton (alex@barton.de)
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
  * Please read the file COPYING, README and AUTHORS for more information.
- *
- * Configuration management (reading, parsing & validation)
  */
 
-
 #include "portab.h"
 
+/**
+ * @file
+ * Configuration management (reading, parsing & validation)
+ */
+
 #include "imp.h"
 #include <assert.h>
 #include <errno.h>
 #include "array.h"
 #include "ngircd.h"
 #include "conn.h"
-#include "client.h"
 #include "channel.h"
 #include "defines.h"
 #include "log.h"
 #include "match.h"
-#include "resolve.h"
 #include "tool.h"
 
 #include "exp.h"
 #include "conf.h"
 
 
-static bool Use_Log = true;
+static bool Use_Log = true, Using_MotdFile = true;
 static CONF_SERVER New_Server;
 static int New_Server_Idx;
 
+static size_t Conf_Oper_Count;
 static size_t Conf_Channel_Count;
+static char Conf_MotdFile[FNAME_LEN];
+
 static void Set_Defaults PARAMS(( bool InitServers ));
 static bool Read_Config PARAMS(( bool ngircd_starting ));
 static bool Validate_Config PARAMS(( bool TestOnly, bool Rehash ));
 
 static void Handle_GLOBAL PARAMS(( int Line, char *Var, char *Arg ));
+static void Handle_FEATURES PARAMS(( int Line, char *Var, char *Arg ));
 static void Handle_OPERATOR PARAMS(( int Line, char *Var, char *Arg ));
 static void Handle_SERVER PARAMS(( int Line, char *Var, char *Arg ));
 static void Handle_CHANNEL PARAMS(( int Line, char *Var, char *Arg ));
@@ -226,6 +230,41 @@ yesno_to_str(int boolean_value)
 }
 
 
+static void
+opers_free(void)
+{
+       struct Conf_Oper *op;
+       size_t len;
+
+       len = array_length(&Conf_Opers, sizeof(*op));
+       op = array_start(&Conf_Opers);
+       while (len--) {
+               free(op->mask);
+               op++;
+       }
+       array_free(&Conf_Opers);
+}
+
+static void
+opers_puts(void)
+{
+       struct Conf_Oper *op;
+       size_t len;
+
+       len = array_length(&Conf_Opers, sizeof(*op));
+       op = array_start(&Conf_Opers);
+       while (len--) {
+               assert(op->name[0]);
+
+               puts("[OPERATOR]");
+               printf("  Name = %s\n", op->name);
+               printf("  Password = %s\n", op->pwd);
+               printf("  Mask = %s\n\n", op->mask ? op->mask : "");
+               op++;
+       }
+}
+
+
 GLOBAL int
 Conf_Test( void )
 {
@@ -255,16 +294,25 @@ Conf_Test( void )
        }
 
        puts( "[GLOBAL]" );
-       printf( "  Name = %s\n", Conf_ServerName );
-       printf( "  Info = %s\n", Conf_ServerInfo );
-       printf( "  Password = %s\n", Conf_ServerPwd );
-       printf( "  AdminInfo1 = %s\n", Conf_ServerAdmin1 );
-       printf( "  AdminInfo2 = %s\n", Conf_ServerAdmin2 );
-       printf( "  AdminEMail = %s\n", Conf_ServerAdminMail );
-       printf( "  MotdFile = %s\n", Conf_MotdFile );
-       printf( "  MotdPhrase = %s\n", Conf_MotdPhrase );
-       printf( "  ChrootDir = %s\n", Conf_Chroot );
-       printf( "  PidFile = %s\n", Conf_PidFile);
+       printf("  Name = %s\n", Conf_ServerName);
+       printf("  Info = %s\n", Conf_ServerInfo);
+#ifndef PAM
+       printf("  Password = %s\n", Conf_ServerPwd);
+#endif
+       printf("  WebircPassword = %s\n", Conf_WebircPwd);
+       printf("  AdminInfo1 = %s\n", Conf_ServerAdmin1);
+       printf("  AdminInfo2 = %s\n", Conf_ServerAdmin2);
+       printf("  AdminEMail = %s\n", Conf_ServerAdminMail);
+       if (Using_MotdFile) {
+               printf("  MotdFile = %s\n", Conf_MotdFile);
+               printf("  MotdPhrase =\n");
+       } else {
+               printf("  MotdFile = \n");
+               printf("  MotdPhrase = %s\n", array_bytes(&Conf_Motd)
+                      ? (const char*) array_start(&Conf_Motd) : "");
+       }
+       printf("  ChrootDir = %s\n", Conf_Chroot);
+       printf("  PidFile = %s\n", Conf_PidFile);
        printf("  Listen = %s\n", Conf_ListenAddress);
        fputs("  Ports = ", stdout);
        ports_puts(&Conf_ListenPorts);
@@ -285,6 +333,10 @@ Conf_Test( void )
                printf("  ServerGID = %s\n", grp->gr_name);
        else
                printf("  ServerGID = %ld\n", (long)Conf_GID);
+#ifdef SYSLOG
+       printf("  SyslogFacility = %s\n",
+              ngt_SyslogFacilityName(Conf_SyslogFacility));
+#endif
        printf("  PingTimeout = %d\n", Conf_PingTimeout);
        printf("  PongTimeout = %d\n", Conf_PongTimeout);
        printf("  ConnectRetry = %d\n", Conf_ConnectRetry);
@@ -292,9 +344,6 @@ Conf_Test( void )
        printf("  OperServerMode = %s\n", yesno_to_str(Conf_OperServerMode));
        printf("  AllowRemoteOper = %s\n", yesno_to_str(Conf_AllowRemoteOper));
        printf("  PredefChannelsOnly = %s\n", yesno_to_str(Conf_PredefChannelsOnly));
-       printf("  NoDNS = %s\n", yesno_to_str(Conf_NoDNS));
-       printf("  NoIdent = %s\n", yesno_to_str(Conf_NoIdent));
-
 #ifdef WANT_IPV6
        printf("  ConnectIPv4 = %s\n", yesno_to_str(Conf_ConnectIPv6));
        printf("  ConnectIPv6 = %s\n", yesno_to_str(Conf_ConnectIPv4));
@@ -302,18 +351,17 @@ Conf_Test( void )
        printf("  MaxConnections = %ld\n", Conf_MaxConnections);
        printf("  MaxConnectionsIP = %d\n", Conf_MaxConnectionsIP);
        printf("  MaxJoins = %d\n", Conf_MaxJoins > 0 ? Conf_MaxJoins : -1);
-       printf("  MaxNickLength = %u\n\n", Conf_MaxNickLength - 1);
+       printf("  MaxNickLength = %u\n", Conf_MaxNickLength - 1);
+       printf("  ClientHost = %s\n", Conf_ClientHost);
+       printf("  ClientUserNick = %s\n\n", yesno_to_str(Conf_ClientUserNick));
 
-       for( i = 0; i < Conf_Oper_Count; i++ ) {
-               if( ! Conf_Oper[i].name[0] ) continue;
+       puts("[FEATURES]");
+       printf("  DNS = %s\n", yesno_to_str(Conf_DNS));
+       printf("  Ident = %s\n", yesno_to_str(Conf_Ident));
+       printf("  PAM = %s\n", yesno_to_str(Conf_PAM));
+       puts("");
 
-               /* Valid "Operator" section */
-               puts( "[OPERATOR]" );
-               printf( "  Name = %s\n", Conf_Oper[i].name );
-               printf( "  Password = %s\n", Conf_Oper[i].pwd );
-               if ( Conf_Oper[i].mask ) printf( "  Mask = %s\n", Conf_Oper[i].mask );
-               puts( "" );
-       }
+       opers_puts();
 
        for( i = 0; i < MAX_SERVERS; i++ ) {
                if( ! Conf_Server[i].name[0] ) continue;
@@ -519,6 +567,22 @@ Conf_IsService(int ConfServer, const char *Nick)
 } /* Conf_IsService */
 
 
+static void
+Set_Defaults_Optional(void)
+{
+#ifdef IDENTAUTH
+       Conf_Ident = true;
+#else
+       Conf_Ident = false;
+#endif
+#ifdef PAM
+       Conf_PAM = true;
+#else
+       Conf_PAM = false;
+#endif
+}
+
+
 /**
  * Initialize configuration settings with their default values.
  */
@@ -528,6 +592,8 @@ Set_Defaults(bool InitServers)
        int i;
 
        strcpy(Conf_ServerName, "");
+       strcpy(Conf_ClientHost, "");
+       Conf_ClientUserNick = false;
        snprintf(Conf_ServerInfo, sizeof Conf_ServerInfo, "%s %s",
                 PACKAGE_NAME, PACKAGE_VERSION);
        strcpy(Conf_ServerPwd, "");
@@ -538,7 +604,6 @@ Set_Defaults(bool InitServers)
 
        strlcpy(Conf_MotdFile, SYSCONFDIR, sizeof(Conf_MotdFile));
        strlcat(Conf_MotdFile, MOTD_FILE, sizeof(Conf_MotdFile));
-       strlcpy(Conf_MotdPhrase, MOTD_PHRASE, sizeof(Conf_MotdPhrase));
 
        Conf_UID = Conf_GID = 0;
        strlcpy(Conf_Chroot, CHROOT_DIR, sizeof(Conf_Chroot));
@@ -550,8 +615,7 @@ Set_Defaults(bool InitServers)
        Conf_PingTimeout = 120;
        Conf_PongTimeout = 20;
        Conf_ConnectRetry = 60;
-       Conf_NoDNS = false;
-       Conf_NoIdent = false;
+       Conf_DNS = true;
 
        Conf_Oper_Count = 0;
        Conf_Channel_Count = 0;
@@ -569,11 +633,23 @@ Set_Defaults(bool InitServers)
        Conf_MaxJoins = 10;
        Conf_MaxNickLength = CLIENT_NICK_LEN_DEFAULT;
 
+#ifdef SYSLOG
+#ifdef LOG_LOCAL5
+       Conf_SyslogFacility = LOG_LOCAL5;
+#else
+       Conf_SyslogFacility = 0;
+#endif
+#endif
+       Set_Defaults_Optional();
+
        /* Initialize server configuration structures */
        if (InitServers) {
                for (i = 0; i < MAX_SERVERS;
                     Init_Server_Struct(&Conf_Server[i++]));
        }
+
+       /* Free MOTD; this is important when reloading the configuration */
+       array_free(&Conf_Motd);
 } /* Set_Defaults */
 
 
@@ -587,6 +663,37 @@ no_listenports(void)
        return cnt == 0;
 }
 
+static void
+Read_Motd(const char *filename)
+{
+       char line[127];
+       FILE *fp;
+
+       if (*filename == '\0')
+               return;
+
+       fp = fopen(filename, "r");
+       if (!fp) {
+               Config_Error(LOG_WARNING, "Can't read MOTD file \"%s\": %s",
+                                       filename, strerror(errno));
+               return;
+       }
+
+       array_free(&Conf_Motd);
+       Using_MotdFile = true;
+
+       while (fgets(line, (int)sizeof line, fp)) {
+               ngt_TrimLastChr( line, '\n');
+
+               /* add text including \0 */
+               if (!array_catb(&Conf_Motd, line, strlen(line) + 1)) {
+                       Log(LOG_WARNING, "Cannot add MOTD text: %s", strerror(errno));
+                       break;
+               }
+       }
+       fclose(fp);
+}
+
 static bool
 Read_Config( bool ngircd_starting )
 {
@@ -609,6 +716,7 @@ Read_Config( bool ngircd_starting )
                exit( 1 );
        }
 
+       opers_free();
        Set_Defaults( ngircd_starting );
 
        Config_Error( LOG_INFO, "Reading configuration from \"%s\" ...", NGIRCd_ConfFile );
@@ -664,24 +772,10 @@ Read_Config( bool ngircd_starting )
                /* Is this the beginning of a new section? */
                if(( str[0] == '[' ) && ( str[strlen( str ) - 1] == ']' )) {
                        strlcpy( section, str, sizeof( section ));
-                       if( strcasecmp( section, "[GLOBAL]" ) == 0 )
+                       if (strcasecmp( section, "[GLOBAL]" ) == 0 ||
+                           strcasecmp( section, "[FEATURES]") == 0)
                                continue;
 
-                       if( strcasecmp( section, "[OPERATOR]" ) == 0 ) {
-                               if( Conf_Oper_Count + 1 > MAX_OPERATORS )
-                                       Config_Error( LOG_ERR, "Too many operators configured.");
-                               else {
-                                       /* Initialize new operator structure */
-                                       Conf_Oper[Conf_Oper_Count].name[0] = '\0';
-                                       Conf_Oper[Conf_Oper_Count].pwd[0] = '\0';
-                                       if (Conf_Oper[Conf_Oper_Count].mask) {
-                                               free(Conf_Oper[Conf_Oper_Count].mask );
-                                               Conf_Oper[Conf_Oper_Count].mask = NULL;
-                                       }
-                                       Conf_Oper_Count++;
-                               }
-                               continue;
-                       }
                        if( strcasecmp( section, "[SERVER]" ) == 0 ) {
                                /* Check if there is already a server to add */
                                if( New_Server.name[0] ) {
@@ -710,6 +804,10 @@ Read_Config( bool ngircd_starting )
                                Conf_Channel_Count++;
                                continue;
                        }
+                       if (strcasecmp(section, "[OPERATOR]") == 0) {
+                               Conf_Oper_Count++;
+                               continue;
+                       }
 
                        Config_Error( LOG_ERR, "%s, line %d: Unknown section \"%s\"!", NGIRCd_ConfFile, line, section );
                        section[0] = 0x1;
@@ -727,6 +825,7 @@ Read_Config( bool ngircd_starting )
                arg = ptr + 1; ngt_TrimStr( arg );
 
                if( strcasecmp( section, "[GLOBAL]" ) == 0 ) Handle_GLOBAL( line, var, arg );
+               else if( strcasecmp( section, "[FEATURES]" ) == 0 ) Handle_FEATURES( line, var, arg );
                else if( strcasecmp( section, "[OPERATOR]" ) == 0 ) Handle_OPERATOR( line, var, arg );
                else if( strcasecmp( section, "[SERVER]" ) == 0 ) Handle_SERVER( line, var, arg );
                else if( strcasecmp( section, "[CHANNEL]" ) == 0 ) Handle_CHANNEL( line, var, arg );
@@ -760,6 +859,10 @@ Read_Config( bool ngircd_starting )
                Config_Error(LOG_ALERT, "%s exiting due to fatal errors!", PACKAGE_NAME);
                exit(1);
        }
+
+       /* No MOTD phrase configured? (re)try motd file. */
+       if (array_bytes(&Conf_Motd) == 0)
+               Read_Motd(Conf_MotdFile);
        return true;
 } /* Read_Config */
 
@@ -775,7 +878,8 @@ Check_ArgIsTrue( const char *Arg )
 } /* Check_ArgIsTrue */
 
 
-static unsigned int Handle_MaxNickLength(int Line, const char *Arg)
+static unsigned int
+Handle_MaxNickLength(int Line, const char *Arg)
 {
        unsigned new;
 
@@ -796,6 +900,62 @@ static unsigned int Handle_MaxNickLength(int Line, const char *Arg)
 } /* Handle_MaxNickLength */
 
 
+static void
+WarnIdent(int UNUSED Line)
+{
+#ifndef IDENTAUTH
+       if (Conf_Ident) {
+               /* user has enabled ident lookups explicitly, but ... */
+               Config_Error(LOG_WARNING,
+                       "%s: line %d: %s=True, but ngircd was built without support",
+                       NGIRCd_ConfFile, Line, "Ident");
+       }
+#endif
+}
+
+static void
+WarnPAM(int UNUSED Line)
+{
+#ifndef PAM
+       if (Conf_PAM) {
+               Config_Error(LOG_WARNING,
+                       "%s: line %d: %s=True, but ngircd was built without support",
+                       NGIRCd_ConfFile, Line, "PAM");
+       }
+#endif
+}
+
+static bool
+CheckLegacyNoOption(const char *Var, const char *Arg)
+{
+       if( strcasecmp( Var, "NoDNS" ) == 0 ) {
+               Conf_DNS = !Check_ArgIsTrue( Arg );
+               return true;
+       }
+       if (strcasecmp(Var, "NoIdent") == 0) {
+               Conf_Ident = !Check_ArgIsTrue(Arg);
+               return true;
+       }
+       if(strcasecmp(Var, "NoPAM") == 0) {
+               Conf_PAM = !Check_ArgIsTrue(Arg);
+               return true;
+       }
+       return false;
+}
+
+static const char *
+NoNo(const char *str)
+{
+       assert(strncasecmp("no", str, 2) == 0 && str[2]);
+       return str + 2;
+}
+
+static const char *
+InvertArg(const char *arg)
+{
+       return yesno_to_str(!Check_ArgIsTrue(arg));
+}
+
 static void
 Handle_GLOBAL( int Line, char *Var, char *Arg )
 {
@@ -814,6 +974,18 @@ Handle_GLOBAL( int Line, char *Var, char *Arg )
                        Config_Error_TooLong( Line, Var );
                return;
        }
+       if( strcasecmp( Var, "ClientHost" ) == 0 ) {
+               /* Client hostname */
+               len = strlcpy( Conf_ClientHost, Arg, sizeof( Conf_ClientHost ));
+               if (len >= sizeof( Conf_ClientHost ))
+                       Config_Error_TooLong( Line, Var );
+               return;
+       }
+       if( strcasecmp( Var, "ClientUserNick" ) == 0 ) {
+               /* Use client nick name as user name */
+               Conf_ClientUserNick = Check_ArgIsTrue( Arg );
+               return;
+       }
        if( strcasecmp( Var, "Info" ) == 0 ) {
                /* Info text of server */
                len = strlcpy( Conf_ServerInfo, Arg, sizeof( Conf_ServerInfo ));
@@ -828,6 +1000,13 @@ Handle_GLOBAL( int Line, char *Var, char *Arg )
                        Config_Error_TooLong( Line, Var );
                return;
        }
+       if (strcasecmp(Var, "WebircPassword") == 0) {
+               /* Password required for WEBIRC command */
+               len = strlcpy(Conf_WebircPwd, Arg, sizeof(Conf_WebircPwd));
+               if (len >= sizeof(Conf_WebircPwd))
+                       Config_Error_TooLong(Line, Var);
+               return;
+       }
        if( strcasecmp( Var, "AdminInfo1" ) == 0 ) {
                /* Administrative info #1 */
                len = strlcpy( Conf_ServerAdmin1, Arg, sizeof( Conf_ServerAdmin1 ));
@@ -855,7 +1034,6 @@ Handle_GLOBAL( int Line, char *Var, char *Arg )
                return;
        }
        if( strcasecmp( Var, "MotdFile" ) == 0 ) {
-               /* "Message of the day" (MOTD) file */
                len = strlcpy( Conf_MotdFile, Arg, sizeof( Conf_MotdFile ));
                if (len >= sizeof( Conf_MotdFile ))
                        Config_Error_TooLong( Line, Var );
@@ -863,9 +1041,17 @@ Handle_GLOBAL( int Line, char *Var, char *Arg )
        }
        if( strcasecmp( Var, "MotdPhrase" ) == 0 ) {
                /* "Message of the day" phrase (instead of file) */
-               len = strlcpy( Conf_MotdPhrase, Arg, sizeof( Conf_MotdPhrase ));
-               if (len >= sizeof( Conf_MotdPhrase ))
+               len = strlen(Arg);
+               if (len == 0)
+                       return;
+               if (len >= LINE_LEN) {
                        Config_Error_TooLong( Line, Var );
+                       return;
+               }
+               if (!array_copyb(&Conf_Motd, Arg, len + 1))
+                       Config_Error(LOG_WARNING, "%s, line %d: Could not append MotdPhrase: %s",
+                                                       NGIRCd_ConfFile, Line, strerror(errno));
+               Using_MotdFile = false;
                return;
        }
        if( strcasecmp( Var, "ChrootDir" ) == 0 ) {
@@ -887,11 +1073,9 @@ Handle_GLOBAL( int Line, char *Var, char *Arg )
                pwd = getpwnam( Arg );
                if( pwd ) Conf_UID = pwd->pw_uid;
                else {
-#ifdef HAVE_ISDIGIT
-                       if( ! isdigit( (int)*Arg )) Config_Error_NaN( Line, Var );
-                       else
-#endif
                        Conf_UID = (unsigned int)atoi( Arg );
+                       if (!Conf_UID && strcmp(Arg, "0"))
+                               Config_Error_NaN(Line, Var);
                }
                return;
        }
@@ -900,11 +1084,9 @@ Handle_GLOBAL( int Line, char *Var, char *Arg )
                grp = getgrnam( Arg );
                if( grp ) Conf_GID = grp->gr_gid;
                else {
-#ifdef HAVE_ISDIGIT
-                       if( ! isdigit( (int)*Arg )) Config_Error_NaN( Line, Var );
-                       else
-#endif
-                       Conf_GID = (unsigned int)atoi( Arg );
+                       Conf_GID = (unsigned int)atoi(Arg);
+                       if (!Conf_GID && strcmp(Arg, "0"))
+                               Config_Error_NaN( Line, Var );
                }
                return;
        }
@@ -943,22 +1125,15 @@ Handle_GLOBAL( int Line, char *Var, char *Arg )
                Conf_PredefChannelsOnly = Check_ArgIsTrue( Arg );
                return;
        }
-       if( strcasecmp( Var, "NoDNS" ) == 0 ) {
-               /* don't do reverse dns lookups when clients connect? */
-               Conf_NoDNS = Check_ArgIsTrue( Arg );
-               return;
-       }
-       if (strcasecmp(Var, "NoIdent") == 0) {
-               /* don't do IDENT lookups when clients connect? */
-               Conf_NoIdent = Check_ArgIsTrue(Arg);
-#ifndef IDENTAUTH
-               if (!Conf_NoIdent) {
-                       /* user has enabled ident lookups explicitly, but ... */
-                       Config_Error(LOG_WARNING,
-                               "%s: line %d: NoIdent=False, but ngircd was built without IDENT support",
-                               NGIRCd_ConfFile, Line);
-               }
-#endif
+
+       if (CheckLegacyNoOption(Var, Arg)) {
+               Config_Error(LOG_WARNING, "%s, line %d: \"No\"-Prefix has been removed, use "
+                               "\"%s = %s\" in [FEATURES] section instead",
+                                       NGIRCd_ConfFile, Line, NoNo(Var), InvertArg(Arg));
+               if (strcasecmp(Var, "NoIdent") == 0)
+                       WarnIdent(Line);
+               else if (strcasecmp(Var, "NoPam") == 0)
+                       WarnPAM(Line);
                return;
        }
 #ifdef WANT_IPV6
@@ -992,29 +1167,23 @@ Handle_GLOBAL( int Line, char *Var, char *Arg )
        }
        if( strcasecmp( Var, "MaxConnections" ) == 0 ) {
                /* Maximum number of connections. 0 -> "no limit". */
-#ifdef HAVE_ISDIGIT
-               if( ! isdigit( (int)*Arg )) Config_Error_NaN( Line, Var);
-               else
-#endif
                Conf_MaxConnections = atol( Arg );
+               if (!Conf_MaxConnections && strcmp(Arg, "0"))
+                       Config_Error_NaN(Line, Var);
                return;
        }
        if( strcasecmp( Var, "MaxConnectionsIP" ) == 0 ) {
                /* Maximum number of simultaneous connections from one IP. 0 -> "no limit" */
-#ifdef HAVE_ISDIGIT
-               if( ! isdigit( (int)*Arg )) Config_Error_NaN( Line, Var );
-               else
-#endif
                Conf_MaxConnectionsIP = atoi( Arg );
+               if (!Conf_MaxConnectionsIP && strcmp(Arg, "0"))
+                       Config_Error_NaN(Line, Var);
                return;
        }
        if( strcasecmp( Var, "MaxJoins" ) == 0 ) {
                /* Maximum number of channels a user can join. 0 -> "no limit". */
-#ifdef HAVE_ISDIGIT
-               if( ! isdigit( (int)*Arg )) Config_Error_NaN( Line, Var );
-               else
-#endif
                Conf_MaxJoins = atoi( Arg );
+               if (!Conf_MaxJoins && strcmp(Arg, "0"))
+                       Config_Error_NaN(Line, Var);
                return;
        }
        if( strcasecmp( Var, "MaxNickLength" ) == 0 ) {
@@ -1072,45 +1241,80 @@ Handle_GLOBAL( int Line, char *Var, char *Arg )
                Conf_SSLOptions.DHFile = strdup_warn( Arg );
                 return;
         }
+#endif
+#ifdef SYSLOG
+       if (strcasecmp(Var, "SyslogFacility") == 0) {
+               Conf_SyslogFacility = ngt_SyslogFacilityID(Arg,
+                                                          Conf_SyslogFacility);
+               return;
+       }
 #endif
        Config_Error(LOG_ERR, "%s, line %d (section \"Global\"): Unknown variable \"%s\"!",
                                                                NGIRCd_ConfFile, Line, Var);
 } /* Handle_GLOBAL */
 
 
+static void
+Handle_FEATURES(int Line, char *Var, char *Arg)
+{
+       assert( Line > 0 );
+       assert( Var != NULL );
+       assert( Arg != NULL );
+
+       if( strcasecmp( Var, "DNS" ) == 0 ) {
+               /* do reverse dns lookups when clients connect? */
+               Conf_DNS = Check_ArgIsTrue( Arg );
+               return;
+       }
+       if (strcasecmp(Var, "Ident") == 0) {
+               /* do IDENT lookups when clients connect? */
+               Conf_Ident = Check_ArgIsTrue(Arg);
+               WarnIdent(Line);
+               return;
+       }
+       if(strcasecmp(Var, "PAM") == 0) {
+               /* use PAM library to authenticate users */
+               Conf_PAM = Check_ArgIsTrue(Arg);
+               WarnPAM(Line);
+               return;
+       }
+}
+
 static void
 Handle_OPERATOR( int Line, char *Var, char *Arg )
 {
-       unsigned int opercount;
        size_t len;
+       struct Conf_Oper *op;
+
        assert( Line > 0 );
        assert( Var != NULL );
        assert( Arg != NULL );
        assert( Conf_Oper_Count > 0 );
 
-       if ( Conf_Oper_Count == 0 )
+       op = array_alloc(&Conf_Opers, sizeof(*op), Conf_Oper_Count - 1);
+       if (!op) {
+               Config_Error(LOG_ERR, "Could not allocate memory for operator (%d:%s = %s)", Line, Var, Arg);
                return;
+       }
 
-       opercount = Conf_Oper_Count - 1;
-
-       if( strcasecmp( Var, "Name" ) == 0 ) {
+       if (strcasecmp(Var, "Name") == 0) {
                /* Name of IRC operator */
-               len = strlcpy( Conf_Oper[opercount].name, Arg, sizeof( Conf_Oper[opercount].name ));
-               if (len >= sizeof( Conf_Oper[opercount].name ))
-                               Config_Error_TooLong( Line, Var );
+               len = strlcpy(op->name, Arg, sizeof(op->name));
+               if (len >= sizeof(op->name))
+                               Config_Error_TooLong(Line, Var);
                return;
        }
-       if( strcasecmp( Var, "Password" ) == 0 ) {
+       if (strcasecmp(Var, "Password") == 0) {
                /* Password of IRC operator */
-               len = strlcpy( Conf_Oper[opercount].pwd, Arg, sizeof( Conf_Oper[opercount].pwd ));
-               if (len >= sizeof( Conf_Oper[opercount].pwd ))
-                               Config_Error_TooLong( Line, Var );
+               len = strlcpy(op->pwd, Arg, sizeof(op->pwd));
+               if (len >= sizeof(op->pwd))
+                               Config_Error_TooLong(Line, Var);
                return;
        }
-       if( strcasecmp( Var, "Mask" ) == 0 ) {
-               if (Conf_Oper[opercount].mask) return; /* Hostname already configured */
-
-               Conf_Oper[opercount].mask = strdup_warn( Arg );
+       if (strcasecmp(Var, "Mask") == 0) {
+               if (op->mask)
+                       return; /* Hostname already configured */
+               op->mask = strdup_warn( Arg );
                return;
        }
        Config_Error( LOG_ERR, "%s, line %d (section \"Operator\"): Unknown variable \"%s\"!",
@@ -1175,11 +1379,12 @@ Handle_SERVER( int Line, char *Var, char *Arg )
        if( strcasecmp( Var, "Port" ) == 0 ) {
                /* Port to which this server should connect */
                port = atol( Arg );
-               if( port > 0 && port < 0xFFFF )
+               if (port >= 0 && port < 0xFFFF)
                        New_Server.port = (UINT16)port;
                else
-                       Config_Error( LOG_ERR, "%s, line %d (section \"Server\"): Illegal port number %ld!",
-                                                                               NGIRCd_ConfFile, Line, port );
+                       Config_Error(LOG_ERR,
+                               "%s, line %d (section \"Server\"): Illegal port number %ld!",
+                               NGIRCd_ConfFile, Line, port );
                return;
        }
 #ifdef SSL_SUPPORT
@@ -1190,12 +1395,9 @@ Handle_SERVER( int Line, char *Var, char *Arg )
 #endif
        if( strcasecmp( Var, "Group" ) == 0 ) {
                /* Server group */
-#ifdef HAVE_ISDIGIT
-               if( ! isdigit( (int)*Arg ))
-                       Config_Error_NaN( Line, Var );
-               else
-#endif
                New_Server.group = atoi( Arg );
+               if (!New_Server.group && strcmp(Arg, "0"))
+                       Config_Error_NaN(Line, Var);
                return;
        }
        if( strcasecmp( Var, "Passive" ) == 0 ) {
@@ -1283,7 +1485,7 @@ Handle_CHANNEL(int Line, char *Var, char *Arg)
        if( strcasecmp( Var, "MaxUsers" ) == 0 ) {
                /* maximum user limit, mode l */
                chan->maxusers = (unsigned long) atol(Arg);
-               if (chan->maxusers == 0)
+               if (!chan->maxusers && strcmp(Arg, "0"))
                        Config_Error_NaN(Line, Var);
                return;
        }
@@ -1376,6 +1578,12 @@ Validate_Config(bool Configtest, bool Rehash)
                             "No administrative information configured but required by RFC!");
        }
 
+#ifdef PAM
+       if (Conf_ServerPwd[0])
+               Config_Error(LOG_ERR,
+                            "This server uses PAM, \"Password\" will be ignored!");
+#endif
+
 #ifdef DEBUG
        servers = servers_once = 0;
        for (i = 0; i < MAX_SERVERS; i++) {
@@ -1441,6 +1649,29 @@ va_dcl
 } /* Config_Error */
 
 
+#ifdef DEBUG
+
+GLOBAL void
+Conf_DebugDump(void)
+{
+       int i;
+
+       Log(LOG_DEBUG, "Configured servers:");
+       for (i = 0; i < MAX_SERVERS; i++) {
+               if (! Conf_Server[i].name[0])
+                       continue;
+               Log(LOG_DEBUG,
+                   " - %s: %s:%d, last=%ld, group=%d, flags=%d, conn=%d",
+                   Conf_Server[i].name, Conf_Server[i].host,
+                   Conf_Server[i].port, Conf_Server[i].lasttry,
+                   Conf_Server[i].group, Conf_Server[i].flags,
+                   Conf_Server[i].conn_id);
+       }
+} /* Conf_DebugDump */
+
+#endif
+
+
 static void
 Init_Server_Struct( CONF_SERVER *Server )
 {
@@ -1455,7 +1686,7 @@ Init_Server_Struct( CONF_SERVER *Server )
 
        if( NGIRCd_Passive ) Server->flags = CONF_SFLAG_DISABLED;
 
-       Resolve_Init(&Server->res_stat);
+       Proc_InitStruct(&Server->res_stat);
        Server->conn_id = NONE;
        memset(&Server->bind_addr, 0, sizeof(&Server->bind_addr));
 } /* Init_Server_Struct */