From: Frank Lahm <franklahm@googlemail.com>
Date: Fri, 15 Apr 2011 12:49:13 +0000 (+0200)
Subject: log messages
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=netatalk.git;a=commitdiff_plain;h=d9e881c56632803d4b2f97f17c219d38dcb537f3

log messages
---

diff --git a/libatalk/vfs/ea_sys.c b/libatalk/vfs/ea_sys.c
index a4e35a90..77ab783b 100644
--- a/libatalk/vfs/ea_sys.c
+++ b/libatalk/vfs/ea_sys.c
@@ -325,15 +325,20 @@ int sys_set_ea(VFS_FUNC_ARGS_EA_SET)
         switch(errno) {
         case OPEN_NOFOLLOW_ERRNO:
             /* its a symlink and client requested O_NOFOLLOW  */
-            LOG(log_debug, logtype_afpd, "sys_set_ea(%s/%s): encountered symlink with kXAttrNoFollow",
-                uname, attruname);
+            LOG(log_debug, logtype_afpd, "sys_set_ea(\"%s/%s\", ea:'%s'): encountered symlink with kXAttrNoFollow",
+                getcwdpath(), uname, attruname);
             return AFP_OK;
         case EEXIST:
-            LOG(log_debug, logtype_afpd, "sys_set_ea(%s/%s): EA already exists",
-                uname, attruname);
+            LOG(log_debug, logtype_afpd, "sys_set_ea(\"%s/%s\", ea:'%s'): EA already exists",
+                getcwdpath(), uname, attruname);
             return AFPERR_EXIST;
         default:
-            LOG(log_error, logtype_afpd, "sys_set_ea(%s/%s): error: %s", uname, attruname, strerror(errno));
+            LOG(log_error, logtype_afpd, "sys_set_ea(\"%s/%s\", ea:'%s', size: %u, flags: %s|%s|%s): %s",
+                getcwdpath(), uname, attruname, attrsize, 
+                oflag & O_CREAT ? "XATTR_CREATE" : "-",
+                oflag & O_TRUNC ? "XATTR_REPLACE" : "-",
+                oflag & O_NOFOLLOW ? "O_NOFOLLOW" : "-",
+                strerror(errno));
             return AFPERR_MISC;
         }
     }
diff --git a/libatalk/vfs/sys_ea.c b/libatalk/vfs/sys_ea.c
index 900eb07e..3db20b23 100644
--- a/libatalk/vfs/sys_ea.c
+++ b/libatalk/vfs/sys_ea.c
@@ -707,7 +707,7 @@ static ssize_t solaris_list_xattr(int attrdirfd, char *list, size_t size)
 	}
 
 	if (closedir(dirp) == -1) {
-		LOG(log_debug, logtype_default, "closedir dirp failed: %s\n",strerror(errno));
+		LOG(log_error, logtype_default, "closedir dirp: %s",strerror(errno));
 		return -1;
 	}
 	return len;
@@ -725,7 +725,9 @@ static int solaris_attropen(const char *path, const char *attrpath, int oflag, m
 {
 	int filedes = attropen(path, attrpath, oflag, mode);
 	if (filedes == -1) {
-		LOG(log_maxdebug, logtype_default, "attropen FAILED: path: %s, name: %s, errno: %s\n",path,attrpath,strerror(errno));
+        if (errno != ENOENT)
+            LOG(log_error, logtype_default, "attropen(\"%s\", ea:'%s'): %s",
+                path, attrpath, strerror(errno));
         errno = ENOATTR;
 	}
 	return filedes;
@@ -735,7 +737,8 @@ static int solaris_openat(int fildes, const char *path, int oflag, mode_t mode)
 {
 	int filedes = openat(fildes, path, oflag, mode);
 	if (filedes == -1) {
-		LOG(log_maxdebug, logtype_default, "openat FAILED: fd: %s, path: %s, errno: %s\n",filedes,path,strerror(errno));
+		LOG(log_error, logtype_default, "openat(\"%s\"): %s",
+            path, strerror(errno));
 	}
 	return filedes;
 }
@@ -745,7 +748,8 @@ static int solaris_write_xattr(int attrfd, const char *value, size_t size)
 	if ((ftruncate(attrfd, 0) == 0) && (write(attrfd, value, size) == size)) {
 		return 0;
 	} else {
-		LOG(log_maxdebug, logtype_default, "solaris_write_xattr FAILED!\n");
+		LOG(log_error, logtype_default, "solaris_write_xattr: %s",
+            strerror(errno));
 		return -1;
 	}
 }