From: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Date: Sat, 9 Feb 2013 10:36:29 +0000 (+0100)
Subject: libatalk: Fix a couple of issues in ad_openat()
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=netatalk.git;a=commitdiff_plain;h=8852315e574879a9548c31f84c6eaea59f1db90f

libatalk: Fix a couple of issues in ad_openat()

Reported by coverity as CID #762151, #762127.
---

diff --git a/libatalk/adouble/ad_open.c b/libatalk/adouble/ad_open.c
index 5aca77c0..a4a56b12 100644
--- a/libatalk/adouble/ad_open.c
+++ b/libatalk/adouble/ad_open.c
@@ -1824,10 +1824,12 @@ int ad_openat(struct adouble  *ad,
     EC_INIT;
     int cwdfd = -1;
     va_list args;
-    mode_t mode;
+    mode_t mode = 0;
 
     if (dirfd != -1) {
         if ((cwdfd = open(".", O_RDONLY) == -1) || (fchdir(dirfd) != 0))
+            if (cwdfd > 0)
+                close(cwdfd);
             EC_FAIL;
     }