afpd/fork: avoid use after free on of_closefork error

Reported by Coverity as CID #201311.

diff --git a/etc/afpd/fork.c b/etc/afpd/fork.c
index 2d59b5da0450e22d5b9f8b21ae3562d3beab6d3c..7b24b7f26b99e26a5c648b9686021be229967eea 100644 (file)
--- a/etc/afpd/fork.c
+++ b/etc/afpd/fork.c
@@ -1037,7 +1037,7 @@ int afp_closefork(AFPObj *obj, char *ibuf, size_t ibuflen _U_, char *rbuf _U_, s
         ofork->of_refnum, (ofork->of_flags & AFPFORK_DATA) ? "data" : "rsrc");
 
     if (of_closefork(obj, ofork) < 0 ) {
-        LOG(log_error, logtype_afpd, "afp_closefork(%s): of_closefork: %s", of_name(ofork), strerror(errno) );
+        LOG(log_error, logtype_afpd, "afp_closefork: of_closefork: %s", strerror(errno) );
         return( AFPERR_PARAM );
     }