X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=netatalk.git;a=blobdiff_plain;f=libatalk%2Fdsi%2Fdsi_tcp.c;h=e06e87d92420187948611b9d044995ab158065c6;hp=0c60303ecb6159c5310d44d28f59242876e69e2d;hb=8e5e83dac34cf886996821a51dee5c971e7c51f2;hpb=5825df1c826101269dccd558ac9ac85c0dcd4e36 diff --git a/libatalk/dsi/dsi_tcp.c b/libatalk/dsi/dsi_tcp.c index 0c60303e..e06e87d9 100644 --- a/libatalk/dsi/dsi_tcp.c +++ b/libatalk/dsi/dsi_tcp.c @@ -1,6 +1,4 @@ /* - * $Id: dsi_tcp.c,v 1.25 2009-12-08 22:34:37 didg Exp $ - * * Copyright (c) 1997, 1998 Adrian Sun (asun@zoology.washington.edu) * All rights reserved. See COPYRIGHT. * @@ -12,14 +10,10 @@ #include "config.h" #endif /* HAVE_CONFIG_H */ -#define USE_TCP_NODELAY - #include #include #include -#ifdef HAVE_UNISTD_H #include -#endif /* HAVE_UNISTD_H */ #include #ifdef HAVE_NETDB_H #include @@ -27,10 +21,7 @@ #include #include #include - -#ifdef HAVE_STDINT_H #include -#endif /* HAVE_STDINT_H */ #include #ifdef TRU64 @@ -58,8 +49,7 @@ int deny_severity = log_warning; #include #include #include -#include -#include "dsi_private.h" +#include #define min(a,b) ((a) < (b) ? (a) : (b)) @@ -93,6 +83,26 @@ static void timeout_handler(int sig _U_) exit(EXITERR_CLNT); } +/*! + * Allocate DSI read buffer and read-ahead buffer + */ +static void dsi_init_buffer(DSI *dsi) +{ + if ((dsi->commands = malloc(dsi->server_quantum)) == NULL) { + LOG(log_error, logtype_dsi, "dsi_init_buffer: OOM"); + AFP_PANIC("OOM in dsi_init_buffer"); + } + + /* dsi_peek() read ahead buffer, default is 12 * 300k = 3,6 MB (Apr 2011) */ + if ((dsi->buffer = malloc(dsi->dsireadbuf * dsi->server_quantum)) == NULL) { + LOG(log_error, logtype_dsi, "dsi_init_buffer: OOM"); + AFP_PANIC("OOM in dsi_init_buffer"); + } + dsi->start = dsi->buffer; + dsi->eof = dsi->buffer; + dsi->end = dsi->buffer + (dsi->dsireadbuf * dsi->server_quantum); +} + static struct itimerval itimer; /* accept the socket and do a little sanity checking */ static int dsi_tcp_open(DSI *dsi) @@ -106,7 +116,7 @@ static int dsi_tcp_open(DSI *dsi) #ifdef TCPWRAP { struct request_info req; - request_init(&req, RQ_DAEMON, dsi->program, RQ_FILE, dsi->socket, NULL); + request_init(&req, RQ_DAEMON, "afpd", RQ_FILE, dsi->socket, NULL); fromhost(&req); if (!hosts_access(&req)) { LOG(deny_severity, logtype_dsi, "refused connect from %s", eval_client(&req)); @@ -124,12 +134,9 @@ static int dsi_tcp_open(DSI *dsi) if (0 == (pid = fork()) ) { /* child */ static struct itimerval timer = {{0, 0}, {DSI_TCPTIMEOUT, 0}}; struct sigaction newact, oldact; - u_int8_t block[DSI_BLOCKSIZ]; + uint8_t block[DSI_BLOCKSIZ]; size_t stored; - /* Immediateyl mark globally that we're a child now */ - parent_or_child = 1; - /* reset signals */ server_reset_signal(); @@ -149,6 +156,8 @@ static int dsi_tcp_open(DSI *dsi) } #endif + dsi_init_buffer(dsi); + /* read in commands. this is similar to dsi_receive except * for the fact that we do some sanity checking to prevent * delinquent connections from causing mischief. */ @@ -187,7 +196,7 @@ static int dsi_tcp_open(DSI *dsi) dsi->clientID = ntohs(dsi->header.dsi_requestID); /* make sure we don't over-write our buffers. */ - dsi->cmdlen = min(ntohl(dsi->header.dsi_len), DSI_CMDSIZ); + dsi->cmdlen = min(ntohl(dsi->header.dsi_len), dsi->server_quantum); stored = 0; while (stored < dsi->cmdlen) { @@ -260,9 +269,10 @@ static void guess_interface(DSI *dsi, const char *hostname, const char *port) getip_string((struct sockaddr *)&dsi->server), port, ifr.ifr_name); goto iflist_done; } - LOG(log_info, logtype_dsi, "dsi_tcp (Chooser will not select afp/tcp) " - "Check to make sure %s is in /etc/hosts and the correct domain is in " - "/etc/resolv.conf: %s", hostname, strerror(errno)); + + LOG(log_note, logtype_dsi, "dsi_tcp: couldn't find network interface with IP address to advertice, " + "check to make sure \"%s\" is in /etc/hosts or can be resolved with DNS, or " + "add a netinterface that is not a loopback or point-2-point type", hostname); iflist_done: close(fd); @@ -275,14 +285,24 @@ iflist_done: #endif /* this needs to accept passed in addresses */ -int dsi_tcp_init(DSI *dsi, const char *hostname, const char *address, - const char *port, const int proxy) +int dsi_tcp_init(DSI *dsi, const char *hostname, const char *inaddress, const char *inport) { - int ret; - int flag; + EC_INIT; + int flag, err; + char *a = NULL, *b; + const char *address; + const char *port; struct addrinfo hints, *servinfo, *p; - dsi->protocol = DSI_TCPIP; + /* Check whether address is of the from IP:PORT and split */ + address = inaddress; + port = inport; + if (address && strchr(address, ':')) { + EC_NULL_LOG( address = a = strdup(address) ); + b = strchr(a, ':'); + *b = 0; + port = b + 1; + } /* Prepare hint for getaddrinfo */ memset(&hints, 0, sizeof hints); @@ -303,69 +323,62 @@ int dsi_tcp_init(DSI *dsi, const char *hostname, const char *address, hints.ai_family = AF_UNSPEC; #endif } - if ((ret = getaddrinfo(address ? address : NULL, port ? port : "548", &hints, &servinfo)) != 0) { + if ((ret = getaddrinfo(address ? address : NULL, port, &hints, &servinfo)) != 0) { LOG(log_error, logtype_dsi, "dsi_tcp_init: getaddrinfo: %s\n", gai_strerror(ret)); - return 0; + EC_FAIL; } - /* create a socket */ - if (proxy) - dsi->serversock = -1; - else { - /* loop through all the results and bind to the first we can */ - for (p = servinfo; p != NULL; p = p->ai_next) { - if ((dsi->serversock = socket(p->ai_family, p->ai_socktype, p->ai_protocol)) == -1) { - LOG(log_info, logtype_dsi, "dsi_tcp_init: socket: %s", strerror(errno)); - continue; - } + /* loop through all the results and bind to the first we can */ + for (p = servinfo; p != NULL; p = p->ai_next) { + if ((dsi->serversock = socket(p->ai_family, p->ai_socktype, p->ai_protocol)) == -1) { + LOG(log_info, logtype_dsi, "dsi_tcp_init: socket: %s", strerror(errno)); + continue; + } - /* - * Set some socket options: - * SO_REUSEADDR deals w/ quick close/opens - * TCP_NODELAY diables Nagle - */ + /* + * Set some socket options: + * SO_REUSEADDR deals w/ quick close/opens + * TCP_NODELAY diables Nagle + */ #ifdef SO_REUSEADDR - flag = 1; - setsockopt(dsi->serversock, SOL_SOCKET, SO_REUSEADDR, &flag, sizeof(flag)); + flag = 1; + setsockopt(dsi->serversock, SOL_SOCKET, SO_REUSEADDR, &flag, sizeof(flag)); #endif #if defined(FREEBSD) && defined(IPV6_BINDV6ONLY) - int on = 0; - setsockopt(dsi->serversock, IPPROTO_IPV6, IPV6_BINDV6ONLY, (char *)&on, sizeof (on)); + int on = 0; + setsockopt(dsi->serversock, IPPROTO_IPV6, IPV6_BINDV6ONLY, (char *)&on, sizeof (on)); #endif -#ifdef USE_TCP_NODELAY #ifndef SOL_TCP #define SOL_TCP IPPROTO_TCP #endif - flag = 1; - setsockopt(dsi->serversock, SOL_TCP, TCP_NODELAY, &flag, sizeof(flag)); -#endif /* USE_TCP_NODELAY */ - - if (bind(dsi->serversock, p->ai_addr, p->ai_addrlen) == -1) { - close(dsi->serversock); - LOG(log_info, logtype_dsi, "dsi_tcp_init: bind: %s\n", strerror(errno)); - continue; - } - - if (listen(dsi->serversock, DSI_TCPMAXPEND) < 0) { - close(dsi->serversock); - LOG(log_info, logtype_dsi, "dsi_tcp_init: listen: %s\n", strerror(errno)); - continue; - } + flag = 1; + setsockopt(dsi->serversock, SOL_TCP, TCP_NODELAY, &flag, sizeof(flag)); - break; + if (bind(dsi->serversock, p->ai_addr, p->ai_addrlen) == -1) { + close(dsi->serversock); + LOG(log_info, logtype_dsi, "dsi_tcp_init: bind: %s\n", strerror(errno)); + continue; } - if (p == NULL) { - LOG(log_error, logtype_dsi, "dsi_tcp_init: no suitable network config for TCP socket"); - freeaddrinfo(servinfo); - return 0; + if (listen(dsi->serversock, DSI_TCPMAXPEND) < 0) { + close(dsi->serversock); + LOG(log_info, logtype_dsi, "dsi_tcp_init: listen: %s\n", strerror(errno)); + continue; } + + break; + } - /* Copy struct sockaddr to struct sockaddr_storage */ - memcpy(&dsi->server, p->ai_addr, p->ai_addrlen); + if (p == NULL) { + LOG(log_error, logtype_dsi, "dsi_tcp_init: no suitable network config for TCP socket"); freeaddrinfo(servinfo); - } /* if (proxy) */ + EC_FAIL; + } + + /* Copy struct sockaddr to struct sockaddr_storage */ + memcpy(&dsi->server, p->ai_addr, p->ai_addrlen); + freeaddrinfo(servinfo); /* Point protocol specific functions to tcp versions */ dsi->proto_open = dsi_tcp_open; @@ -375,7 +388,7 @@ int dsi_tcp_init(DSI *dsi, const char *hostname, const char *address, if (address) { /* address is a parameter, use it 'as is' */ - return 1; + goto EC_CLEANUP; } /* Prepare hint for getaddrinfo */ @@ -383,8 +396,8 @@ int dsi_tcp_init(DSI *dsi, const char *hostname, const char *address, hints.ai_family = AF_UNSPEC; hints.ai_socktype = SOCK_STREAM; - if ((ret = getaddrinfo(hostname, port ? port : "548", &hints, &servinfo)) != 0) { - LOG(log_info, logtype_dsi, "dsi_tcp_init: getaddrinfo '%s': %s\n", hostname, gai_strerror(ret)); + if ((err = getaddrinfo(hostname, port, &hints, &servinfo)) != 0) { + LOG(log_info, logtype_dsi, "dsi_tcp_init: getaddrinfo '%s': %s\n", hostname, gai_strerror(err)); goto interfaces; } @@ -405,13 +418,17 @@ int dsi_tcp_init(DSI *dsi, const char *hostname, const char *address, /* Store found address in dsi->server */ memcpy(&dsi->server, p->ai_addr, p->ai_addrlen); freeaddrinfo(servinfo); - return 1; + goto EC_CLEANUP; } LOG(log_info, logtype_dsi, "dsi_tcp: hostname '%s' resolves to loopback address", hostname); freeaddrinfo(servinfo); interfaces: guess_interface(dsi, hostname, port ? port : "548"); - return 1; + +EC_CLEANUP: + if (a) + free(a); + EC_EXIT; }