From cdf77000f6f5c50aef378078465cadf1a783e968 Mon Sep 17 00:00:00 2001 From: Rob Browning Date: Thu, 4 Jul 2013 15:32:07 -0500 Subject: [PATCH] Completely disable ACL support on OS X for now. Signed-off-by: Rob Browning --- README.md | 7 +++++++ lib/bup/metadata.py | 2 +- t/compare-trees | 15 +++++++++------ 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 2d40826..3fcdcc6 100644 --- a/README.md +++ b/README.md @@ -272,6 +272,13 @@ Notes on Cygwin http://cygwin.com/ml/cygwin/2007-06/msg00436.html +Notes on OS X +------------- + + - There is no support for ACLs. If/when some entrprising person + fixes this, adjust t/compare-trees. + + How it works ============ diff --git a/lib/bup/metadata.py b/lib/bup/metadata.py index 384991e..bdf3738 100644 --- a/lib/bup/metadata.py +++ b/lib/bup/metadata.py @@ -27,7 +27,7 @@ if sys.platform.startswith('linux'): xattr = None posix1e = None -if not sys.platform.startswith('cygwin'): +if not (sys.platform.startswith('cygwin') or sys.platform.startswith('darwin')): try: import posix1e except ImportError: diff --git a/t/compare-trees b/t/compare-trees index 80b056a..b611b0f 100755 --- a/t/compare-trees +++ b/t/compare-trees @@ -48,12 +48,15 @@ trap "rm -rf '${tmpfile}'" EXIT rsync_opts="-niaH$verify_content --delete" if rsync --version | grep -q xattrs; then - if [[ $(uname) =~ CYGWIN ]]; then - # bup doesn't support ACLs on Cygwin yet. - rsync_opts="$rsync_opts -X" - else - rsync_opts="$rsync_opts -AX" - fi + case $OSTYPE in + cygwin|darwin) + # bup doesn't support ACLs here yet. + rsync_opts="$rsync_opts -X" + ;; + *) + rsync_opts="$rsync_opts -AX" + ;; + esac else echo "Not comparing xattrs/acls (unsupported by available rsync)." 1>&2 fi -- 2.39.2