From 119f9dd3b3421c31578105954a34fc5e32826ae5 Mon Sep 17 00:00:00 2001 From: Avery Pennarun Date: Wed, 3 Mar 2010 22:34:40 -0500 Subject: [PATCH] main: fix problem when redirecting to newliner on MacOS X. It's probably just a bug in python 2.4.2, which is the version on my old MacOS machine. But it seems that if you use subprocess.Popen with stdout=1 and/or stderr=2, it ends up closing the file descriptors instead of passing them along. Since those are the defaults anyway, just use None instead. --- main.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/main.py b/main.py index 3dcff69..4d8ea1f 100755 --- a/main.py +++ b/main.py @@ -99,12 +99,12 @@ if fix_stdout or fix_stderr: n = subprocess.Popen([subpath('newliner')], stdin=subprocess.PIPE, stdout=os.dup(realf), close_fds=True, preexec_fn=force_tty) - outf = fix_stdout and n.stdin.fileno() or 1 - errf = fix_stderr and n.stdin.fileno() or 2 + outf = fix_stdout and n.stdin.fileno() or None + errf = fix_stderr and n.stdin.fileno() or None else: n = None - outf = 1 - errf = 2 + outf = None + errf = None class SigException(Exception): -- 2.39.2