From: Avery Pennarun Date: Mon, 7 Feb 2011 08:55:10 +0000 (-0800) Subject: cmd/bloom: use mkstemp() instead of NamedTemporaryFile(). X-Git-Tag: bup-0.23~17^2~9 X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=bup.git;a=commitdiff_plain;h=825dea0746125f542dd84892fb5f3e9b98de3200 cmd/bloom: use mkstemp() instead of NamedTemporaryFile(). Older versions of python (I tested python 2.5) don't support the delete=False parameter to NamedTemporaryFile(). In any case, it's not actually a temporary file since we're not planning to delete it. Signed-off-by: Avery Pennarun --- diff --git a/cmd/bloom-cmd.py b/cmd/bloom-cmd.py index 44579ac..434be32 100755 --- a/cmd/bloom-cmd.py +++ b/cmd/bloom-cmd.py @@ -62,10 +62,10 @@ def do_bloom(path, outfilename): tempname = None if b is None: - tf = tempfile.NamedTemporaryFile( - dir=path, suffix='bup.bloom', delete=False) + tfd,tfname = tempfile.mkstemp(dir=path, suffix='bup.bloom') + tf = os.fdopen(tfd, 'w+') b = git.ShaBloom.create( - tf.name, f=tf, readwrite=True, expected=add_count, k=opt.k) + tfname, f=tf, readwrite=True, expected=add_count, k=opt.k) count = 0 for ix in add: progress('Writing bloom: %d/%d\r' % (count, len(add)))