From: Rob Browning Date: Tue, 29 Dec 2015 06:56:23 +0000 (-0600) Subject: Use Python 3 compatible octal notation X-Git-Tag: 0.28-rc1~40 X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=bup.git;a=commitdiff_plain;h=7caa0310905315f221b0c2cce4abb49317038f13;hp=a25e07f4ff51afe998b38b4b1e918736fc53a210 Use Python 3 compatible octal notation Signed-off-by: Rob Browning Tested-by: Rob Browning --- diff --git a/cmd/restore-cmd.py b/cmd/restore-cmd.py index c7f446b..49f5176 100755 --- a/cmd/restore-cmd.py +++ b/cmd/restore-cmd.py @@ -172,7 +172,7 @@ def write_file_content(fullname, n): def write_file_content_sparsely(fullname, n): - outfd = os.open(fullname, os.O_WRONLY | os.O_CREAT | os.O_TRUNC, 0600) + outfd = os.open(fullname, os.O_WRONLY | os.O_CREAT | os.O_TRUNC, 0o600) try: trailing_zeros = 0; for b in chunkyreader(n.open()): diff --git a/lib/bup/metadata.py b/lib/bup/metadata.py index b981817..0466345 100644 --- a/lib/bup/metadata.py +++ b/lib/bup/metadata.py @@ -323,23 +323,23 @@ class Metadata: if stat.S_ISREG(self.mode): assert(self._recognized_file_type()) - fd = os.open(path, os.O_CREAT|os.O_WRONLY|os.O_EXCL, 0600) + fd = os.open(path, os.O_CREAT|os.O_WRONLY|os.O_EXCL, 0o600) os.close(fd) elif stat.S_ISDIR(self.mode): assert(self._recognized_file_type()) - os.mkdir(path, 0700) + os.mkdir(path, 0o700) elif stat.S_ISCHR(self.mode): assert(self._recognized_file_type()) - os.mknod(path, 0600 | stat.S_IFCHR, self.rdev) + os.mknod(path, 0o600 | stat.S_IFCHR, self.rdev) elif stat.S_ISBLK(self.mode): assert(self._recognized_file_type()) - os.mknod(path, 0600 | stat.S_IFBLK, self.rdev) + os.mknod(path, 0o600 | stat.S_IFBLK, self.rdev) elif stat.S_ISFIFO(self.mode): assert(self._recognized_file_type()) - os.mknod(path, 0600 | stat.S_IFIFO) + os.mknod(path, 0o600 | stat.S_IFIFO) elif stat.S_ISSOCK(self.mode): try: - os.mknod(path, 0600 | stat.S_IFSOCK) + os.mknod(path, 0o600 | stat.S_IFSOCK) except OSError, e: if e.errno in (errno.EINVAL, errno.EPERM): s = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) @@ -352,7 +352,7 @@ class Metadata: # on MacOS, symlink() permissions depend on umask, and there's # no way to chown a symlink after creating it, so we have to # be careful here! - oldumask = os.umask((self.mode & 0777) ^ 0777) + oldumask = os.umask((self.mode & 0o777) ^ 0o777) try: os.symlink(self.symlink_target, path) finally: diff --git a/lib/bup/t/tmetadata.py b/lib/bup/t/tmetadata.py index 126e1d7..dbd5fe2 100644 --- a/lib/bup/t/tmetadata.py +++ b/lib/bup/t/tmetadata.py @@ -41,7 +41,7 @@ def setup_testfs(): ex('mount', '-o', 'loop,acl,user_xattr', 'testfs.img', 'testfs') # Hide, so that tests can't create risks. os.chown('testfs', 0, 0) - os.chmod('testfs', 0700) + os.chmod('testfs', 0o700) return True