configure-sampledata: only create random paths if asked

Stop creating randomized paths in t/sampledata/ by default.  I'd
originally just added this to allow some quick testing, and while it
now appears to be fine on Linux/ext4, it's too aggressive to be the
default, so hide it behind a BUP_TEST_RANDOMIZED_SAMPLEDATA_PATHS
environment variable.

Among other things, make-random-paths just crashes on cirrus macos,
and cirrus freebsd was having (different) trouble.  It might also have
been macos where test-import-duplicity.sh failed on compare-trees
mismatches.  Not sure whether that was an issue with bup, rsync, or
duplicity.

We'll want to restore broader randomized path testing, but likely via
a less blunt instrument, since placing the paths in t/sampledata
affects any test that relies on it, and existing testing constructs
like

  WVPASSEQ ... $(... | wc -l)

are completely incompatible.

Signed-off-by: Rob Browning <rlb@defaultvalue.org>

diff --git a/t/configure-sampledata b/t/configure-sampledata
index 487a0f59c3576ca92c518f90ed21959827809e67..111c7c3cc76f89f23b68bed1622fe7d8c5eae0bd 100755 (executable)
--- a/t/configure-sampledata
+++ b/t/configure-sampledata
@@ -49,7 +49,9 @@ case "$1" in
             cp -pP "$top"/Documentation/*.md doc/ || exit $?
             cp -pP "$top"/lib/bup/*.py lib/bup || exit $?
             mkdir path-zoo || exit $?
-            "$top"/t/make-random-paths 3000 path-zoo || exit $?
+            if test "$BUP_TEST_RANDOMIZED_SAMPLEDATA_PATHS"; then
+                "$top"/t/make-random-paths 3000 path-zoo || exit $?
+            fi
             # The "v" ensures that if "configure-sampledata
             # --revision" and/or the setup above fails somehow,
             # callers like make will be looking for a file that won't