]> arthur.barton.de Git - bup.git/commit
Revert "Avoid fadvise (since it doesn't work as expected)"
authorRob Browning <rlb@defaultvalue.org>
Tue, 26 May 2015 01:55:32 +0000 (20:55 -0500)
committerRob Browning <rlb@defaultvalue.org>
Sat, 20 Jun 2015 15:24:26 +0000 (10:24 -0500)
commit42930f6c1255ca3c4b563988d03494a0be1ff5a0
treed88107f2e039cebe80bce5df020ff223832ba625
parent467bb37bb68d447ec048f63817d9bbc8c25d9b15
Revert "Avoid fadvise (since it doesn't work as expected)"

On some systems (the reported system had 2GB), not forcing out all of
the data traversed during save dramatically slows down save operations,
possibly due to competition with access to the indexes, etc.  So restore
the use of fadvise_done() for now.

This reverts commit db68c4fd4dc3087eb3f0b6e5846629cbf02d0b27.

Thanks to Tilo Schwarz for reporting the problem.

Signed-off-by: Rob Browning <rlb@defaultvalue.org>
Tested-by: Rob Browning <rlb@defaultvalue.org>
lib/bup/_helpers.c
lib/bup/hashsplit.py