DRYRUN=0
VERBOSE=0
TAG=""
+PREPOSTEXEC=1
export LC_ALL=C
default_tags=""
Usage() {
- echo "Usage: $NAME [<options>] [<system> [<system> [...]]]"
+ echo "Usage: $NAME [<options>] [<job> [<job> [...]]]"
echo
echo " -n, --dry-run Test run only, don't copy any data."
echo " -p, --progress Show progress, see rsync(1)."
echo " -t TAG, --tag TAG Only run jobs with tag TAG."
+ echo " -x, --no-exec Don't run global pre-/post-exec commands."
echo
- echo "When no <system> is given, all defined systems are used."
+ echo "When no <job> is given, all defined systems are used."
echo
+ # shellcheck disable=SC2086
echo -e $config_info
echo
exit 2
}
CleanUp() {
- if [ -n "$post_exec" ]; then
+ if [[ -n "$pre_exec" && $PREPOSTEXEC -ne 0 ]]; then
echo "Executing \"$post_exec\" ..."
- sh -c $post_exec
- if [ $? -ne 0 ]; then
+ if ! sh -c $post_exec; then
echo "Warning: post-exec command failed!"
fi
echo
GotSignal() {
echo
- echo "--> Got break signal, cleaning up & aborting ..."
+ echo "--> Got signal, cleaning up & aborting ..."
echo
CleanUp
echo -n "Aborted: "; date
case "$fs" in
"btrfs")
# Search directory of last generation, if any
+ # shellcheck disable=SC2012
last=$(ls -1d "$sys_target"/[0-9]* 2>/dev/null | sort -r | head -n1)
if [ -n "$last" ]; then
if [ ! -d "$last" ]; then
shift; TAG="$1"; shift
[ -n "$TAG" ] || Usage
;;
+ "-x"|"--no-exec")
+ PREPOSTEXEC=0; shift
+ ;;
"-"*)
Usage
;;
echo -e "$config_info"
# Check rsync and its protocol version
-rsync=$(which "rsync" 2>/dev/null)
-if [ $? -ne 0 ]; then
+if ! rsync=$(which "rsync" 2>/dev/null); then
echo "Failed to detect rsync(1)! Is it installed in your \$PATH?"
exit 1
fi
-rsync_proto=$($rsync --version 2>/dev/null | head -n 1 | sed 's/.* protocol version \([0-9]*\)$/\1/')
-if [ $? -ne 0 ]; then
+if ! rsync_proto=$($rsync --version 2>/dev/null | head -n 1 | sed 's/.* protocol version \([0-9]*\)$/\1/'); then
echo "Failed to detect protocol version of $rsync!"
exit 1
fi
[[ -n "$TAG" ]] && echo "Running jobs tagged with \"$TAG\"."
echo
-trap GotSignal SIGINT
-
if [ $# -ge 1 ]; then
for s in "$@"; do
if [ ! -r "${conf_d}/$s" ]; then
sys=("${conf_d}/"*)
fi
-if [ -n "$setup_exec" ]; then
+if [[ -n "$setup_exec" && $PREPOSTEXEC -ne 0 ]]; then
echo "Executing \"$setup_exec\" ..."
- sh -c $setup_exec
- if [ $? -ne 0 ]; then
+ if ! sh -c $setup_exec; then
echo "Error: setup command failed!"; echo
- CleanUp
echo "Aborting backup."; echo
exit 5
fi
echo
fi
+trap GotSignal SIGINT SIGTERM
+
# check and create PID file
if [ -e "$PIDFILE" ]; then
echo "Lockfile \"$PIDFILE\" already exists."
echo
exit 4
fi
-touch "$PIDFILE" 2>/dev/null
-if [ $? -ne 0 ]; then
+if ! touch "$PIDFILE" 2>/dev/null; then
echo "Warning: can't create PID file \"$PIDFILE\"!"
echo
else
echo "$$" >>"$PIDFILE"
fi
-if [ -n "$pre_exec" ]; then
+if [[ -n "$pre_exec" && $PREPOSTEXEC -ne 0 ]]; then
echo "Executing \"$pre_exec\" ..."
- sh -c $pre_exec
- if [ $? -ne 0 ]; then
+ if ! sh -c $pre_exec; then
echo "Error: pre-exec command failed!"; echo
CleanUp
echo "Aborting backup."; echo
[[ "$local" -eq 1 ]] && tags="$tags,LOCAL"
# Check tags
if [[ -n "$TAG" && "$TAG" != "ALL" ]]; then
- echo "$tags" | grep -E "(^|,)$TAG(,|$)" >/dev/null 2>&1
- if [ $? -ne 0 ]; then
+ if ! echo "$tags" | grep -E "(^|,)$TAG(,|$)" >/dev/null 2>&1; then
if [ "$DRYRUN" -ne 0 ]; then
echo "Tags of system \"$system\" don't match \"$TAG\": \"$tags\". Skipped."
echo
sys_root="$sys_target"
if [[ "$DRYRUN" -eq 0 && ! -e "$sys_target" ]]; then
if [ $generations -gt 0 ]; then
- CreateSubvolume "$sys_target"
+ CreateSubvolume "$sys_target"; r=$?
else
- mkdir -p "$sys_target"
+ mkdir -p "$sys_target"; r=$?
fi
- if [ $? -ne 0 ]; then
+ if [ $r -ne 0 ]; then
echo "Can't create \"$sys_target\"!? \"$system\" skipped!"
echo; continue
fi
if [[ "$local" -eq 0 && "$ping" -ne 0 ]]; then
# Check if system is alive
- ping -c 1 "$system" >/dev/null 2>&1
- if [ $? -ne 0 ]; then
+ if ! ping -c 1 "$system" >/dev/null 2>&1; then
echo "Host \"$system\" seems not to be alive!? Skipped."
echo; continue
fi
if [[ -n "$last" && ! -e "$last/.stamp" ]]; then
# Old backup directory without "stamp file", continue
echo "Found incomplete snapshot in \"$last\", reusing and renaming it ..."
- RenameSubvolume "$last" "$sys_target"
- if [ $? -ne 0 ]; then
+ if ! RenameSubvolume "$last" "$sys_target"; then
echo "Failed to rename last snapshot \"$last\" to \"$sys_target\"!? \"$system\" skipped!"
echo; continue
fi
$SHELL -c "$cmd"; ret=$?
end_t=$(date "+%s")
- echo "code=$ret" >"$stamp_file"
- echo "start_t=$start_t" >>"$stamp_file"
- echo "end_t=$end_t" >>"$stamp_file"
- echo "cmd='$cmd'" >>"$stamp_file"
- echo "backup_host='`hostname -f`'" >>"$stamp_file"
- echo "backup_user='`id -un`'" >>"$stamp_file"
+ {
+ echo "code=$ret"
+ echo "start_t=$start_t"
+ echo "end_t=$end_t"
+ echo "cmd='$cmd'"
+ echo "backup_host='$(hostname -f)'"
+ echo "backup_user='$(id -un)'"
+ } >"$stamp_file"
else
echo " *** Trial run, not executing save command!"
ret=0
fi
# Clean up old generations
declare -i gen_count=$generations+2
+ # shellcheck disable=SC2012
to_delete=$(ls -1t "$sys_root" 2>/dev/null | tail -n+$gen_count | sort)
if [[ -n "$to_delete" && $ok -eq 1 ]]; then
[ "$DRYRUN" -eq 0 ] \
fi
last=$(stat "$dir/.stamp" 2>/dev/null | grep "^Modify: " \
| cut -d':' -f2- | cut -d. -f1)
+ # shellcheck disable=SC2086
echo "Removing backup from" $last "..."
if [ "$DRYRUN" -eq 0 ]; then
- DeleteSubvolume "$dir"
- [ $? -eq 0 ] || \
- echo "Failed to delete \"$dir\"!"
+ DeleteSubvolume "$dir" \
+ || echo "Failed to delete \"$dir\"!"
fi
done
echo -n "Clean up finished: "; date
if [ "$DRYRUN" -eq 0 ]; then
paths=""
paths_zfs=""
+ # shellcheck disable=SC2086
for dest in $(echo $destinations | sed -e 's/ /\n/g' | sort | uniq); do
fs=$(GetFS "$dest")
case $fs in
esac
done
if [ -n "$paths" ]; then
+ # shellcheck disable=SC2086
df -h $paths
echo
fi
if [ -n "$paths_zfs" ]; then
+ # shellcheck disable=SC2086
zfs list $paths_zfs
echo
fi