backup-script: Fix two warnings of shellcheck(1)

[backup-script.git] / bin / backup-script

diff --git a/bin/backup-script b/bin/backup-script
index 395fe9e93d194f3ab60c46502c5c167648edbd4d..89b066db8bddddcabff66b15c30df1ebfd161e62 100755 (executable)
--- a/bin/backup-script
+++ b/bin/backup-script
@@ -55,7 +55,6 @@ default_tags=""
 
 # Set shell options.
 shopt -s nullglob
-set -o pipefail
 
 Usage() {
        {
@@ -76,7 +75,7 @@ Usage() {
 }
 
 ErrorMsg () {
-       printf "%s\n" "$@" >&2
+       printf "%s\\n" "$@" >&2
 }
 
 CleanUp() {
@@ -95,7 +94,7 @@ GotSignal() {
        ErrorMsg "--> Got signal, cleaning up & aborting ..."
        echo
        CleanUp
-       ErrorMsg -n "Aborted: " >&2; date
+       ErrorMsg "Aborted: $(date)" >&2
        echo
        sleep 3
        exit 9
@@ -108,7 +107,7 @@ ExecJob() {
        echo "Running job ${what}-exec command ..."
        [ "$local" -eq 0 ] \
                && cmd="$ssh_cmd ${user}@${system} $cmd"
-       echo -n "Start date (${what}-exec): "; date
+       echo "Start date (${what}-exec): $(date)"
        echo "$cmd"
        if [ "$DRYRUN" -eq 0 ]; then
                $SHELL -c "$cmd"; local ret=$?
@@ -304,7 +303,7 @@ if [ -r "$conf" ]; then
 else
        config_info="${config_info} (not readable, using defaults)"
 fi
-config_info="${config_info},\nusing \"$conf_d\" as configuration directory."
+config_info="${config_info},\\nusing \"$conf_d\" as configuration directory."
 
 while [ $# -gt 0 ]; do
        case "$1" in
@@ -329,7 +328,7 @@ while [ $# -gt 0 ]; do
        esac
 done
 
-echo -n "Started: "; date
+echo "Started: $(date)"
 echo -e "$config_info"
 
 # Check rsync and its protocol version
@@ -376,7 +375,7 @@ if [ -e "$PIDFILE" ]; then
        ErrorMsg "Lockfile \"$PIDFILE\" already exists."
        ErrorMsg "Is an other instance still running?"
        echo
-       ErrorMsg -n "Aborted: " >&2; date
+       ErrorMsg "Aborted: $(date)" >&2
        echo
        exit 4
 fi
@@ -658,7 +657,7 @@ for f in "${sys[@]}"; do
        fi
 
        echo "Backing up to \"$sys_target\" ..."
-       echo -n "Start date: "; date
+       echo "Start date: $(date)"
        echo "$cmd"
        count_started=$count_started+1
        ok=0
@@ -690,7 +689,7 @@ for f in "${sys[@]}"; do
                GotSignal
        fi
 
-       echo -n "End date: "; date
+       echo "End date: $(date)"
        if [[ $ret -eq 0 || $ret -eq 24 ]]; then
                [ $ret -eq 24 ] && count_ok_vanished=$count_ok_vanished+1
 
@@ -735,7 +734,7 @@ for f in "${sys[@]}"; do
                                                || ErrorMsg "Failed to delete \"$dir\" of \"$system\"!"
                                fi
                        done
-                       echo -n "Clean up finished: "; date
+                       echo "Clean up finished: $(date)"
                elif [ -n "$to_delete" ]; then
                        ErrorMsg "There have been errors for \"$system\", not cleaning up old generations!"
                else
@@ -777,7 +776,7 @@ fi
 
 CleanUp
 
-echo -n "Done: "; date
+echo "Done: $(date)"
 echo
 [ $count_all -eq 1 ] && s="" || s="s"
 [ $count_enabled -eq $count_all ] \