From 64b6ec39e6269d93c0c7f7f19a6e5adc75cfaae8 Mon Sep 17 00:00:00 2001
From: Alexander Barton <alex@barton.de>
Date: Wed, 11 Nov 2015 16:09:29 +0100
Subject: [PATCH] Split off "apt-base" from "debian-base"; introduce
 "ubuntu-base"

All these roles are dependencies of "os-base", don't reference them
directly from other roles!
---
 .../handlers/main.yml                         |  0
 roles/apt-base/tasks/main.yml                 | 53 +++++++++++++++++++
 roles/debian-base/tasks/main.yml              | 53 +------------------
 roles/os-base/meta/main.yml                   |  2 +
 roles/ubuntu-base/tasks/main.yml              | 28 ++++++++++
 5 files changed, 84 insertions(+), 52 deletions(-)
 rename roles/{debian-base => apt-base}/handlers/main.yml (100%)
 create mode 100644 roles/apt-base/tasks/main.yml
 create mode 100644 roles/ubuntu-base/tasks/main.yml

diff --git a/roles/debian-base/handlers/main.yml b/roles/apt-base/handlers/main.yml
similarity index 100%
rename from roles/debian-base/handlers/main.yml
rename to roles/apt-base/handlers/main.yml
diff --git a/roles/apt-base/tasks/main.yml b/roles/apt-base/tasks/main.yml
new file mode 100644
index 0000000..b09fba5
--- /dev/null
+++ b/roles/apt-base/tasks/main.yml
@@ -0,0 +1,53 @@
+---
+# tasks file for apt
+
+- name: 'apt(8): Disable "package diffs"'
+  tags:
+    - apt
+    - packages
+  lineinfile: >
+    create=yes
+    dest=/etc/apt/apt.conf
+    group=root
+    line='Acquire::PDiffs "false";'
+    mode=644
+    owner=root
+
+- name: "aptitude(8): Don't install recommended packages by default"
+  tags:
+    - apt
+    - packages
+  lineinfile: >
+    create=yes
+    dest=/root/.aptitude/config
+    group=root
+    line='Apt::Install-Recommends "false";'
+    owner=root
+
+- name: update APT repositories (when outdated)
+  tags:
+    - apt
+    - packages
+  apt: >
+    update_cache=yes
+    cache_valid_time=3600
+
+- name: configure debconf(1) frontend
+  tags:
+    - debconf
+    - packages
+  debconf: >
+    name=debconf
+    question=debconf/frontend
+    value=Dialog
+    vtype=select
+
+- name: configure debconf(1) priority
+  tags:
+    - debconf
+    - packages
+  debconf: >
+    name=debconf
+    question=debconf/priority
+    value=low
+    vtype=select
diff --git a/roles/debian-base/tasks/main.yml b/roles/debian-base/tasks/main.yml
index 326bb6c..91fbd1f 100644
--- a/roles/debian-base/tasks/main.yml
+++ b/roles/debian-base/tasks/main.yml
@@ -1,56 +1,5 @@
 ---
-# debian-base tasks
-
-- name: 'apt(8): Disable "package diffs"'
-  tags:
-    - apt
-    - packages
-  lineinfile: >
-    create=yes
-    dest=/etc/apt/apt.conf
-    group=root
-    line='Acquire::PDiffs "false";'
-    mode=644
-    owner=root
-
-- name: "aptitude(8): Don't install recommended packages by default"
-  tags:
-    - apt
-    - packages
-  lineinfile: >
-    create=yes
-    dest=/root/.aptitude/config
-    group=root
-    line='Apt::Install-Recommends "false";'
-    owner=root
-
-- name: update APT repositories (when outdated)
-  tags:
-    - apt
-    - packages
-  apt: >
-    update_cache=yes
-    cache_valid_time=3600
-
-- name: configure debconf(1) frontend
-  tags:
-    - debconf
-    - packages
-  debconf: >
-    name=debconf
-    question=debconf/frontend
-    value=Dialog
-    vtype=select
-
-- name: configure debconf(1) priority
-  tags:
-    - debconf
-    - packages
-  debconf: >
-    name=debconf
-    question=debconf/priority
-    value=low
-    vtype=select
+# tasks file for debian-base
 
 - name: install common packages
   tags:
diff --git a/roles/os-base/meta/main.yml b/roles/os-base/meta/main.yml
index 41b1ea3..1a24bfc 100644
--- a/roles/os-base/meta/main.yml
+++ b/roles/os-base/meta/main.yml
@@ -2,4 +2,6 @@
 # meta file for os-base
 
 dependencies:
+  - { role: apt-base, when: "ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'"}
   - { role: debian-base, when: "ansible_distribution == 'Debian'" }
+  - { role: ubuntu-base, when: "ansible_distribution == 'Ubuntu'" }
diff --git a/roles/ubuntu-base/tasks/main.yml b/roles/ubuntu-base/tasks/main.yml
new file mode 100644
index 0000000..50a8ac7
--- /dev/null
+++ b/roles/ubuntu-base/tasks/main.yml
@@ -0,0 +1,28 @@
+---
+# tasks file for ubuntu-base
+
+- name: install common packages
+  tags:
+    - packages
+  apt: >
+    state=installed
+    name={{ item }}
+  with_items:
+    - bash-completion
+    - busybox-static
+    - ca-certificates
+    - curl
+    - debconf-utils
+    - etckeeper
+    - git
+    - htop
+    - less
+    - linux-image-generic
+    - lsb-base
+    - lsb-release
+    - psmisc
+    - net-tools
+    - screen
+    - sudo
+    - telnet-ssl
+    - vim
-- 
2.39.2