From: Frank Lahm <franklahm@googlemail.com>
Date: Thu, 13 Oct 2011 09:59:38 +0000 (+0200)
Subject: Check for empty EA slots and fix log messag missing parameter
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cea5233c2f942bb5c90612d0c313b3c91fa7d476;p=netatalk.git

Check for empty EA slots and fix log messag missing parameter
---

diff --git a/libatalk/vfs/ea.c b/libatalk/vfs/ea.c
index fa3a0109..abe266fe 100644
--- a/libatalk/vfs/ea.c
+++ b/libatalk/vfs/ea.c
@@ -514,13 +514,15 @@ static int ea_delentry(struct ea * restrict ea, const char * restrict attruname)
     unsigned int count = 0;
 
     if (ea->ea_count == 0) {
-        LOG(log_error, logtype_afpd, "ea_delentry('%s'): illegal ea_count of 0 on deletion");
+        LOG(log_error, logtype_afpd, "ea_delentry('%s'): illegal ea_count of 0 on deletion",
+            attruname);
         return -1;
     }
 
     while (count < ea->ea_count) {
         /* search matching EA */
-        if (strcmp(attruname, (*ea->ea_entries)[count].ea_name) == 0) {
+        if ((*ea->ea_entries)[count].ea_name &&
+            strcmp(attruname, (*ea->ea_entries)[count].ea_name) == 0) {
             free((*ea->ea_entries)[count].ea_name);
             (*ea->ea_entries)[count].ea_name = NULL;