From: Costa Tsaousis (ktsaou) <costa@tsaousis.gr>
Date: Sat, 22 Oct 2016 23:31:35 +0000 (+0300)
Subject: minor optimizations at diskstats
X-Git-Tag: v1.5.0~226^2~1
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=13da861a81b48d7828ca27a12ff817b2be40371b;p=netdata.git

minor optimizations at diskstats
---

diff --git a/src/proc_diskstats.c b/src/proc_diskstats.c
index 96cece6c..85da496a 100644
--- a/src/proc_diskstats.c
+++ b/src/proc_diskstats.c
@@ -260,13 +260,13 @@ static struct disk *get_disk(unsigned long major, unsigned long minor, char *dis
 
     // mountinfo_find() can be called with NULL disk_mountinfo_root
     struct mountinfo *mi = mountinfo_find(disk_mountinfo_root, d->major, d->minor);
-    if(unlikely(!mi)) {
+/*    if(unlikely(!mi)) {
         mountinfo_reload(1);
 
         // search again for this disk
         mi = mountinfo_find(disk_mountinfo_root, d->major, d->minor);
     }
-
+*/
     if(mi) {
         d->mount_point = strdupz(mi->mount_point);
         d->mount_point_hash = mi->mount_point_hash;
@@ -770,14 +770,14 @@ int do_proc_diskstats(int update_every, unsigned long long dt) {
             }
         }
 
-        /*
+/*
         // --------------------------------------------------------------------------
         // space metrics
 
         if(d->mount_point && (d->do_space || d->do_inodes) ) {
             do_disk_space_stats(d, d->mount_point, disk, disk, family, update_every, dt);
         }
-        */
+*/
     }
 
     // --------------------------------------------------------------------------
@@ -785,10 +785,10 @@ int do_proc_diskstats(int update_every, unsigned long long dt) {
 
     struct mountinfo *mi;
     for(mi = disk_mountinfo_root; mi ;mi = mi->next) {
-        if(unlikely(mi->flags & MOUNTINFO_IS_DUMMY || mi->flags & MOUNTINFO_IS_BIND || mi->flags & MOUNTINFO_IS_SAME_DEV || mi->flags & MOUNTINFO_NO_STAT || mi->flags & MOUNTINFO_NO_SIZE))
+        if(unlikely(mi->flags & (MOUNTINFO_IS_DUMMY|MOUNTINFO_IS_BIND|MOUNTINFO_IS_SAME_DEV|MOUNTINFO_NO_STAT|MOUNTINFO_NO_SIZE)))
             continue;
 
-        /*
+/*
         // skip the ones with block devices
         int skip = 0;
         struct disk *d;
@@ -801,9 +801,10 @@ int do_proc_diskstats(int update_every, unsigned long long dt) {
 
         if(unlikely(skip))
             continue;
-        */
 
         // fprintf(stderr, "Will process mount point '%s', source '%s', filesystem '%s'\n", mi->mount_point, mi->mount_source, mi->filesystem);
+*/
+
         do_disk_space_stats(NULL, mi->mount_point, mi->mount_source, mi->persistent_id, mi->mount_point , update_every, dt);
     }
 
diff --git a/src/proc_self_mountinfo.c b/src/proc_self_mountinfo.c
index 3c3e5af8..22be1aa6 100644
--- a/src/proc_self_mountinfo.c
+++ b/src/proc_self_mountinfo.c
@@ -343,7 +343,7 @@ struct mountinfo *mountinfo_read() {
 */
     }
 
-/*
+/* find if the mount options have "bind" in them
     {
         FILE *fp = setmntent(MOUNTED, "r");
         if (fp != NULL) {