X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=etc%2Fafpd%2Fvolume.c;h=81981e01c6604a3d219459f88cad896491f94f62;hb=b51fd284f832491044798e610263a5c622d02d1f;hp=6d7799176b8e61b2b39f16a5a7b02a2f51ebc98a;hpb=9753ac7c67d4871ea344993538b08c3850ad12e7;p=netatalk.git diff --git a/etc/afpd/volume.c b/etc/afpd/volume.c index 6d779917..81981e01 100644 --- a/etc/afpd/volume.c +++ b/etc/afpd/volume.c @@ -1,5 +1,5 @@ /* - * $Id: volume.c,v 1.86 2009-04-28 13:01:24 franklahm Exp $ + * $Id: volume.c,v 1.102 2009-11-13 00:27:36 didg Exp $ * * Copyright (c) 1990,1993 Regents of The University of Michigan. * All Rights Reserved. See COPYRIGHT. @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -45,6 +44,7 @@ char *strchr (), *strrchr (); #include #include #include +#include #ifdef CNID_DB #include #endif /* CNID_DB*/ @@ -56,6 +56,7 @@ char *strchr (), *strrchr (); #include "unix.h" #include "mangle.h" #include "fork.h" +#include "hash.h" extern int afprun(int root, char *cmd, int *outfd); @@ -125,6 +126,7 @@ m=u -> map both ways #define VOLOPT_DPERM 24 /* dperm default directories perms */ #define VOLOPT_FPERM 25 /* fperm default files perms */ #define VOLOPT_DFLTPERM 26 /* perm */ +#define VOLOPT_EA_VFS 27 /* Extended Attributes vfs indirection */ #define VOLOPT_MAX (VOLOPT_DFLTPERM +1) @@ -133,10 +135,11 @@ m=u -> map both ways #define VOLPASSLEN 8 #define VOLOPT_DEFAULT ":DEFAULT:" #define VOLOPT_DEFAULT_LEN 9 - struct vol_option { - char *c_value; - int i_value; - }; + +struct vol_option { + char *c_value; + int i_value; +}; typedef struct _special_folder { const char *name; @@ -180,9 +183,9 @@ static const _vol_opt_name vol_opt_names[] = { {AFPVOL_NODEV, "NODEV"}, /* always use 0 for device number in cnid calls */ {AFPVOL_CASEINSEN, "CASEINSENSITIVE"}, /* volume is case insensitive */ {AFPVOL_EILSEQ, "ILLEGALSEQ"}, /* encode illegal sequence */ - {AFPVOL_CACHE, "CACHEID"}, /* Use adouble v2 CNID caching, default don't use it */ - {AFPVOL_EXT_ATTRS, "EXT_ATTRS"}, /* Vol supports Extened Attributes */ + {AFPVOL_CACHE, "CACHEID"}, /* Use adouble v2 CNID caching. Default: yes */ {AFPVOL_ACLS, "ACLS"}, /* Vol supports ACLs */ + {AFPVOL_TM, "TM"}, /* Set "kSupportsTMLockSteal" is volume attributes */ {0, NULL} }; @@ -239,7 +242,8 @@ static void volfree(struct vol_option *options, static char *volxlate(AFPObj *obj, char *dest, size_t destlen, char *src, struct passwd *pwd, char *path, char *volname) { - char *p, *q; + char *p, *r; + const char *q; int len; char *ret; @@ -285,17 +289,17 @@ static char *volxlate(AFPObj *obj, char *dest, size_t destlen, } else if (obj->proto == AFPPROTO_DSI) { DSI *dsi = obj->handle; - - len = sprintf(dest, "%s:%u", inet_ntoa(dsi->client.sin_addr), - ntohs(dsi->client.sin_port)); + len = sprintf(dest, "%s:%u", + getip_string((struct sockaddr *)&dsi->client), + getip_port((struct sockaddr *)&dsi->client)); dest += len; destlen -= len; } } else if (is_var(p, "$d")) { q = path; } else if (is_var(p, "$f")) { - if ((q = strchr(pwd->pw_gecos, ','))) - *q = '\0'; + if ((r = strchr(pwd->pw_gecos, ','))) + *r = '\0'; q = pwd->pw_gecos; } else if (is_var(p, "$g")) { struct group *grp = getgrgid(pwd->pw_gid); @@ -313,9 +317,8 @@ static char *volxlate(AFPObj *obj, char *dest, size_t destlen, } else if (obj->proto == AFPPROTO_DSI) { DSI *dsi = obj->handle; - - q = inet_ntoa(dsi->client.sin_addr); - } + q = getip_string((struct sockaddr *)&dsi->client); + } } else if (is_var(p, "$s")) { if (obj->Obj) q = obj->Obj; @@ -447,8 +450,6 @@ static void volset(struct vol_option *options, struct vol_option *save, options[VOLOPT_ADOUBLE].i_value = AD_VERSION2; else if (strcasecmp(val + 1, "osx") == 0) options[VOLOPT_ADOUBLE].i_value = AD_VERSION2_OSX; - else if (strcasecmp(val + 1, "ads") == 0) - options[VOLOPT_ADOUBLE].i_value = AD_VERSION1_ADS; else if (strcasecmp(val + 1, "sfm") == 0) options[VOLOPT_ADOUBLE].i_value = AD_VERSION1_SFM; #endif @@ -492,8 +493,6 @@ static void volset(struct vol_option *options, struct vol_option *save, options[VOLOPT_ROOTPREEXEC].i_value = 1; else if (strcasecmp(p, "upriv") == 0) options[VOLOPT_FLAGS].i_value |= AFPVOL_UNIX_PRIV; - else if (strcasecmp(p, "extattrs") == 0) - options[VOLOPT_FLAGS].i_value |= AFPVOL_EXT_ATTRS; else if (strcasecmp(p, "acls") == 0) options[VOLOPT_FLAGS].i_value |= AFPVOL_ACLS; else if (strcasecmp(p, "nodev") == 0) @@ -502,8 +501,10 @@ static void volset(struct vol_option *options, struct vol_option *save, options[VOLOPT_FLAGS].i_value |= AFPVOL_CASEINSEN; else if (strcasecmp(p, "illegalseq") == 0) options[VOLOPT_FLAGS].i_value |= AFPVOL_EILSEQ; - else if (strcasecmp(p, "cachecnid") == 0) - options[VOLOPT_FLAGS].i_value |= AFPVOL_CACHE; + else if (strcasecmp(p, "nocnidcache") == 0) + options[VOLOPT_FLAGS].i_value &= ~AFPVOL_CACHE; + else if (strcasecmp(p, "tm") == 0) + options[VOLOPT_FLAGS].i_value |= AFPVOL_TM; p = strtok(NULL, ","); } @@ -552,6 +553,12 @@ static void volset(struct vol_option *options, struct vol_option *save, } else if (optionok(tmp, "denied_hosts:", val)) { setoption(options, save, VOLOPT_DENIED_HOSTS, val); + } else if (optionok(tmp, "ea:", val)) { + if (strcasecmp(val + 1, "ad") == 0) /* the default anyway */ + options[VOLOPT_EA_VFS].i_value = AFPVOL_EA_AD; + else if (strcasecmp(val + 1, "solaris") == 0) + options[VOLOPT_EA_VFS].i_value = AFPVOL_EA_SOLARIS; + } else { /* ignore unknown options */ LOG(log_debug, logtype_afpd, "ignoring unknown volume option: %s", tmp); @@ -705,6 +712,7 @@ static int creatvol(AFPObj *obj, struct passwd *pwd, /* os X start at 1 and use network order ie. 1 2 3 */ volume->v_vid = ++lastvid; volume->v_vid = htons(volume->v_vid); + volume->v_vfs_ea = AFPVOL_EA_AD; /* handle options */ if (options) { @@ -713,6 +721,9 @@ static int creatvol(AFPObj *obj, struct passwd *pwd, /* shift in some flags */ volume->v_flags = options[VOLOPT_FLAGS].i_value; + + if (options[VOLOPT_EA_VFS].i_value != AFPVOL_EA_AD) + volume->v_vfs_ea = options[VOLOPT_EA_VFS].i_value; volume->v_ad_options = 0; if ((volume->v_flags & AFPVOL_NODEV)) @@ -759,7 +770,32 @@ static int creatvol(AFPObj *obj, struct passwd *pwd, else volume->v_adouble = AD_VERSION; + /* Mac to Unix conversion flags*/ + volume->v_mtou_flags = 0; + if (!(volume->v_flags & AFPVOL_NOHEX)) + volume->v_mtou_flags |= CONV_ESCAPEHEX; + if (!(volume->v_flags & AFPVOL_USEDOTS)) + volume->v_mtou_flags |= CONV_ESCAPEDOTS; + if ((volume->v_flags & AFPVOL_EILSEQ)) + volume->v_mtou_flags |= CONV__EILSEQ; + + if ((volume->v_casefold & AFPVOL_MTOUUPPER)) + volume->v_mtou_flags |= CONV_TOUPPER; + else if ((volume->v_casefold & AFPVOL_MTOULOWER)) + volume->v_mtou_flags |= CONV_TOLOWER; + + /* Unix to Mac conversion flags*/ + volume->v_utom_flags = CONV_IGNORE | CONV_UNESCAPEHEX; + if ((volume->v_casefold & AFPVOL_UTOMUPPER)) + volume->v_utom_flags |= CONV_TOUPPER; + else if ((volume->v_casefold & AFPVOL_UTOMLOWER)) + volume->v_utom_flags |= CONV_TOLOWER; + + if ((volume->v_flags & AFPVOL_EILSEQ)) + volume->v_utom_flags |= CONV__EILSEQ; + initvol_vfs(volume); + #ifdef FORCE_UIDGID if (options[VOLOPT_FORCEUID].c_value) { volume->v_forceuid = strdup(options[VOLOPT_FORCEUID].c_value); @@ -798,10 +834,7 @@ static int creatvol(AFPObj *obj, struct passwd *pwd, } /* ---------------- */ -static char *myfgets( buf, size, fp ) -char *buf; -int size; -FILE *fp; +static char *myfgets( char *buf, int size, FILE *fp) { char *p; int c; @@ -853,9 +886,7 @@ FILE *fp; #endif -static int accessvol(args, name) -const char *args; -const char *name; +static int accessvol(const char *args, const char *name) { char buf[MAXPATHLEN + 1], *p; struct group *gr; @@ -879,14 +910,12 @@ const char *name; return 0; } -static int hostaccessvol(type, volname, args, obj) -int type; -char *volname; -const char *args; -const AFPObj *obj; +static int hostaccessvol(int type, const char *volname, const char *args, const AFPObj *obj) { + int mask_int; char buf[MAXPATHLEN + 1], *p, *b; DSI *dsi = obj->handle; + struct sockaddr_storage client; if (!args) return -1; @@ -895,42 +924,61 @@ const AFPObj *obj; if ((p = strtok_r(buf, ",", &b)) == NULL) /* nothing, return okay */ return -1; + if (obj->proto != AFPPROTO_DSI) + return -1; + while (p) { - if (obj->proto == AFPPROTO_DSI) { - struct in_addr mask, net; - char *net_char, *mask_char; - int mask_int; - - net_char = strtok(p, "/"); - mask_char = strtok(NULL,"/"); - if (mask_char == NULL) { + int ret; + char *ipaddr, *mask_char; + struct addrinfo hints, *ai; + + ipaddr = strtok(p, "/"); + mask_char = strtok(NULL,"/"); + + /* Get address from string with getaddrinfo */ + memset(&hints, 0, sizeof hints); + hints.ai_family = AF_UNSPEC; + hints.ai_socktype = SOCK_STREAM; + if ((ret = getaddrinfo(ipaddr, NULL, &hints, &ai)) != 0) { + LOG(log_error, logtype_afpd, "hostaccessvol: getaddrinfo: %s\n", gai_strerror(ret)); + continue; + } + + /* netmask */ + if (mask_char != NULL) + mask_int = atoi(mask_char); /* apply_ip_mask does range checking on it */ + else { + if (ai->ai_family == AF_INET) /* IPv4 */ mask_int = 32; - } else { - mask_int = atoi(mask_char); - } - - // convert the integer netmask to a bitmask in network order - mask.s_addr = htonl(-1 - ((1 << (32 - mask_int)) - 1)); - net.s_addr = inet_addr(net_char) & mask.s_addr; - - if ((dsi->client.sin_addr.s_addr & mask.s_addr) == net.s_addr) { - if (type == VOLOPT_DENIED_HOSTS) - LOG(log_info, logtype_afpd, "AFP access denied for client IP '%s' to volume '%s' by denied list", - inet_ntoa(dsi->client.sin_addr), volname); - return 1; - } + else /* IPv6 */ + mask_int = 128; } + + /* Apply mask to addresses */ + client = dsi->client; + apply_ip_mask((struct sockaddr *)&client, mask_int); + apply_ip_mask(ai->ai_addr, mask_int); + + if (compare_ip((struct sockaddr *)&client, ai->ai_addr) == 0) { + if (type == VOLOPT_DENIED_HOSTS) + LOG(log_info, logtype_afpd, "AFP access denied for client IP '%s' to volume '%s' by denied list", + getip_string((struct sockaddr *)&client), volname); + freeaddrinfo(ai); + return 1; + } + + /* next address */ + freeaddrinfo(ai); p = strtok_r(NULL, ",", &b); } + if (type == VOLOPT_ALLOWED_HOSTS) - LOG(log_info, logtype_afpd, "AFP access denied for client IP '%s' to volume '%s', not in allowed list", - inet_ntoa(dsi->client.sin_addr), volname); + LOG(log_info, logtype_afpd, "AFP access denied for client IP '%s' to volume '%s', not in allowed list", + getip_string((struct sockaddr *)&dsi->client), volname); return 0; } -static void setextmap( ext, type, creator, user) -char *ext, *type, *creator; -int user; +static void setextmap(char *ext, char *type, char *creator, int user) { struct extmap *em; int cnt; @@ -1056,12 +1104,7 @@ static int volfile_changed(struct afp_volume_name *p) * [codepage:] [casefold:] * TYPE [CREATOR] */ -static int readvolfile(obj, p1, p2, user, pwent) -AFPObj *obj; -struct afp_volume_name *p1; -char *p2; -int user; -struct passwd *pwent; +static int readvolfile(AFPObj *obj, struct afp_volume_name *p1, char *p2, int user, struct passwd *pwent) { FILE *fp; char path[ MAXPATHLEN + 1], tmp[ MAXPATHLEN + 1], @@ -1096,6 +1139,10 @@ struct passwd *pwent; } memset(save_options, 0, sizeof(save_options)); + + /* Enable some default options for all volumes */ + save_options[VOLOPT_FLAGS].i_value |= AFPVOL_CACHE; + while ( myfgets( buf, sizeof( buf ), fp ) != NULL ) { initline( strlen( buf ), buf ); parseline( sizeof( path ) - 1, path ); @@ -1183,9 +1230,9 @@ struct passwd *pwent; allow -> either no list (-1), or in list (1) deny -> either no list (-1), or not in list (0) */ if (accessvol(options[VOLOPT_ALLOW].c_value, obj->username) && - (accessvol(options[VOLOPT_DENY].c_value, obj->username) < 1) && - hostaccessvol(VOLOPT_ALLOWED_HOSTS, volname, options[VOLOPT_ALLOWED_HOSTS].c_value, obj) && - (hostaccessvol(VOLOPT_DENIED_HOSTS, volname, options[VOLOPT_DENIED_HOSTS].c_value, obj) < 1)) { + (accessvol(options[VOLOPT_DENY].c_value, obj->username) < 1) && + hostaccessvol(VOLOPT_ALLOWED_HOSTS, volname, options[VOLOPT_ALLOWED_HOSTS].c_value, obj) && + (hostaccessvol(VOLOPT_DENIED_HOSTS, volname, options[VOLOPT_DENIED_HOSTS].c_value, obj) < 1)) { /* handle read-only behaviour. semantics: * 1) neither the rolist nor the rwlist exist -> rw @@ -1302,10 +1349,9 @@ struct vol *vol, *ovol, *nvol; } } -static int getvolspace( vol, bfree, btotal, xbfree, xbtotal, bsize ) -struct vol *vol; -u_int32_t *bfree, *btotal, *bsize; -VolSpace *xbfree, *xbtotal; +static int getvolspace(struct vol *vol, + u_int32_t *bfree, u_int32_t *btotal, + VolSpace *xbfree, VolSpace *xbtotal, u_int32_t *bsize) { int spaceflag, rc; u_int32_t maxsize; @@ -1375,12 +1421,7 @@ static void vol_setdate(u_int16_t id, struct adouble *adp, time_t date) } /* ----------------------- */ -static int getvolparams( bitmap, vol, st, buf, buflen ) -u_int16_t bitmap; -struct vol *vol; -struct stat *st; -char *buf; -int *buflen; +static int getvolparams( u_int16_t bitmap, struct vol *vol, struct stat *st, char *buf, size_t *buflen) { struct adouble ad; int bit = 0, isad = 1; @@ -1427,7 +1468,7 @@ int *buflen; (1<= 30) { ashort |= VOLPBIT_ATTR_UTF8; - if (vol->v_flags & AFPVOL_UNIX_PRIV) - ashort |= VOLPBIT_ATTR_UNIXPRIV; + if (vol->v_flags & AFPVOL_UNIX_PRIV) + ashort |= VOLPBIT_ATTR_UNIXPRIV; + if (vol->v_flags & AFPVOL_TM) + ashort |= VOLPBIT_ATTR_TM; } if (afp_version >= 32) { - if (vol->v_flags & AFPVOL_EXT_ATTRS) - ashort |= VOLPBIT_ATTR_EXT_ATTRS; if (vol->v_flags & AFPVOL_ACLS) - ashort |= VOLPBIT_ATTR_ACLS; + ashort |= VOLPBIT_ATTR_ACLS; } ashort = htons(ashort); memcpy(data, &ashort, sizeof( ashort )); @@ -1582,10 +1624,11 @@ int *buflen; } /* ------------------------- */ -static int stat_vol(u_int16_t bitmap, struct vol *vol, char *rbuf, int *rbuflen) +static int stat_vol(u_int16_t bitmap, struct vol *vol, char *rbuf, size_t *rbuflen) { struct stat st; - int buflen, ret; + int ret; + size_t buflen; if ( stat( vol->v_path, &st ) < 0 ) { *rbuflen = 0; @@ -1676,10 +1719,7 @@ void load_volumes(AFPObj *obj) } /* ------------------------------- */ -int afp_getsrvrparms(obj, ibuf, ibuflen, rbuf, rbuflen ) -AFPObj *obj; -char *ibuf _U_, *rbuf; -int ibuflen _U_, *rbuflen; +int afp_getsrvrparms(AFPObj *obj, char *ibuf _U_, size_t ibuflen _U_, char *rbuf, size_t *rbuflen) { struct timeval tv; struct stat st; @@ -1742,7 +1782,7 @@ int ibuflen _U_, *rbuflen; *rbuflen = data - rbuf; data = rbuf; - if ( gettimeofday( &tv, 0 ) < 0 ) { + if ( gettimeofday( &tv, NULL ) < 0 ) { LOG(log_error, logtype_afpd, "afp_getsrvrparms(%s): gettimeofday: %s", volume->v_path, strerror(errno) ); *rbuflen = 0; return AFPERR_PARAM; @@ -1757,10 +1797,7 @@ int ibuflen _U_, *rbuflen; /* ------------------------- * we are the user here */ -int afp_openvol(obj, ibuf, ibuflen, rbuf, rbuflen ) -AFPObj *obj; -char *ibuf, *rbuf; -int ibuflen _U_, *rbuflen; +int afp_openvol(AFPObj *obj, char *ibuf, size_t ibuflen _U_, char *rbuf, size_t *rbuflen) { struct stat st; char *volname; @@ -1774,7 +1811,8 @@ int ibuflen _U_, *rbuflen; char *vol_uname; char *vol_mname; char *volname_tmp; - + struct charset_functions *charset; + ibuf += 2; memcpy(&bitmap, ibuf, sizeof( bitmap )); bitmap = ntohs( bitmap ); @@ -1912,13 +1950,13 @@ int ibuflen _U_, *rbuflen; dir->d_color = DIRTREE_COLOR_BLACK; /* root node is black */ dir->d_m_name_ucs2 = strdup_w(volume->v_name); volume->v_dir = volume->v_root = dir; + volume->v_curdir = NULL; volume->v_hash = dirhash(); curdir = volume->v_dir; if (volume->v_cnidscheme == NULL) { volume->v_cnidscheme = strdup(DEFAULT_CNID_SCHEME); - LOG(log_warning, logtype_afpd, "Warning: No CNID scheme for volume %s. Using default.", - volume->v_path); + LOG(log_info, logtype_afpd, "Volume %s use CNID scheme %s.", volume->v_path, volume->v_cnidscheme); } if (volume->v_dbpath) volume->v_cdb = cnid_open (volume->v_dbpath, volume->v_umask, volume->v_cnidscheme, (volume->v_flags & AFPVOL_NODEV)); @@ -1942,7 +1980,7 @@ int ibuflen _U_, *rbuflen; goto openvol_err; } - if ( NULL == ( volume->v_vol = find_charset_functions(volume->v_volcodepage)) || volume->v_vol->flags & CHARSET_ICONV ) { + if ( NULL == (charset = find_charset_functions(volume->v_volcodepage)) || charset->flags & CHARSET_ICONV ) { LOG (log_warning, logtype_afpd, "WARNING: volume encoding %s is *not* supported by netatalk, expect problems !!!!", volume->v_volcodepage); } @@ -1955,11 +1993,12 @@ int ibuflen _U_, *rbuflen; goto openvol_err; } - if ( NULL == ( volume->v_mac = find_charset_functions(volume->v_maccodepage)) || ! (volume->v_mac->flags & CHARSET_CLIENT) ) { + if ( NULL == ( charset = find_charset_functions(volume->v_maccodepage)) || ! (charset->flags & CHARSET_CLIENT) ) { LOG (log_error, logtype_afpd, "Fatal error: mac charset %s not supported", volume->v_maccodepage); ret = AFPERR_MISC; goto openvol_err; - } + } + volume->v_kTextEncoding = htonl(charset->kTextEncoding); ret = stat_vol(bitmap, volume, rbuf, rbuflen); if (ret == AFP_OK) { @@ -2074,10 +2113,7 @@ static void deletevol(struct vol *vol) } /* ------------------------- */ -int afp_closevol(obj, ibuf, ibuflen, rbuf, rbuflen ) -AFPObj *obj _U_; -char *ibuf, *rbuf _U_; -int ibuflen _U_, *rbuflen; +int afp_closevol(AFPObj *obj _U_, char *ibuf, size_t ibuflen _U_, char *rbuf _U_, size_t *rbuflen) { struct vol *vol; u_int16_t vid; @@ -2127,11 +2163,11 @@ struct extmap *getextmap(const char *path) char *p; struct extmap *em; - if (NULL == ( p = strrchr( path, '.' )) ) { + if (!Extmap_cnt || NULL == ( p = strrchr( path, '.' )) ) { return( Defextmap ); } p++; - if (!*p || !Extmap_cnt) { + if (!*p) { return( Defextmap ); } em = bsearch(p, Extmap, Extmap_cnt, sizeof(struct extmap), ext_cmp_key); @@ -2150,9 +2186,18 @@ struct extmap *getdefextmap(void) /* -------------------------- poll if a volume is changed by other processes. + return + 0 no attention msg sent + 1 attention msg sent + -1 error (socket closed) + + Note: if attention return -1 no packet has been + sent because the buffer is full, we don't care + either there's no reader or there's a lot of + traffic and another pollvoltime will follow */ -int pollvoltime(obj) -AFPObj *obj; +int pollvoltime(AFPObj *obj) + { struct vol *vol; struct timeval tv; @@ -2161,7 +2206,7 @@ AFPObj *obj; if (!(afp_version > 21 && obj->options.server_notif)) return 0; - if ( gettimeofday( &tv, 0 ) < 0 ) + if ( gettimeofday( &tv, NULL ) < 0 ) return 0; for ( vol = Volumes; vol; vol = vol->v_next ) { @@ -2178,9 +2223,7 @@ AFPObj *obj; } /* ------------------------- */ -void setvoltime(obj, vol ) -AFPObj *obj; -struct vol *vol; +void setvoltime(AFPObj *obj, struct vol *vol) { struct timeval tv; @@ -2190,7 +2233,7 @@ struct vol *vol; * the afpd processes would come closer) * [RS] */ - if ( gettimeofday( &tv, 0 ) < 0 ) { + if ( gettimeofday( &tv, NULL ) < 0 ) { LOG(log_error, logtype_afpd, "setvoltime(%s): gettimeofday: %s", vol->v_path, strerror(errno) ); return; } @@ -2203,7 +2246,9 @@ struct vol *vol; /* a little granularity */ if (vol->v_mtime < tv.tv_sec) { vol->v_mtime = tv.tv_sec; - /* or finder doesn't update free space */ + /* or finder doesn't update free space + * XXX is it still true with newer OSX? + */ if (afp_version > 21 && obj->options.server_notif) { obj->attention(obj->handle, AFPATTN_NOTIFY | AFPATTN_VOLCHANGED); } @@ -2211,10 +2256,7 @@ struct vol *vol; } /* ------------------------- */ -int afp_getvolparams(obj, ibuf, ibuflen, rbuf, rbuflen ) -AFPObj *obj _U_; -char *ibuf, *rbuf; -int ibuflen _U_, *rbuflen; +int afp_getvolparams(AFPObj *obj _U_, char *ibuf, size_t ibuflen _U_,char *rbuf, size_t *rbuflen) { struct vol *vol; u_int16_t vid, bitmap; @@ -2234,10 +2276,7 @@ int ibuflen _U_, *rbuflen; } /* ------------------------- */ -int afp_setvolparams(obj, ibuf, ibuflen, rbuf, rbuflen ) -AFPObj *obj _U_; -char *ibuf, *rbuf _U_; -int ibuflen _U_, *rbuflen; +int afp_setvolparams(AFPObj *obj _U_, char *ibuf, size_t ibuflen _U_, char *rbuf _U_, size_t *rbuflen) { struct adouble ad; struct vol *vol; @@ -2462,9 +2501,6 @@ static int savevoloptions (const struct vol *vol) case AD_VERSION2_OSX: strlcat(buf, "ADOUBLE_VER:osx\n", sizeof(buf)); break; - case AD_VERSION1_ADS: - strlcat(buf, "ADOUBLE_VER:ads\n", sizeof(buf)); - break; case AD_VERSION1_SFM: strlcat(buf, "ADOUBLE_VER:sfm\n", sizeof(buf)); break; @@ -2478,8 +2514,9 @@ static int savevoloptions (const struct vol *vol) strlcat(buf, Cnid_srv, sizeof(buf)); strlcat(buf, "\n", sizeof(buf)); - snprintf(item, sizeof(item), "CNIDDBDPORT:%u\n", Cnid_port); - strlcat(buf, item, sizeof(buf)); + strlcat(buf, "CNIDDBDPORT:", sizeof(buf)); + strlcat(buf, Cnid_port, sizeof(buf)); + strlcat(buf, "\n", sizeof(buf)); strcpy(item, "CNID_DBPATH:"); if (vol->v_dbpath)