X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=etc%2Fafpd%2Fafp_dsi.c;h=bde1818bd7a1598ceedb48626671b45de674e9e6;hb=b0bcb8f6b0571592a50ce039882c9319e012a270;hp=cb1eb19f75d8d849a5153955fb745c3de82de91e;hpb=465246e257d9aff9855e3e35d8fd5983db932b45;p=netatalk.git diff --git a/etc/afpd/afp_dsi.c b/etc/afpd/afp_dsi.c index cb1eb19f..bde1818b 100644 --- a/etc/afpd/afp_dsi.c +++ b/etc/afpd/afp_dsi.c @@ -25,27 +25,25 @@ #endif /* HAVE_SYS_STAT_H */ #include #include -#include #include +#include +#include #include #include #include +#include #include #include #include - +#include #include + #include "switch.h" #include "auth.h" #include "fork.h" #include "dircache.h" -#ifdef FORCE_UIDGID -#warning UIDGID -#include "uid.h" -#endif /* FORCE_UIDGID */ - /* * We generally pass this from afp_over_dsi to all afp_* funcs, so it should already be * available everywhere. Unfortunately some funcs (eg acltoownermode) need acces to it @@ -137,21 +135,18 @@ static void ipc_reconnect_handler(int sig _U_) { DSI *dsi = (DSI *)AFPobj->handle; - LOG(log_note, logtype_afpd, "ipc_reconnect_handler: got SIGQUIT, trying IPC reconnect"); - if (reconnect_ipc(AFPobj) != 0) { LOG(log_error, logtype_afpd, "ipc_reconnect_handler: failed IPC reconnect"); afp_dsi_close(AFPobj); exit(EXITERR_SYS); } - LOG(log_note, logtype_afpd, "ipc_reconnect_handler: resending client ID"); if (ipc_child_write(AFPobj->ipc_fd, IPC_GETSESSION, AFPobj->sinfo.clientid_len, AFPobj->sinfo.clientid) != 0) { LOG(log_error, logtype_afpd, "ipc_reconnect_handler: failed IPC ID resend"); afp_dsi_close(AFPobj); exit(EXITERR_SYS); } - LOG(log_note, logtype_afpd, "ipc_reconnect_handler: done"); + LOG(log_note, logtype_afpd, "ipc_reconnect_handler: IPC reconnect done"); } /* SIGURG handler (primary reconnect) */ @@ -493,16 +488,25 @@ void afp_over_dsi(AFPObj *obj) dsi->flags &= ~DSI_RECONSOCKET; continue; } - /* Some error on the client connection, enter disconnected state */ - if (dsi_disconnect(dsi) != 0) - afp_dsi_die(EXITERR_CLNT); /* the client sometimes logs out (afp_logout) but doesn't close the DSI session */ if (dsi->flags & DSI_AFP_LOGGED_OUT) { + LOG(log_note, logtype_afpd, "afp_over_dsi: client logged out, terminating DSI session"); afp_dsi_close(obj); exit(0); } + /* got ECONNRESET in read from client => exit*/ + if (dsi->flags & DSI_GOT_ECONNRESET) { + LOG(log_note, logtype_afpd, "afp_over_dsi: client connection reset"); + afp_dsi_close(obj); + exit(0); + } + + /* Some error on the client connection, enter disconnected state */ + if (dsi_disconnect(dsi) != 0) + afp_dsi_die(EXITERR_CLNT); + pause(); /* gets interrupted by SIGALARM or SIGURG tickle */ continue; /* continue receiving until disconnect timer expires * or a primary reconnect succeeds */ @@ -601,11 +605,6 @@ void afp_over_dsi(AFPObj *obj) dir_free_invalid_q(); -#ifdef FORCE_UIDGID - /* bring everything back to old euid, egid */ - if (obj->force_uid) - restore_uidgid ( &obj->uidgid ); -#endif /* FORCE_UIDGID */ dsi->flags &= ~DSI_RUNNING; /* Add result to the AFP replay cache */ @@ -648,11 +647,6 @@ void afp_over_dsi(AFPObj *obj) AfpNum2name(function), AfpErr2name(err)); dsi->flags &= ~DSI_RUNNING; -#ifdef FORCE_UIDGID - /* bring everything back to old euid, egid */ - if (obj->force_uid) - restore_uidgid ( &obj->uidgid ); -#endif /* FORCE_UIDGID */ } else { LOG(log_error, logtype_afpd, "(write) bad function %x", function); dsi->datalen = 0; @@ -679,6 +673,8 @@ void afp_over_dsi(AFPObj *obj) break; } pending_request(dsi); + + vol_fce_tm_event(); } /* error */