/*
- * $Id: cnid.c,v 1.8 2009-11-24 11:40:11 didg Exp $
+ * $Id: cnid.c,v 1.13 2010-03-31 09:47:32 franklahm Exp $
*
* Copyright (c) 2003 the Netatalk Team
* Copyright (c) 2003 Rafal Lewczuk <rlewczuk@pronet.pl>
}
/* Opens CNID database using particular back-end */
-struct _cnid_db *cnid_open(const char *volpath, mode_t mask, char *type, int flags)
+struct _cnid_db *cnid_open(const char *volpath, mode_t mask, char *type, int flags,
+ const char *cnidsrv, const char *cnidport)
{
struct _cnid_db *db;
cnid_module *mod = NULL;
struct list_head *ptr;
uid_t uid = -1;
gid_t gid = -1;
-
+
list_for_each(ptr, &modules) {
if (0 == strcmp(list_entry(ptr, cnid_module, db_list)->name, type)) {
mod = list_entry(ptr, cnid_module, db_list);
return NULL;
}
- if ((mod->flags & CNID_FLAG_SETUID)) {
+ if ((mod->flags & CNID_FLAG_SETUID) && !(flags & CNID_FLAG_MEMORY)) {
uid = geteuid();
gid = getegid();
if (seteuid(0)) {
}
}
- db = mod->cnid_open(volpath, mask);
+ struct cnid_open_args args = {volpath, mask, flags, cnidsrv, cnidport};
+ db = mod->cnid_open(&args);
- if ((mod->flags & CNID_FLAG_SETUID)) {
+ if ((mod->flags & CNID_FLAG_SETUID) && !(flags & CNID_FLAG_MEMORY)) {
seteuid(0);
if ( setegid(gid) < 0 || seteuid(uid) < 0) {
LOG(log_error, logtype_afpd, "can't seteuid back %s", strerror(errno));
}
}
+/* -------------------
+ protect against bogus value from the DB.
+ adddir really doesn't like 2
+*/
+static cnid_t valide(cnid_t id)
+{
+ if (id == CNID_INVALID)
+ return id;
+
+ if (id < CNID_START) {
+ static int err = 0;
+ if (!err) {
+ err = 1;
+ LOG(log_error, logtype_afpd, "Error: Invalid cnid, corrupted DB?");
+ }
+ return CNID_INVALID;
+ }
+ return id;
+}
+
/* Closes CNID database. Currently it's just a wrapper around db->cnid_close(). */
void cnid_close(struct _cnid_db *db)
{
cnid_t ret;
block_signal(cdb->flags);
- ret = cdb->cnid_add(cdb, st, did, name, len, hint);
+ ret = valide(cdb->cnid_add(cdb, st, did, name, len, hint));
unblock_signal(cdb->flags);
return ret;
}
cnid_t ret;
block_signal(cdb->flags);
- ret = cdb->cnid_get(cdb, did, name, len);
+ ret = valide(cdb->cnid_get(cdb, did, name, len));
unblock_signal(cdb->flags);
return ret;
}
cnid_t ret;
block_signal(cdb->flags);
- ret = cdb->cnid_lookup(cdb, st, did, name, len);
+ ret = valide(cdb->cnid_lookup(cdb, st, did, name, len));
unblock_signal(cdb->flags);
return ret;
}