charts.d.plugin and tc-qos-helper.sh optimization to avoid frequent forks due to...

[netdata.git] / charts.d / hddtemp.chart.sh

diff --git a/charts.d/hddtemp.chart.sh b/charts.d/hddtemp.chart.sh
index 91bac6cff592c83360ae1fbceb5d1bfe6473956d..41c3e2478092a7df949fe8cb0c8ca353e0abe00b 100755 (executable)
--- a/charts.d/hddtemp.chart.sh
+++ b/charts.d/hddtemp.chart.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+# no need for shebang - this file is loaded from charts.d.plugin
 
 # if this chart is called X.chart.sh, then all functions and global variables
 # must start with X_
@@ -43,10 +43,15 @@ hddtemp_update() {
 #      local all=( `nc $hddtemp_host $hddtemp_port | awk 'BEGIN { FS="|" };{i=4; while (i <= NF) {print $i+0;i+=5;};}'` )
        OLD_IFS=$IFS
        set -f
-       IFS="|" all=( $(nc $hddtemp_host $hddtemp_port) )
+       IFS="|" all=( $(nc $hddtemp_host $hddtemp_port 2>/dev/null) )
        set +f
        IFS=$OLD_IFS
 
+       # check if there is some data
+       if [ -z "${all[3]}" ]; then 
+               return 1
+       fi
+
        # write the result of the work.
        echo "BEGIN hddtemp.temperature $1"
        end=${#hddtemp_disks[@]}