9 #include <sys/statvfs.h>
10 #include <sys/types.h>
16 #include "appconfig.h"
19 #include "plugin_proc.h"
21 #include "proc_self_mountinfo.h"
23 #define RRD_TYPE_DISK "disk"
25 #define DISK_TYPE_PHYSICAL 1
26 #define DISK_TYPE_PARTITION 2
27 #define DISK_TYPE_CONTAINER 3
37 struct disk *get_disk(unsigned long major, unsigned long minor) {
38 static char path_find_block_device[FILENAME_MAX + 1] = "";
39 static struct mountinfo *mountinfo_root = NULL;
42 // search for it in our RAM list.
43 // this is sequential, but since we just walk through
44 // and the number of disks / partitions in a system
45 // should not be that many, it should be acceptable
46 for(d = disk_root; d ; d = d->next)
47 if(unlikely(d->major == major && d->minor == minor))
50 // if we found it, return it
54 if(unlikely(!path_find_block_device[0])) {
55 char dirname[FILENAME_MAX + 1];
56 snprintfz(dirname, FILENAME_MAX, "%s%s", global_host_prefix, "/sys/dev/block/%lu:%lu/%s");
57 snprintfz(path_find_block_device, FILENAME_MAX, "%s", config_get("plugin:proc:/proc/diskstats", "path to get block device infos", dirname));
61 // create a new disk structure
62 d = (struct disk *)malloc(sizeof(struct disk));
63 if(!d) fatal("Cannot allocate memory for struct disk in proc_diskstats.");
67 d->type = DISK_TYPE_PHYSICAL; // Default type. Changed later if not correct.
70 // append it to the list
75 for(last = disk_root; last->next ;last = last->next);
79 // ------------------------------------------------------------------------
80 // find the type of the device
82 // find if it is a partition
83 // by checking if /sys/dev/block/MAJOR:MINOR/partition is readable.
84 char buffer[FILENAME_MAX + 1];
85 snprintfz(buffer, FILENAME_MAX, path_find_block_device, major, minor, "partition");
86 if(access(buffer, R_OK) == 0) {
87 d->type = DISK_TYPE_PARTITION;
89 // find if it is a container
90 // by checking if /sys/dev/block/MAJOR:MINOR/slaves has entries
92 snprintfz(buffer, FILENAME_MAX, path_find_block_device, major, minor, "slaves/");
93 DIR *dirp = opendir(buffer);
96 while(dp = readdir(dirp)) {
97 // . and .. are also files in empty folders.
98 if(strcmp(dp->d_name, ".") == 0 || strcmp(dp->d_name, "..") == 0) {
101 d->type = DISK_TYPE_CONTAINER;
102 // Stop the loop after we found one file.
105 if(closedir(dirp) == -1)
106 error("Unable to close dir %s", buffer);
110 // ------------------------------------------------------------------------
111 // check if we can find its mount point
113 // mountinfo_find() can be called with NULL mountinfo_root
114 struct mountinfo *mi = mountinfo_find(mountinfo_root, d->major, d->minor);
116 // mountinfo_free() can be called with NULL mountinfo_root
117 mountinfo_free(mountinfo_root);
119 // re-read mountinfo in case something changed
120 mountinfo_root = mountinfo_read();
122 // search again for this disk
123 mi = mountinfo_find(mountinfo_root, d->major, d->minor);
127 d->mount_point = strdup(mi->mount_point);
128 // no need to check for NULL
130 d->mount_point = NULL;
135 int do_proc_diskstats(int update_every, unsigned long long dt) {
136 static procfile *ff = NULL;
137 static char path_to_get_hw_sector_size[FILENAME_MAX + 1] = "";
138 static int enable_new_disks = -1;
139 static int do_io = -1, do_ops = -1, do_mops = -1, do_iotime = -1, do_qops = -1, do_util = -1, do_backlog = -1, do_space = -1;
140 static struct statvfs buff_statvfs;
142 if(enable_new_disks == -1) enable_new_disks = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "enable new disks detected at runtime", CONFIG_ONDEMAND_ONDEMAND);
144 if(do_io == -1) do_io = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "bandwidth for all disks", CONFIG_ONDEMAND_ONDEMAND);
145 if(do_ops == -1) do_ops = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "operations for all disks", CONFIG_ONDEMAND_ONDEMAND);
146 if(do_mops == -1) do_mops = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "merged operations for all disks", CONFIG_ONDEMAND_ONDEMAND);
147 if(do_iotime == -1) do_iotime = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "i/o time for all disks", CONFIG_ONDEMAND_ONDEMAND);
148 if(do_qops == -1) do_qops = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "queued operations for all disks", CONFIG_ONDEMAND_ONDEMAND);
149 if(do_util == -1) do_util = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "utilization percentage for all disks", CONFIG_ONDEMAND_ONDEMAND);
150 if(do_backlog == -1)do_backlog = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "backlog for all disks", CONFIG_ONDEMAND_ONDEMAND);
151 if(do_space == -1) do_space = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "space usage for all disks", CONFIG_ONDEMAND_ONDEMAND);
154 char filename[FILENAME_MAX + 1];
155 snprintfz(filename, FILENAME_MAX, "%s%s", global_host_prefix, "/proc/diskstats");
156 ff = procfile_open(config_get("plugin:proc:/proc/diskstats", "filename to monitor", filename), " \t", PROCFILE_FLAG_DEFAULT);
160 if(!path_to_get_hw_sector_size[0]) {
161 char filename[FILENAME_MAX + 1];
162 snprintfz(filename, FILENAME_MAX, "%s%s", global_host_prefix, "/sys/block/%s/queue/hw_sector_size");
163 snprintfz(path_to_get_hw_sector_size, FILENAME_MAX, "%s", config_get("plugin:proc:/proc/diskstats", "path to get h/w sector size", filename));
166 ff = procfile_readall(ff);
167 if(!ff) return 0; // we return 0, so that we will retry to open it next time
169 uint32_t lines = procfile_lines(ff), l;
172 for(l = 0; l < lines ;l++) {
174 unsigned long long major = 0, minor = 0,
175 reads = 0, mreads = 0, readsectors = 0, readms = 0,
176 writes = 0, mwrites = 0, writesectors = 0, writems = 0,
177 queued_ios = 0, busy_ms = 0, backlog_ms = 0,
178 space_avail = 0, space_avail_root = 0, space_used = 0;
180 unsigned long long last_reads = 0, last_readsectors = 0, last_readms = 0,
181 last_writes = 0, last_writesectors = 0, last_writems = 0,
184 words = procfile_linewords(ff, l);
185 if(words < 14) continue;
187 major = strtoull(procfile_lineword(ff, l, 0), NULL, 10);
188 minor = strtoull(procfile_lineword(ff, l, 1), NULL, 10);
189 disk = procfile_lineword(ff, l, 2);
191 // # of reads completed # of writes completed
192 // This is the total number of reads or writes completed successfully.
193 reads = strtoull(procfile_lineword(ff, l, 3), NULL, 10); // rd_ios
194 writes = strtoull(procfile_lineword(ff, l, 7), NULL, 10); // wr_ios
196 // # of reads merged # of writes merged
197 // Reads and writes which are adjacent to each other may be merged for
198 // efficiency. Thus two 4K reads may become one 8K read before it is
199 // ultimately handed to the disk, and so it will be counted (and queued)
200 mreads = strtoull(procfile_lineword(ff, l, 4), NULL, 10); // rd_merges_or_rd_sec
201 mwrites = strtoull(procfile_lineword(ff, l, 8), NULL, 10); // wr_merges
203 // # of sectors read # of sectors written
204 // This is the total number of sectors read or written successfully.
205 readsectors = strtoull(procfile_lineword(ff, l, 5), NULL, 10); // rd_sec_or_wr_ios
206 writesectors = strtoull(procfile_lineword(ff, l, 9), NULL, 10); // wr_sec
208 // # of milliseconds spent reading # of milliseconds spent writing
209 // This is the total number of milliseconds spent by all reads or writes (as
210 // measured from __make_request() to end_that_request_last()).
211 readms = strtoull(procfile_lineword(ff, l, 6), NULL, 10); // rd_ticks_or_wr_sec
212 writems = strtoull(procfile_lineword(ff, l, 10), NULL, 10); // wr_ticks
214 // # of I/Os currently in progress
215 // The only field that should go to zero. Incremented as requests are
216 // given to appropriate struct request_queue and decremented as they finish.
217 queued_ios = strtoull(procfile_lineword(ff, l, 11), NULL, 10); // ios_pgr
219 // # of milliseconds spent doing I/Os
220 // This field increases so long as field queued_ios is nonzero.
221 busy_ms = strtoull(procfile_lineword(ff, l, 12), NULL, 10); // tot_ticks
223 // weighted # of milliseconds spent doing I/Os
224 // This field is incremented at each I/O start, I/O completion, I/O
225 // merge, or read of these stats by the number of I/Os in progress
226 // (field queued_ios) times the number of milliseconds spent doing I/O since the
227 // last update of this field. This can provide an easy measure of both
228 // I/O completion time and the backlog that may be accumulating.
229 backlog_ms = strtoull(procfile_lineword(ff, l, 13), NULL, 10); // rq_ticks
233 // remove slashes from disk names
235 for(s = disk; *s ;s++) if(*s == '/') *s = '_';
237 struct disk *d = get_disk(major, minor);
239 // Enable statistics for physical disks and mount points by default.
240 if( (d->type == DISK_TYPE_PHYSICAL) || (d->mount_point != NULL) ) {
241 def_enabled = enable_new_disks;
245 // Enable physical disks by default.
246 // To fine out if it is a harddrive we use
247 // Linux Assigned Names and Numbers Authority (http://www.lanana.org/)
248 // We can't do that because proprietary disk drivers do not stick to
249 // the standard. To detect re
251 case 8: // SCSI disk devices (0-15)
253 def_enabled = enable_new_disks;
256 case 21: // Acorn MFM hard drive interface
258 def_enabled = enable_new_disks;
261 case 28: // ACSI disk (68k/Atari)
263 def_enabled = enable_new_disks;
266 case 36: // MCA ESDI hard disk
268 def_enabled = enable_new_disks;
271 case 48: // Mylex DAC960 PCI RAID controller; first controller
273 def_enabled = enable_new_disks;
276 case 49: // Mylex DAC960 PCI RAID controller; second controller
278 def_enabled = enable_new_disks;
281 case 50: // Mylex DAC960 PCI RAID controller; third controller
283 def_enabled = enable_new_disks;
286 case 51: // Mylex DAC960 PCI RAID controller; fourth controller
288 def_enabled = enable_new_disks;
291 case 52: // Mylex DAC960 PCI RAID controller; fifth controller
293 def_enabled = enable_new_disks;
296 case 53: // Mylex DAC960 PCI RAID controller; sixth controller
298 def_enabled = enable_new_disks;
301 case 54: // Mylex DAC960 PCI RAID controller; seventh controller
303 def_enabled = enable_new_disks;
306 case 55: // Mylex DAC960 PCI RAID controller; eigth controller
308 def_enabled = enable_new_disks;
311 case 65: // SCSI disk devices (16-31)
313 def_enabled = enable_new_disks;
316 case 66: // SCSI disk devices (32-47)
318 def_enabled = enable_new_disks;
321 case 67: // SCSI disk devices (48-63)
323 def_enabled = enable_new_disks;
326 case 68: // SCSI disk devices (64-79)
328 def_enabled = enable_new_disks;
331 case 69: // SCSI disk devices (80-95)
333 def_enabled = enable_new_disks;
336 case 70: // SCSI disk devices (96-111)
338 def_enabled = enable_new_disks;
341 case 71: // SCSI disk devices (112-127)
343 def_enabled = enable_new_disks;
346 case 80: // I2O hard disk
348 def_enabled = enable_new_disks;
351 case 81: // I2O hard disk
353 def_enabled = enable_new_disks;
356 case 82: // I2O hard disk
358 def_enabled = enable_new_disks;
361 case 83: // I2O hard disk
363 def_enabled = enable_new_disks;
366 case 84: // I2O hard disk
368 def_enabled = enable_new_disks;
371 case 85: // I2O hard disk
373 def_enabled = enable_new_disks;
376 case 86: // I2O hard disk
378 def_enabled = enable_new_disks;
381 case 87: // I2O hard disk
383 def_enabled = enable_new_disks;
386 case 128: // SCSI disk devices (128-143)
388 def_enabled = enable_new_disks;
391 case 129: // SCSI disk devices (144-159)
393 def_enabled = enable_new_disks;
396 case 130: // SCSI disk devices (160-175)
398 def_enabled = enable_new_disks;
401 case 131: // SCSI disk devices (176-191)
403 def_enabled = enable_new_disks;
406 case 132: // SCSI disk devices (192-207)
408 def_enabled = enable_new_disks;
411 case 133: // SCSI disk devices (208-223)
413 def_enabled = enable_new_disks;
416 case 134: // SCSI disk devices (224-239)
418 def_enabled = enable_new_disks;
421 case 135: // SCSI disk devices (240-255)
423 def_enabled = enable_new_disks;
426 case 136: // Mylex DAC960 PCI RAID controller; nineth controller
428 def_enabled = enable_new_disks;
431 case 137: // Mylex DAC960 PCI RAID controller; tenth controller
433 def_enabled = enable_new_disks;
436 case 138: // Mylex DAC960 PCI RAID controller; eleventh controller
438 def_enabled = enable_new_disks;
441 case 139: // Mylex DAC960 PCI RAID controller; twelfth controller
443 def_enabled = enable_new_disks;
446 case 140: // Mylex DAC960 PCI RAID controller; thirteenth controller
448 def_enabled = enable_new_disks;
451 case 141: // Mylex DAC960 PCI RAID controller; fourteenth controller
453 def_enabled = enable_new_disks;
456 case 142: // Mylex DAC960 PCI RAID controller; fifteenth controller
458 def_enabled = enable_new_disks;
461 case 143: // Mylex DAC960 PCI RAID controller; sixteenth controller
463 def_enabled = enable_new_disks;
466 case 160: // Carmel 8-port SATA Disks on First Controller
468 def_enabled = enable_new_disks;
471 case 161: // Carmel 8-port SATA Disks on Second Controller
473 def_enabled = enable_new_disks;
482 char *mount_point = d->mount_point;
483 char *family = d->mount_point;
484 if(!family) family = disk;
486 int ddo_io = do_io, ddo_ops = do_ops, ddo_mops = do_mops, ddo_iotime = do_iotime, ddo_qops = do_qops, ddo_util = do_util, ddo_backlog = do_backlog, ddo_space = do_space;
488 // check which charts are enabled for this disk
490 char var_name[4096 + 1];
491 snprintfz(var_name, 4096, "plugin:proc:/proc/diskstats:%s", disk);
492 def_enabled = config_get_boolean_ondemand(var_name, "enabled", def_enabled);
493 if(def_enabled == CONFIG_ONDEMAND_NO) continue;
494 if(def_enabled == CONFIG_ONDEMAND_ONDEMAND && !reads && !writes) continue;
497 ddo_io = config_get_boolean_ondemand(var_name, "bandwidth", ddo_io);
498 ddo_ops = config_get_boolean_ondemand(var_name, "operations", ddo_ops);
499 ddo_mops = config_get_boolean_ondemand(var_name, "merged operations", ddo_mops);
500 ddo_iotime = config_get_boolean_ondemand(var_name, "i/o time", ddo_iotime);
501 ddo_qops = config_get_boolean_ondemand(var_name, "queued operations", ddo_qops);
502 ddo_util = config_get_boolean_ondemand(var_name, "utilization percentage", ddo_util);
503 ddo_backlog = config_get_boolean_ondemand(var_name, "backlog", ddo_backlog);
504 ddo_space = config_get_boolean_ondemand(var_name, "space", ddo_space);
506 // by default, do not add charts that do not have values
507 if(ddo_io == CONFIG_ONDEMAND_ONDEMAND && !reads && !writes) ddo_io = 0;
508 if(ddo_mops == CONFIG_ONDEMAND_ONDEMAND && mreads == 0 && mwrites == 0) ddo_mops = 0;
509 if(ddo_iotime == CONFIG_ONDEMAND_ONDEMAND && readms == 0 && writems == 0) ddo_iotime = 0;
510 if(ddo_util == CONFIG_ONDEMAND_ONDEMAND && busy_ms == 0) ddo_util = 0;
511 if(ddo_backlog == CONFIG_ONDEMAND_ONDEMAND && backlog_ms == 0) ddo_backlog = 0;
512 if(ddo_qops == CONFIG_ONDEMAND_ONDEMAND && backlog_ms == 0) ddo_qops = 0;
514 // for absolute values, we need to switch the setting to 'yes'
515 // to allow it refresh from now on
516 if(ddo_qops == CONFIG_ONDEMAND_ONDEMAND) config_set(var_name, "queued operations", "yes");
521 // --------------------------------------------------------------------
523 int sector_size = 512;
525 st = rrdset_find_bytype(RRD_TYPE_DISK, disk);
527 char tf[FILENAME_MAX + 1], *t;
528 char ssfilename[FILENAME_MAX + 1];
530 strncpyz(tf, disk, FILENAME_MAX);
532 // replace all / with !
533 while((t = strchr(tf, '/'))) *t = '!';
535 snprintfz(ssfilename, FILENAME_MAX, path_to_get_hw_sector_size, tf);
536 FILE *fpss = fopen(ssfilename, "r");
539 char *tmp = fgets(ssbuffer, 1024, fpss);
542 sector_size = atoi(tmp);
543 if(sector_size <= 0) {
544 error("Invalid sector size %d for device %s in %s. Assuming 512.", sector_size, disk, ssfilename);
548 else error("Cannot read data for sector size for device %s from %s. Assuming 512.", disk, ssfilename);
552 else error("Cannot read sector size for device %s from %s. Assuming 512.", disk, ssfilename);
554 st = rrdset_create(RRD_TYPE_DISK, disk, NULL, family, "disk.io", "Disk I/O Bandwidth", "kilobytes/s", 2000, update_every, RRDSET_TYPE_AREA);
556 rrddim_add(st, "reads", NULL, sector_size, 1024, RRDDIM_INCREMENTAL);
557 rrddim_add(st, "writes", NULL, sector_size * -1, 1024, RRDDIM_INCREMENTAL);
559 else rrdset_next_usec(st, dt);
561 last_readsectors = rrddim_set(st, "reads", readsectors);
562 last_writesectors = rrddim_set(st, "writes", writesectors);
566 // --------------------------------------------------------------------
569 st = rrdset_find_bytype("disk_ops", disk);
571 st = rrdset_create("disk_ops", disk, NULL, family, "disk.ops", "Disk Completed I/O Operations", "operations/s", 2001, update_every, RRDSET_TYPE_LINE);
574 rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_INCREMENTAL);
575 rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_INCREMENTAL);
577 else rrdset_next_usec(st, dt);
579 last_reads = rrddim_set(st, "reads", reads);
580 last_writes = rrddim_set(st, "writes", writes);
584 // --------------------------------------------------------------------
587 st = rrdset_find_bytype("disk_qops", disk);
589 st = rrdset_create("disk_qops", disk, NULL, family, "disk.qops", "Disk Current I/O Operations", "operations", 2002, update_every, RRDSET_TYPE_LINE);
592 rrddim_add(st, "operations", NULL, 1, 1, RRDDIM_ABSOLUTE);
594 else rrdset_next_usec(st, dt);
596 rrddim_set(st, "operations", queued_ios);
600 // --------------------------------------------------------------------
603 st = rrdset_find_bytype("disk_backlog", disk);
605 st = rrdset_create("disk_backlog", disk, NULL, family, "disk.backlog", "Disk Backlog", "backlog (ms)", 2003, update_every, RRDSET_TYPE_AREA);
608 rrddim_add(st, "backlog", NULL, 1, 10, RRDDIM_INCREMENTAL);
610 else rrdset_next_usec(st, dt);
612 rrddim_set(st, "backlog", backlog_ms);
616 // --------------------------------------------------------------------
619 st = rrdset_find_bytype("disk_util", disk);
621 st = rrdset_create("disk_util", disk, NULL, family, "disk.util", "Disk Utilization Time", "% of time working", 2004, update_every, RRDSET_TYPE_AREA);
624 rrddim_add(st, "utilization", NULL, 1, 10, RRDDIM_INCREMENTAL);
626 else rrdset_next_usec(st, dt);
628 last_busy_ms = rrddim_set(st, "utilization", busy_ms);
632 // --------------------------------------------------------------------
635 st = rrdset_find_bytype("disk_mops", disk);
637 st = rrdset_create("disk_mops", disk, NULL, family, "disk.mops", "Disk Merged Operations", "merged operations/s", 2021, update_every, RRDSET_TYPE_LINE);
640 rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_INCREMENTAL);
641 rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_INCREMENTAL);
643 else rrdset_next_usec(st, dt);
645 rrddim_set(st, "reads", mreads);
646 rrddim_set(st, "writes", mwrites);
650 // --------------------------------------------------------------------
653 st = rrdset_find_bytype("disk_iotime", disk);
655 st = rrdset_create("disk_iotime", disk, NULL, family, "disk.iotime", "Disk Total I/O Time", "milliseconds/s", 2022, update_every, RRDSET_TYPE_LINE);
658 rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_INCREMENTAL);
659 rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_INCREMENTAL);
661 else rrdset_next_usec(st, dt);
663 last_readms = rrddim_set(st, "reads", readms);
664 last_writems = rrddim_set(st, "writes", writems);
668 // --------------------------------------------------------------------
672 if(ddo_space != CONFIG_ONDEMAND_ONDEMAND) {
673 error("Cannot find space usage for disk %s. It does not have a mount point.", family);
676 if (statvfs(family, &buff_statvfs) < 0) {
677 error("Failed checking disk space usage of %s", family);
679 space_avail = buff_statvfs.f_bavail * buff_statvfs.f_bsize;
680 space_avail_root = (buff_statvfs.f_bfree - buff_statvfs.f_bavail) * buff_statvfs.f_bsize;
681 space_used = (buff_statvfs.f_blocks - buff_statvfs.f_bfree) * buff_statvfs.f_bsize;
683 st = rrdset_find_bytype("disk_space", disk);
685 st = rrdset_create("disk_space", disk, NULL, family, "disk.space", "Disk Space Usage", "GB", 2023, update_every, RRDSET_TYPE_STACKED);
688 rrddim_add(st, "avail", NULL, 1, 1000*1000*1000, RRDDIM_ABSOLUTE);
689 rrddim_add(st, "reserved_for_root", "reserved for root", 1, 1000*1000*1000, RRDDIM_ABSOLUTE);
690 rrddim_add(st, "used" , NULL, 1, 1000*1000*1000, RRDDIM_ABSOLUTE);
692 else rrdset_next_usec(st, dt);
694 rrddim_set(st, "avail", space_avail);
695 rrddim_set(st, "reserved_for_root", space_avail_root);
696 rrddim_set(st, "used", space_used);
702 // --------------------------------------------------------------------
703 // calculate differential charts
704 // only if this is not the first time we run
707 if(ddo_iotime && ddo_ops) {
708 st = rrdset_find_bytype("disk_await", disk);
710 st = rrdset_create("disk_await", disk, NULL, family, "disk.await", "Average Completed I/O Operation Time", "ms per operation", 2005, update_every, RRDSET_TYPE_LINE);
713 rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_ABSOLUTE);
714 rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_ABSOLUTE);
716 else rrdset_next_usec(st, dt);
718 rrddim_set(st, "reads", (reads - last_reads) ? (readms - last_readms) / (reads - last_reads) : 0);
719 rrddim_set(st, "writes", (writes - last_writes) ? (writems - last_writems) / (writes - last_writes) : 0);
723 if(ddo_io && ddo_ops) {
724 st = rrdset_find_bytype("disk_avgsz", disk);
726 st = rrdset_create("disk_avgsz", disk, NULL, family, "disk.avgsz", "Average Completed I/O Operation Bandwidth", "kilobytes per operation", 2006, update_every, RRDSET_TYPE_AREA);
729 rrddim_add(st, "reads", NULL, sector_size, 1024, RRDDIM_ABSOLUTE);
730 rrddim_add(st, "writes", NULL, -sector_size, 1024, RRDDIM_ABSOLUTE);
732 else rrdset_next_usec(st, dt);
734 rrddim_set(st, "reads", (reads - last_reads) ? (readsectors - last_readsectors) / (reads - last_reads) : 0);
735 rrddim_set(st, "writes", (writes - last_writes) ? (writesectors - last_writesectors) / (writes - last_writes) : 0);
739 if(ddo_util && ddo_ops) {
740 st = rrdset_find_bytype("disk_svctm", disk);
742 st = rrdset_create("disk_svctm", disk, NULL, family, "disk.svctm", "Average Service Time", "ms per operation", 2007, update_every, RRDSET_TYPE_LINE);
745 rrddim_add(st, "svctm", NULL, 1, 1, RRDDIM_ABSOLUTE);
747 else rrdset_next_usec(st, dt);
749 rrddim_set(st, "svctm", ((reads - last_reads) + (writes - last_writes)) ? (busy_ms - last_busy_ms) / ((reads - last_reads) + (writes - last_writes)) : 0);