(Report imported from Bugzilla #129)

Status CLOSED, severity enhancement, in component Daemon.
Reported in version development on platform All.
Assigned to: Alexander Barton.

Original attachment names and IDs:

• show_usermodes_in_whois.patch (ID 74)
• show_usermodes_in_whois.patch (ID 77)
• show_usermodes_in_whois.patch (ID 78)
• show_usermodes_in_whois.patch (ID 79)

On 2012-09-03 18:32:37 +0200, DNS wrote:

Some clients do not show user modes in the client itself, so it would be nice to see your own user modes in your whois. And i think opers should be able to see user modes of others, too.

On 2012-09-10 17:28:46 +0200, Alexander Barton wrote:

1. Modes in WHOIS reply: do you know some numeric that is used by other servers?
2. Modes visible for IRC Ops: which other server implements this? And using which command, MODE?

On 2012-09-10 23:35:47 +0200, DNS wrote:

1. 221 RPL_UMODEIS (defined in RFC1459)
   https://www.alien.net.au/irc/irc2numerics.html
2. i know this from InspIRCd. shown in '/whois user user'

On 2012-09-25 19:22:04 +0200, DNS wrote:

Some codes from other ircds related to RPL_UMODEIS:

Charybdis/Ratbox: http://hg.atheme.org/charybdis/file/tip/src/s_user.c#l954

InspIRCd: https://gitorious.org/inspircd/inspircd/blobs/SHA: 2ee9e72e3be36be81369e92853d4c022a3c8c35e/src/mode.cpp#line344

IRCd: http://www.irc.org/ftp/irc/org/irc2.11.2p3/ircd/s_user.c (Just search for RPL_UMODEIS)

Unreal: http://hg.unrealircd.com/hg/unreal/file/b774480aa8c8/src/modules/m_mode.c#l2156

On 2012-10-02 03:21:28 +0200, DNS wrote:

Created attachment 74
Show usermodes in whois

Shows usermodes in whois, for yourself or an oper (if MorePrivacy isn't enabled)

Saw a bit late that ngircd has RPL_UMODEIS already implemented.
I tried to use this to display it in whois but the output was very different with different irc clients. For example weechat adds a text to the numeric and xchat nothing.
Now, because of this issue, i have decided to create a new and 'special' RPL reply (320), which is unused so far, to display the modes in whois.

Check the patch, i hope youll like it. :-)

On 2012-10-06 16:55:03 +0200, Alexander Barton wrote:

(In reply to comment # 4)

Saw a bit late that ngircd has RPL_UMODEIS already implemented.
I tried to use this to display it in whois but the output was very different
with different irc clients. For example weechat adds a text to the numeric and
xchat nothing.
Now, because of this issue, i have decided to create a new and 'special' RPL
reply (320), which is unused so far, to display the modes in whois.

Check the patch, i hope youll like it. :-)

I don't :-)

InspIRCd 1.2 uses numeric 379 for this purpose, like this:

:inspircd-12.test 379 TestNick TestNick :is using modes +x

So please use the same numeric and same syntax in ngIRCd.
But the patch looks good :-)

Are you going to fix it up? Or should I?

On 2012-10-06 21:07:27 +0200, DNS wrote:

Created attachment 77
Show usermodes in whois

Update as suggested. :-)

On 2012-10-06 21:11:44 +0200, DNS wrote:

Created attachment 78
Show usermodes in whois

Fix RPL (MSG suffix forgotten ^^)

On 2012-10-06 21:14:14 +0200, DNS wrote:

Created attachment 79
Show usermodes in whois (FINAL lol)

sorry, fixed once more

On 2012-10-06 22:01:15 +0200, Alexander Barton wrote:

(In reply to comment # 8)

Created attachment 79 [details]
Show usermodes in whois (FINAL lol)

sorry, fixed once more

Patch adapter for our current master branch and applied; commit ID 56cdc21.
Thanks!

On 2013-02-11 22:37:11 +0100, Alexander Barton wrote:

Patch included in ngIRCd 20.
Bug closed.