From a87b124648f6eb9e00c9ea16c638fe380dd019f7 Mon Sep 17 00:00:00 2001 From: Alexander Barton Date: Fri, 19 Jan 2024 16:55:23 +0100 Subject: [PATCH] Use -Werror when testing for -Wno-format-truncation Clang does not know the -Wno-format-truncation option of (current) GCC, but accepts unknown -W... options (exit core 0) but issues a warning message on every invocation. So for example on macOS, where Clang is used as "gcc", a new warning message was shown for every file to compile, since we enabled -Wno-format-truncation in commit 1d527eaf: warning: unknown warning option '-Wno-format-truncation' [-Wunknown-warning-option] Clang no longer acceps unknown -W... options by enabling -Werror, which this patch adds to the CFLAGS while testing for -Wno-format-truncation, which fixes this issue. This fixes commit 1d527eaf. --- configure.ng | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/configure.ng b/configure.ng index b2652c64..346b6aa8 100644 --- a/configure.ng +++ b/configure.ng @@ -129,10 +129,12 @@ AC_DEFUN([GCC_W_NO_FORMAT_TRUNC],[ result=yes AC_MSG_CHECKING([whether ${CC} accepts -Wno-format-truncation]) old_cflags="$CFLAGS" - CFLAGS="$CFLAGS -Wno-format-truncation" + CFLAGS="$CFLAGS -Werror -Wno-format-truncation" AC_LINK_IFELSE([AC_LANG_PROGRAM([],[])],[],[result=no]) echo $result - if test "X$result" = "Xno"; then + if test "X$result" = "Xyes"; then + CFLAGS="$old_cflags -Wno-format-truncation" + else CFLAGS="$old_cflags" fi ]) -- 2.39.2