From: Alexander Barton <alex@barton.de>
Date: Tue, 13 Jul 2010 20:29:06 +0000 (+0200)
Subject: Don't Proc_Kill() childs after Proc_Read(): done there already.
X-Git-Tag: rel-17-rc1~57
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9cd3494de92eccaa201f42fc8b02fc68c752aca8;p=ngircd.git

Don't Proc_Kill() childs after Proc_Read(): done there already.
---

diff --git a/src/ngircd/irc-login.c b/src/ngircd/irc-login.c
index 8ac5471a..93ee07e8 100644
--- a/src/ngircd/irc-login.c
+++ b/src/ngircd/irc-login.c
@@ -847,9 +847,6 @@ cb_Read_Auth_Result(int r_fd, UNUSED short events)
 	if (len == 0)
 		return;
 
-	/* Make sure authenticator sub-process is dead now ... */
-	Proc_Kill(proc);
-
 	if (len != sizeof(result)) {
 		Log(LOG_CRIT, "Auth: Got malformed result!");
 		Reject_Client(client);
diff --git a/src/ngircd/proc.c b/src/ngircd/proc.c
index 11cb0396..1e8cac36 100644
--- a/src/ngircd/proc.c
+++ b/src/ngircd/proc.c
@@ -119,6 +119,8 @@ Proc_GenericSignalHandler(int Signal)
 
 /**
  * Read bytes from a pipe of a forked child process.
+ * In addition, this function makes sure that the child process is dead
+ * after all data has been read or a fatal error occurred.
  */
 GLOBAL size_t
 Proc_Read(PROC_STAT *proc, void *buffer, size_t buflen)